From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: akpm@linux-foundation.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [LKML] [PATCH -mm 0/6] remove unnecessary sync_single_range_* in dma_map_ops
Date: Tue, 27 Apr 2010 13:07:15 -0400 [thread overview]
Message-ID: <20100427170715.GA24826@phenom.dumpdata.com> (raw)
In-Reply-To: <1272371140-6085-1-git-send-email-fujita.tomonori@lab.ntt.co.jp>
On Tue, Apr 27, 2010 at 09:25:34PM +0900, FUJITA Tomonori wrote:
> This patchset removes useless sync_single_range_for_cpu and
> sync_single_range_for_device hooks in dma_map_ops. These hooks were
> for dma_sync_single_range_* DMA API, however, the API became obsolete
> (the description in DMA API docs was removed too). Architecutres
> should use sync_single_for_cpu and sync_single_for_device hooks
> instead (as DMA API docs say, they need to support a partial sync).
>
> We could remove dma_sync_single_range_* DMA API completely (no user in
> -mm) but the API had been until 2.6.34-rc so I guess that it might be
> better to leave it alone for some time.
>
> The first patch is a bug fix and might be 2.6.34-rc material however
> the API is not so popular (only net/b44.c uses) and we are already in
> -rc5. I guess that it would be fine to merge it in the next merge
> window.
Not sure if this is needed since the patches aren't that complex, but I
did do a review of all of them. Hence:
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
next prev parent reply other threads:[~2010-04-27 17:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 12:25 [PATCH -mm 0/6] remove unnecessary sync_single_range_* in dma_map_ops FUJITA Tomonori
2010-04-27 12:25 ` FUJITA Tomonori
2010-04-27 12:25 ` [PATCH -mm 1/6] dma-mapping: fix dma_sync_single_range_* FUJITA Tomonori
2010-04-27 12:25 ` [PATCH -mm 2/6] ia64: remove unnecessary sync_single_range_* in swiotlb_dma_ops FUJITA Tomonori
2010-04-27 12:25 ` FUJITA Tomonori
2010-04-27 12:25 ` [PATCH -mm 3/6] x86: " FUJITA Tomonori
2010-04-27 12:25 ` FUJITA Tomonori
2010-04-27 12:25 ` [PATCH -mm 4/6] powerpc: " FUJITA Tomonori
2010-04-27 12:25 ` [PATCH -mm 5/6] swiotlb: remove unnecessary swiotlb_sync_single_range_* FUJITA Tomonori
2010-04-27 12:25 ` [PATCH -mm 6/6] dma-mapping: remove unnecessary sync_single_range_* in dma_map_ops FUJITA Tomonori
2010-04-27 12:25 ` FUJITA Tomonori
2010-04-27 17:07 ` Konrad Rzeszutek Wilk [this message]
2010-05-10 9:29 ` [PATCH -mm 0/6] " Russell King
2010-05-10 9:49 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100427170715.GA24826@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).