From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [LKML] [PATCH -mm 0/6] remove unnecessary sync_single_range_* in dma_map_ops Date: Tue, 27 Apr 2010 13:07:15 -0400 Message-ID: <20100427170715.GA24826@phenom.dumpdata.com> References: <1272371140-6085-1-git-send-email-fujita.tomonori@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from rcsinet10.oracle.com ([148.87.113.121]:41712 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754107Ab0D0RIT (ORCPT >); Tue, 27 Apr 2010 13:08:19 -0400 Content-Disposition: inline In-Reply-To: <1272371140-6085-1-git-send-email-fujita.tomonori@lab.ntt.co.jp> Sender: linux-arch-owner@vger.kernel.org List-ID: To: FUJITA Tomonori Cc: akpm@linux-foundation.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Apr 27, 2010 at 09:25:34PM +0900, FUJITA Tomonori wrote: > This patchset removes useless sync_single_range_for_cpu and > sync_single_range_for_device hooks in dma_map_ops. These hooks were > for dma_sync_single_range_* DMA API, however, the API became obsolete > (the description in DMA API docs was removed too). Architecutres > should use sync_single_for_cpu and sync_single_for_device hooks > instead (as DMA API docs say, they need to support a partial sync). > > We could remove dma_sync_single_range_* DMA API completely (no user in > -mm) but the API had been until 2.6.34-rc so I guess that it might be > better to leave it alone for some time. > > The first patch is a bug fix and might be 2.6.34-rc material however > the API is not so popular (only net/b44.c uses) and we are already in > -rc5. I guess that it would be fine to merge it in the next merge > window. Not sure if this is needed since the patches aren't that complex, but I did do a review of all of them. Hence: Reviewed-by: Konrad Rzeszutek Wilk