From: Jamie Lokier <jamie@shareable.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Peter Fritzsche <peter.fritzsche@gmx.de>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Keith M Wesolowski <wesolows@foobazco.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [PATCH 2/2] asm-generic: Don't warn that atomic_t is only 24 bit
Date: Wed, 28 Apr 2010 16:28:15 +0100 [thread overview]
Message-ID: <20100428152815.GB25569@shareable.org> (raw)
In-Reply-To: <20100428135434.GA4662@Krystal>
Mathieu Desnoyers wrote:
> * Arnd Bergmann (arnd@arndb.de) wrote:
> > On Wednesday 28 April 2010, Peter Fritzsche wrote:
> > > 32-bit Sparc used to only allow usage of 24-bit of it's atomic_t type.
> > > This was corrected with linux 2.6.3 when Keith M Wesolowski changed the
> > > implementation to use the parisc approach of having an array of
> > > spinlocks to protect the atomic_t.
> > >
> > > These warnings were also removed from the sparc implementation when the
> > > new implementation was merged in BKrev:402e4949VThdc6D3iaosSFUgabMfvw,
> > > but the warning still remained in some other places without any
> > > 24-bit-only atomic_t implementation inside the kernel.
> > >
> > > We should remove these warnings to allow users to rely on the full
> > > 32-bit range of atomic_t.
> > >
> > > Signed-off-by: Peter Fritzsche <peter.fritzsche@gmx.de>
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> AFAIK that was the last architecture imposing limitations below 32 bits
> on atomic_t.
>
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
If the comment's getting removed, it should probably go from here too:
linux-2.6$ git grep '24' arch/*/include/*/atomic*
arch/mn10300/include/asm/atomic.h: * useful range of an atomic_t is only 24 bits
arch/mn10300/include/asm/atomic.h: * useful range of an atomic_t is only 24 bits
arch/mn10300/include/asm/atomic.h: * Note that the guaranteed useful range of an
arch/mn10300/include/asm/atomic.h: * Note that the guaranteed useful range of an
-- Jamie
next prev parent reply other threads:[~2010-04-28 15:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1272451837-17961-1-git-send-email-peter.fritzsche@gmx.de>
2010-04-28 11:10 ` [PATCH 2/2] asm-generic: Don't warn that atomic_t is only 24 bit Peter Fritzsche
2010-04-28 11:10 ` Peter Fritzsche
2010-04-28 13:33 ` Arnd Bergmann
2010-04-28 13:54 ` Mathieu Desnoyers
2010-04-28 13:54 ` Mathieu Desnoyers
2010-04-28 15:28 ` Jamie Lokier [this message]
2010-04-28 16:27 ` Mathieu Desnoyers
2010-04-28 18:42 ` Peter Fritzsche
2010-04-28 18:42 ` Peter Fritzsche
2010-04-29 16:22 ` David Howells
2010-04-29 21:10 ` Mathieu Desnoyers
2010-04-29 21:10 ` Mathieu Desnoyers
2010-04-30 8:53 ` Peter Fritzsche
2010-04-28 16:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100428152815.GB25569@shareable.org \
--to=jamie@shareable.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=peter.fritzsche@gmx.de \
--cc=schwidefsky@de.ibm.com \
--cc=wesolows@foobazco.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).