From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH 05/25] lmb: Prepare to include linux/lmb.h in core file Date: Tue, 22 Jun 2010 20:45:50 +0200 Message-ID: <20100622184550.GA25947@merkur.ravnborg.org> References: <1277227614-11581-1-git-send-email-yinghai@kernel.org> <1277227614-11581-6-git-send-email-yinghai@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1277227614-11581-6-git-send-email-yinghai@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Yinghai Lu Cc: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , David Miller , Benjamin Herrenschmidt , Linus Torvalds , Johannes Weiner , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Tue, Jun 22, 2010 at 10:26:34AM -0700, Yinghai Lu wrote: > Need to add protection in linux/lmb.h, to prepare to include it in > mm/page_alloc.c and mm/bootmem.c etc. > > Signed-off-by: Yinghai Lu > --- > include/linux/lmb.h | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/include/linux/lmb.h b/include/linux/lmb.h > index eb8a5a3..d529232 100644 > --- a/include/linux/lmb.h > +++ b/include/linux/lmb.h > @@ -2,6 +2,7 @@ > #define _LINUX_LMB_H > #ifdef __KERNEL__ > > +#ifdef CONFIG_HAVE_LMB The file could loose the "#ifdef __KERNEL__" as lmb.h is not exported to userspace. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pqueueb.post.tele.dk ([193.162.153.10]:55808 "EHLO pqueueb.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752341Ab0FVSqM (ORCPT ); Tue, 22 Jun 2010 14:46:12 -0400 Received: from pfepb.post.tele.dk (pfepb.post.tele.dk [195.41.46.236]) by pqueueb.post.tele.dk (Postfix) with ESMTP id B6AF78147 for ; Tue, 22 Jun 2010 20:46:11 +0200 (CEST) Date: Tue, 22 Jun 2010 20:45:50 +0200 From: Sam Ravnborg Subject: Re: [PATCH 05/25] lmb: Prepare to include linux/lmb.h in core file Message-ID: <20100622184550.GA25947@merkur.ravnborg.org> References: <1277227614-11581-1-git-send-email-yinghai@kernel.org> <1277227614-11581-6-git-send-email-yinghai@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1277227614-11581-6-git-send-email-yinghai@kernel.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Yinghai Lu Cc: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , David Miller , Benjamin Herrenschmidt , Linus Torvalds , Johannes Weiner , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Message-ID: <20100622184550.jNYuwS2_9WWVJteMdcaVuM95JPvL_oET-J7GOwrlnLY@z> On Tue, Jun 22, 2010 at 10:26:34AM -0700, Yinghai Lu wrote: > Need to add protection in linux/lmb.h, to prepare to include it in > mm/page_alloc.c and mm/bootmem.c etc. > > Signed-off-by: Yinghai Lu > --- > include/linux/lmb.h | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/include/linux/lmb.h b/include/linux/lmb.h > index eb8a5a3..d529232 100644 > --- a/include/linux/lmb.h > +++ b/include/linux/lmb.h > @@ -2,6 +2,7 @@ > #define _LINUX_LMB_H > #ifdef __KERNEL__ > > +#ifdef CONFIG_HAVE_LMB The file could loose the "#ifdef __KERNEL__" as lmb.h is not exported to userspace. Sam