From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King Subject: Re: [PATCH] Make do_execve() take a const filename pointer Date: Tue, 17 Aug 2010 16:25:27 +0100 Message-ID: <20100817152526.GC6681@flint.arm.linux.org.uk> References: <20100817140737.29854.22899.stgit@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:44645 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754319Ab0HQPZr (ORCPT ); Tue, 17 Aug 2010 11:25:47 -0400 Content-Disposition: inline In-Reply-To: <20100817140737.29854.22899.stgit@warthog.procyon.org.uk> Sender: linux-arch-owner@vger.kernel.org List-ID: To: David Howells Cc: ralf@linux-mips.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, Aug 17, 2010 at 03:07:37PM +0100, David Howells wrote: > Make do_execve() take a const filename pointer so that kernel_execve() compiles > correctly on ARM: > > arch/arm/kernel/sys_arm.c:88: warning: passing argument 1 of 'do_execve' discards qualifiers from pointer target type > > This also requires the argv and envp arguments to be consted twice, once for > the pointer array and once for the strings the array points to. This is > because do_execve() passes a pointer to the filename (now const) to > copy_strings_kernel(). A simpler alternative would be to cast the filename > pointer in do_execve() when it's passed to copy_strings_kernel(). > > do_execve() may not change any of the strings it is passed as part of the argv > or envp lists as they are some of them in .rodata, so marking these strings as > const should be fine. > > Further kernel_execve() and sys_execve() need to be changed to match. > > This has been test built on x86_64, frv, arm and mips. > > Signed-off-by: David Howells > Tested-by: Ralf Baechle David, Thanks for sorting this. Acked-by: Russell King -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: