* [PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS [not found] <201008181428.45029.arnd@arndb.de> @ 2010-08-19 2:28 ` Stephen Boyd 2010-08-19 2:28 ` Stephen Boyd ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: Stephen Boyd @ 2010-08-19 2:28 UTC (permalink / raw) To: linux-arch Cc: linux-kernel, Arnd Bergmann, x86, linux-arm-kernel, linux-s390, linux-parisc, Arjan van de Ven, Heiko Carstens, Helge Deller The help text for this config is duplicated across the x86, parisc, s390, and arm Kconfig.debug files. Arnd Bergman noted that the help text was slightly misleading and should be fixed to state that enabling this option isn't a problem when using pre 4.4 gcc. To simplify the rewording, consolidate the text into lib/Kconfig.debug and modify it there to be more explicit about when you should say N to this config. Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: x86@kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-s390@vger.kernel.org Cc: linux-parisc@vger.kernel.org Cc: Arjan van de Ven <arjan@linux.intel.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Cc: Helge Deller <deller@gmx.de> --- This depends on a patch sent to the arm mailing list adding CONFIG_DEBUG_STRICT_USER_COPY_CHECKS to ARM. LKML: http://lkml.org/lkml/2010/8/17/535 arch/arm/Kconfig.debug | 15 ++------------- arch/parisc/Kconfig.debug | 15 ++------------- arch/s390/Kconfig.debug | 14 ++------------ arch/x86/Kconfig.debug | 15 ++------------- lib/Kconfig.debug | 16 ++++++++++++++++ 5 files changed, 24 insertions(+), 51 deletions(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 64e33b8..326c7f1 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -128,18 +128,7 @@ config DEBUG_S3C_UART The uncompressor code port configuration is now handled by CONFIG_S3C_LOWLEVEL_UART_PORT. -config DEBUG_STRICT_USER_COPY_CHECKS - bool "Strict user copy size checks" - depends on DEBUG_KERNEL && !TRACE_BRANCH_PROFILING - help - Enabling this option turns a certain set of sanity checks for user - copy operations into compile time errors. - - The copy_from_user() etc checks are there to help test if there - are sufficient security checks on the length argument of - the copy operation, by having gcc prove that the argument is - within bounds. - - If unsure, or if you run an older (pre 4.4) gcc, say N. +config ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS + def_bool y endmenu diff --git a/arch/parisc/Kconfig.debug b/arch/parisc/Kconfig.debug index 7305ac8..b13e8d0 100644 --- a/arch/parisc/Kconfig.debug +++ b/arch/parisc/Kconfig.debug @@ -12,18 +12,7 @@ config DEBUG_RODATA portion of the kernel code won't be covered by a TLB anymore. If in doubt, say "N". -config DEBUG_STRICT_USER_COPY_CHECKS - bool "Strict copy size checks" - depends on DEBUG_KERNEL && !TRACE_BRANCH_PROFILING - ---help--- - Enabling this option turns a certain set of sanity checks for user - copy operations into compile time failures. - - The copy_from_user() etc checks are there to help test if there - are sufficient security checks on the length argument of - the copy operation, by having gcc prove that the argument is - within bounds. - - If unsure, or if you run an older (pre 4.4) gcc, say N. +config ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS + def_bool y endmenu diff --git a/arch/s390/Kconfig.debug b/arch/s390/Kconfig.debug index 45e0c61..6df8e30 100644 --- a/arch/s390/Kconfig.debug +++ b/arch/s390/Kconfig.debug @@ -6,17 +6,7 @@ config TRACE_IRQFLAGS_SUPPORT source "lib/Kconfig.debug" -config DEBUG_STRICT_USER_COPY_CHECKS - bool "Strict user copy size checks" - ---help--- - Enabling this option turns a certain set of sanity checks for user - copy operations into compile time warnings. - - The copy_from_user() etc checks are there to help test if there - are sufficient security checks on the length argument of - the copy operation, by having gcc prove that the argument is - within bounds. - - If unsure, or if you run an older (pre 4.4) gcc, say N. +config ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS + def_bool y endmenu diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug index 7508508..d24afa3 100644 --- a/arch/x86/Kconfig.debug +++ b/arch/x86/Kconfig.debug @@ -285,18 +285,7 @@ config OPTIMIZE_INLINING If unsure, say N. -config DEBUG_STRICT_USER_COPY_CHECKS - bool "Strict copy size checks" - depends on DEBUG_KERNEL && !TRACE_BRANCH_PROFILING - ---help--- - Enabling this option turns a certain set of sanity checks for user - copy operations into compile time failures. - - The copy_from_user() etc checks are there to help test if there - are sufficient security checks on the length argument of - the copy operation, by having gcc prove that the argument is - within bounds. - - If unsure, or if you run an older (pre 4.4) gcc, say N. +config ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS + def_bool y endmenu diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 9e06b7f..bbb1ac5 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1013,6 +1013,22 @@ config SYSCTL_SYSCALL_CHECK to properly maintain and use. This enables checks that help you to keep things correct. +config DEBUG_STRICT_USER_COPY_CHECKS + bool "Strict user copy size checks" + depends on ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS + depends on DEBUG_KERNEL && !TRACE_BRANCH_PROFILING + help + Enabling this option turns a certain set of sanity checks for user + copy operations into compile time warnings/errors. + + The copy_from_user() etc checks are there to help test if there + are sufficient security checks on the length argument of + the copy operation, by having gcc prove that the argument is + within bounds. + + If unsure, or if you run an older (pre 4.4) gcc where this option + is a no-op, say N. + source mm/Kconfig.debug source kernel/trace/Kconfig -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS 2010-08-19 2:28 ` [PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Stephen Boyd @ 2010-08-19 2:28 ` Stephen Boyd 2010-08-19 4:38 ` Arjan van de Ven 2010-08-19 4:47 ` Stephen Rothwell 2 siblings, 0 replies; 7+ messages in thread From: Stephen Boyd @ 2010-08-19 2:28 UTC (permalink / raw) To: linux-arch Cc: linux-kernel, Arnd Bergmann, x86, linux-arm-kernel, linux-s390, linux-parisc, Arjan van de Ven, Heiko Carstens, Helge Deller The help text for this config is duplicated across the x86, parisc, s390, and arm Kconfig.debug files. Arnd Bergman noted that the help text was slightly misleading and should be fixed to state that enabling this option isn't a problem when using pre 4.4 gcc. To simplify the rewording, consolidate the text into lib/Kconfig.debug and modify it there to be more explicit about when you should say N to this config. Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: x86@kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-s390@vger.kernel.org Cc: linux-parisc@vger.kernel.org Cc: Arjan van de Ven <arjan@linux.intel.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Cc: Helge Deller <deller@gmx.de> --- This depends on a patch sent to the arm mailing list adding CONFIG_DEBUG_STRICT_USER_COPY_CHECKS to ARM. LKML: http://lkml.org/lkml/2010/8/17/535 arch/arm/Kconfig.debug | 15 ++------------- arch/parisc/Kconfig.debug | 15 ++------------- arch/s390/Kconfig.debug | 14 ++------------ arch/x86/Kconfig.debug | 15 ++------------- lib/Kconfig.debug | 16 ++++++++++++++++ 5 files changed, 24 insertions(+), 51 deletions(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 64e33b8..326c7f1 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -128,18 +128,7 @@ config DEBUG_S3C_UART The uncompressor code port configuration is now handled by CONFIG_S3C_LOWLEVEL_UART_PORT. -config DEBUG_STRICT_USER_COPY_CHECKS - bool "Strict user copy size checks" - depends on DEBUG_KERNEL && !TRACE_BRANCH_PROFILING - help - Enabling this option turns a certain set of sanity checks for user - copy operations into compile time errors. - - The copy_from_user() etc checks are there to help test if there - are sufficient security checks on the length argument of - the copy operation, by having gcc prove that the argument is - within bounds. - - If unsure, or if you run an older (pre 4.4) gcc, say N. +config ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS + def_bool y endmenu diff --git a/arch/parisc/Kconfig.debug b/arch/parisc/Kconfig.debug index 7305ac8..b13e8d0 100644 --- a/arch/parisc/Kconfig.debug +++ b/arch/parisc/Kconfig.debug @@ -12,18 +12,7 @@ config DEBUG_RODATA portion of the kernel code won't be covered by a TLB anymore. If in doubt, say "N". -config DEBUG_STRICT_USER_COPY_CHECKS - bool "Strict copy size checks" - depends on DEBUG_KERNEL && !TRACE_BRANCH_PROFILING - ---help--- - Enabling this option turns a certain set of sanity checks for user - copy operations into compile time failures. - - The copy_from_user() etc checks are there to help test if there - are sufficient security checks on the length argument of - the copy operation, by having gcc prove that the argument is - within bounds. - - If unsure, or if you run an older (pre 4.4) gcc, say N. +config ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS + def_bool y endmenu diff --git a/arch/s390/Kconfig.debug b/arch/s390/Kconfig.debug index 45e0c61..6df8e30 100644 --- a/arch/s390/Kconfig.debug +++ b/arch/s390/Kconfig.debug @@ -6,17 +6,7 @@ config TRACE_IRQFLAGS_SUPPORT source "lib/Kconfig.debug" -config DEBUG_STRICT_USER_COPY_CHECKS - bool "Strict user copy size checks" - ---help--- - Enabling this option turns a certain set of sanity checks for user - copy operations into compile time warnings. - - The copy_from_user() etc checks are there to help test if there - are sufficient security checks on the length argument of - the copy operation, by having gcc prove that the argument is - within bounds. - - If unsure, or if you run an older (pre 4.4) gcc, say N. +config ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS + def_bool y endmenu diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug index 7508508..d24afa3 100644 --- a/arch/x86/Kconfig.debug +++ b/arch/x86/Kconfig.debug @@ -285,18 +285,7 @@ config OPTIMIZE_INLINING If unsure, say N. -config DEBUG_STRICT_USER_COPY_CHECKS - bool "Strict copy size checks" - depends on DEBUG_KERNEL && !TRACE_BRANCH_PROFILING - ---help--- - Enabling this option turns a certain set of sanity checks for user - copy operations into compile time failures. - - The copy_from_user() etc checks are there to help test if there - are sufficient security checks on the length argument of - the copy operation, by having gcc prove that the argument is - within bounds. - - If unsure, or if you run an older (pre 4.4) gcc, say N. +config ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS + def_bool y endmenu diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 9e06b7f..bbb1ac5 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1013,6 +1013,22 @@ config SYSCTL_SYSCALL_CHECK to properly maintain and use. This enables checks that help you to keep things correct. +config DEBUG_STRICT_USER_COPY_CHECKS + bool "Strict user copy size checks" + depends on ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS + depends on DEBUG_KERNEL && !TRACE_BRANCH_PROFILING + help + Enabling this option turns a certain set of sanity checks for user + copy operations into compile time warnings/errors. + + The copy_from_user() etc checks are there to help test if there + are sufficient security checks on the length argument of + the copy operation, by having gcc prove that the argument is + within bounds. + + If unsure, or if you run an older (pre 4.4) gcc where this option + is a no-op, say N. + source mm/Kconfig.debug source kernel/trace/Kconfig -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS 2010-08-19 2:28 ` [PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Stephen Boyd 2010-08-19 2:28 ` Stephen Boyd @ 2010-08-19 4:38 ` Arjan van de Ven 2010-08-19 4:38 ` Arjan van de Ven 2010-08-19 4:47 ` Stephen Rothwell 2 siblings, 1 reply; 7+ messages in thread From: Arjan van de Ven @ 2010-08-19 4:38 UTC (permalink / raw) To: Stephen Boyd Cc: linux-arch, linux-kernel, Arnd Bergmann, x86, linux-arm-kernel, linux-s390, linux-parisc, Heiko Carstens, Helge Deller On 8/18/2010 7:28 PM, Stephen Boyd wrote: > The help text for this config is duplicated across the x86, > parisc, s390, and arm Kconfig.debug files. Arnd Bergman noted > that the help text was slightly misleading and should be fixed to > state that enabling this option isn't a problem when using pre 4.4 > gcc. > > To simplify the rewording, consolidate the text into > lib/Kconfig.debug and modify it there to be more explicit about > when you should say N to this config. > Acked-by: Arjan van de Ven <arjan@linux.intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS 2010-08-19 4:38 ` Arjan van de Ven @ 2010-08-19 4:38 ` Arjan van de Ven 0 siblings, 0 replies; 7+ messages in thread From: Arjan van de Ven @ 2010-08-19 4:38 UTC (permalink / raw) To: Stephen Boyd Cc: linux-arch, linux-kernel, Arnd Bergmann, x86, linux-arm-kernel, linux-s390, linux-parisc, Heiko Carstens, Helge Deller On 8/18/2010 7:28 PM, Stephen Boyd wrote: > The help text for this config is duplicated across the x86, > parisc, s390, and arm Kconfig.debug files. Arnd Bergman noted > that the help text was slightly misleading and should be fixed to > state that enabling this option isn't a problem when using pre 4.4 > gcc. > > To simplify the rewording, consolidate the text into > lib/Kconfig.debug and modify it there to be more explicit about > when you should say N to this config. > Acked-by: Arjan van de Ven <arjan@linux.intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS 2010-08-19 2:28 ` [PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Stephen Boyd 2010-08-19 2:28 ` Stephen Boyd 2010-08-19 4:38 ` Arjan van de Ven @ 2010-08-19 4:47 ` Stephen Rothwell 2010-08-19 4:47 ` Stephen Rothwell 2010-08-19 11:04 ` Arnd Bergmann 2 siblings, 2 replies; 7+ messages in thread From: Stephen Rothwell @ 2010-08-19 4:47 UTC (permalink / raw) To: Stephen Boyd Cc: linux-arch, linux-kernel, Arnd Bergmann, x86, linux-arm-kernel, linux-s390, linux-parisc, Arjan van de Ven, Heiko Carstens, Helge Deller [-- Attachment #1: Type: text/plain, Size: 404 bytes --] On Wed, 18 Aug 2010 19:28:18 -0700 Stephen Boyd <sboyd@codeaurora.org> wrote: > > +config ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS > + def_bool y Why not just have config ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS bool in lib/Kconfig.debug and select that in each arch that want it? -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS 2010-08-19 4:47 ` Stephen Rothwell @ 2010-08-19 4:47 ` Stephen Rothwell 2010-08-19 11:04 ` Arnd Bergmann 1 sibling, 0 replies; 7+ messages in thread From: Stephen Rothwell @ 2010-08-19 4:47 UTC (permalink / raw) To: Stephen Boyd Cc: linux-arch, linux-kernel, Arnd Bergmann, x86, linux-arm-kernel, linux-s390, linux-parisc, Arjan van de Ven, Heiko Carstens, Helge Deller [-- Attachment #1: Type: text/plain, Size: 404 bytes --] On Wed, 18 Aug 2010 19:28:18 -0700 Stephen Boyd <sboyd@codeaurora.org> wrote: > > +config ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS > + def_bool y Why not just have config ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS bool in lib/Kconfig.debug and select that in each arch that want it? -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS 2010-08-19 4:47 ` Stephen Rothwell 2010-08-19 4:47 ` Stephen Rothwell @ 2010-08-19 11:04 ` Arnd Bergmann 1 sibling, 0 replies; 7+ messages in thread From: Arnd Bergmann @ 2010-08-19 11:04 UTC (permalink / raw) To: Stephen Rothwell Cc: Stephen Boyd, linux-arch, linux-kernel, x86, linux-arm-kernel, linux-s390, linux-parisc, Arjan van de Ven, Heiko Carstens, Helge Deller On Thursday 19 August 2010, Stephen Rothwell wrote: > On Wed, 18 Aug 2010 19:28:18 -0700 Stephen Boyd <sboyd@codeaurora.org> wrote: > > > > +config ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS > > + def_bool y > > Why not just have > > config ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS > bool > > in lib/Kconfig.debug > > and select that in each arch that want it? > Yes, that would be even easier, thanks for the suggestion! Arnd ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-08-19 11:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201008181428.45029.arnd@arndb.de>
2010-08-19 2:28 ` [PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Stephen Boyd
2010-08-19 2:28 ` Stephen Boyd
2010-08-19 4:38 ` Arjan van de Ven
2010-08-19 4:38 ` Arjan van de Ven
2010-08-19 4:47 ` Stephen Rothwell
2010-08-19 4:47 ` Stephen Rothwell
2010-08-19 11:04 ` Arnd Bergmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox