From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Subject: Re: [PATCH 4/7] ARM: oprofile: Move non-ARM code into separate init/exit Date: Wed, 6 Oct 2010 22:41:31 +0900 Message-ID: <20101006134130.GB29273@linux-sh.org> References: <74092b0d162aafc21e408033cec6146e227363b5.1286222593.git.matt@console-pimps.org> <20101006133309.GP13563@erda.amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from 124x34x33x190.ap124.ftth.ucom.ne.jp ([124.34.33.190]:52518 "EHLO master.linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932481Ab0JFNlf (ORCPT ); Wed, 6 Oct 2010 09:41:35 -0400 Content-Disposition: inline In-Reply-To: <20101006133309.GP13563@erda.amd.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Robert Richter Cc: Matt Fleming , Will Deacon , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-sh@vger.kernel.org" , Peter Zijlstra , Ingo Molnar , Frederic Weisbecker , Arnaldo Carvalho de Melo , "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Deng-Cheng Zhu , Grant Likely On Wed, Oct 06, 2010 at 03:33:09PM +0200, Robert Richter wrote: > On 04.10.10 16:44:22, Matt Fleming wrote: > > @@ -388,7 +387,14 @@ out: > > return ret; > > } > > > > -void __exit oprofile_arch_exit(void) > > +int __init oprofile_arch_init(struct oprofile_operations *ops) > > +{ > > We should do here a: > > memset(ops, 0, sizeof(*ops)); > > Otherwise it looks good. > What kind of crap interface is oprofile peddling, seriously? You expect every single architecture to clear this structure that gets passed in from the oprofile code without having any idea if there are defaults assigned or not, instead of just having the oprofile code clear it out before passing it along?