linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: Robert Richter <robert.richter@amd.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Matt Fleming <matt@console-pimps.org>,
	Will Deacon <will.deacon@arm.com>,
	Russell King <linux@arm.linux.org.uk>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Deng-Cheng Zhu <dengcheng.zhu@gmail.com>,
	Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH 2/7] perf: New helper function for pmu name
Date: Wed, 6 Oct 2010 23:13:47 +0900	[thread overview]
Message-ID: <20101006141347.GA32376@linux-sh.org> (raw)
In-Reply-To: <20101006133041.GA29273@linux-sh.org>

On Wed, Oct 06, 2010 at 10:30:41PM +0900, Paul Mundt wrote:
> On Wed, Oct 06, 2010 at 03:18:25PM +0200, Robert Richter wrote:
> > I am not against adding the pmu name to the perf API. But the oprofile
> > cpu_type strings are oprofile centric esp. for the userland. So these
> > strings will remain part of oprofile. Also I don't think we want to
> > polute the perf pmu names with it.
> > 
> And those architectures that have opted to use different strings for perf
> events are free to mangle them however they want for the oprofile case.
> It doesn't change the fact that strings are still being managed by all of
> the architectures. The perf PMU names aren't presently locked in to an
> ABI, whereas the oprofile strings are, so it seems fairly straightforward
> to develop standard mangling rules for preventing an oprofile-facing
> string, or to simply reuse the strings verbatim.
> 
So to add a bit of context here, I was just looking at the oprofile
tools. The naming format here is one of:

	<arch>/<pmu>

if there were a generic perf to oprofile pmu name mangler that did this
it would cover almost all of the ARM cases already, the SH strings I'm
happy to convert to work this way, and a good chunk of the PowerPC PMUs
would work fine, too. PowerPC already has an oprofile CPU string in its
CPU spec, so this would be even more trivial to wire up there if such a
generic interface were to exist.

This would just leave x86 as the odd one out, but I suppose if x86 were
to move to the oprofile perf wrapper in the future then a bit of id to
name mangling as an override wouldn't be too much work.

  reply	other threads:[~2010-10-06 14:13 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-04 20:44 [PATCH V4 0/7] Generalise ARM perf-events backend for oprofile Matt Fleming
2010-10-04 20:44 ` Matt Fleming
2010-10-04 20:44 ` [PATCH 1/7] perf: Add helper function to return number of counters Matt Fleming
2010-10-04 20:44   ` Matt Fleming
2010-10-05  8:15   ` Paul Mundt
2010-10-06 12:14   ` Robert Richter
2010-10-06 12:14     ` Robert Richter
2010-10-06 12:35     ` Robert Richter
2010-10-06 12:35       ` Robert Richter
2010-10-06 13:41     ` Peter Zijlstra
2010-10-04 20:44 ` [PATCH 2/7] perf: New helper function for pmu name Matt Fleming
2010-10-05  8:10   ` Paul Mundt
2010-10-05  8:10     ` Paul Mundt
2010-10-06 12:27   ` Robert Richter
2010-10-06 12:27     ` Robert Richter
2010-10-06 12:39     ` Paul Mundt
2010-10-06 12:39       ` Paul Mundt
2010-10-06 13:18       ` Robert Richter
2010-10-06 13:18         ` Robert Richter
2010-10-06 13:30         ` Paul Mundt
2010-10-06 14:13           ` Paul Mundt [this message]
2010-10-06 14:13             ` Paul Mundt
2010-10-06 15:37             ` Robert Richter
2010-10-06 15:37               ` Robert Richter
2010-10-06 15:46               ` Paul Mundt
2010-10-06 15:46                 ` Paul Mundt
2010-10-06 15:50           ` Robert Richter
2010-10-06 15:50             ` Robert Richter
2010-10-06 15:57             ` Paul Mundt
2010-10-06 18:15   ` Robert Richter
2010-10-06 18:15     ` Robert Richter
2010-10-06 18:38     ` Paul Mundt
2010-10-06 18:38       ` Paul Mundt
2010-10-04 20:44 ` [PATCH 3/7] ARM: oprofile: Rename op_arm to oprofile_perf Matt Fleming
2010-10-04 20:44   ` Matt Fleming
2010-10-06 12:41   ` Robert Richter
2010-10-06 12:41     ` Robert Richter
2010-10-04 20:44 ` [PATCH 4/7] ARM: oprofile: Move non-ARM code into separate init/exit Matt Fleming
2010-10-06 13:33   ` Robert Richter
2010-10-06 13:33     ` Robert Richter
2010-10-06 13:41     ` Paul Mundt
2010-10-06 14:49     ` Robert Richter
2010-10-06 14:49       ` Robert Richter
2010-10-06 14:53       ` Paul Mundt
2010-10-06 14:53         ` Paul Mundt
2010-10-06 14:59         ` Robert Richter
2010-10-06 14:59           ` Robert Richter
2010-10-06 15:00           ` Paul Mundt
2010-10-06 18:23           ` Grant Likely
2010-10-06 18:23             ` Grant Likely
2010-10-06 18:44             ` Robert Richter
2010-10-06 18:50               ` Paul Mundt
2010-10-06 18:50                 ` Paul Mundt
2010-10-06 18:58               ` Grant Likely
2010-10-06 18:58                 ` Grant Likely
2010-10-06 19:22                 ` Robert Richter
2010-10-04 20:44 ` [PATCH 5/7] oprofile: Abstract the perf-events backend Matt Fleming
2010-10-04 20:44   ` Matt Fleming
2010-10-06 18:34   ` Robert Richter
2010-10-04 20:44 ` [PATCH 6/7] sh: oprofile: Use perf-events oprofile backend Matt Fleming
2010-10-04 20:44   ` Matt Fleming
2010-10-05  8:08   ` Paul Mundt
2010-10-05  8:08     ` Paul Mundt
2010-10-06 18:35   ` Robert Richter
2010-10-06 19:45     ` Matt Fleming
2010-10-06 19:45       ` Matt Fleming
2010-10-06 21:03       ` Paul Mundt
2010-10-04 20:44 ` [PATCH 7/7] sh: Annotate oprofile_arch_exit() with __exit marker Matt Fleming
2010-10-05  8:16   ` Paul Mundt
2010-10-06 18:37   ` Robert Richter
2010-10-06 18:37     ` Robert Richter
  -- strict thread matches above, loose matches on Subject: below --
2010-10-09  0:46 [PATCH V5 0/7] Generalise ARM perf-events backend for oprofile Matt Fleming
2010-10-09  0:46 ` [PATCH 2/7] perf: New helper function for pmu name Matt Fleming
2010-10-09  0:46   ` Matt Fleming
2010-10-11  9:18   ` Robert Richter
2010-10-11  9:18     ` Robert Richter
2010-10-11  9:31     ` Peter Zijlstra
2010-10-11  9:31       ` Peter Zijlstra
2010-10-11 15:31   ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101006141347.GA32376@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=acme@redhat.com \
    --cc=dengcheng.zhu@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=matt@console-pimps.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=robert.richter@amd.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).