From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Richter Subject: Re: [PATCH 6/7] sh: oprofile: Use perf-events oprofile backend Date: Wed, 6 Oct 2010 20:35:49 +0200 Message-ID: <20101006183549.GW13563@erda.amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from va3ehsobe010.messaging.microsoft.com ([216.32.180.30]:27430 "EHLO VA3EHSOBE010.bigfish.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759761Ab0JFSvD (ORCPT ); Wed, 6 Oct 2010 14:51:03 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Matt Fleming Cc: Will Deacon , Paul Mundt , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-sh@vger.kernel.org" , Peter Zijlstra , Ingo Molnar , Frederic Weisbecker , Arnaldo Carvalho de Melo , "linux-arch@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Deng-Cheng Zhu , Grant Likely On 04.10.10 16:44:24, Matt Fleming wrote: > Now that we've got a generic perf-events based oprofile backend we might > as well make use of it seeing as SH doesn't do anything special with its > oprofile backend. Also introduce a new CONFIG_HW_PERF_EVENTS symbol so > that we can fallback to using the timer interrupt for oprofile if the > CPU doesn't support perf events. > > Signed-off-by: Matt Fleming > --- > arch/sh/Kconfig | 13 +++++ > arch/sh/oprofile/Makefile | 4 ++ > arch/sh/oprofile/common.c | 109 ++++--------------------------------------- > arch/sh/oprofile/op_impl.h | 33 ------------- > 4 files changed, 28 insertions(+), 131 deletions(-) > delete mode 100644 arch/sh/oprofile/op_impl.h This patch looks good. We might merge it with patch 7/7. -Robert -- Advanced Micro Devices, Inc. Operating System Research Center