From: Matt Fleming <matt@console-pimps.org>
To: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>,
Paul Mundt <lethal@linux-sh.org>,
Russell King <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Deng-Cheng Zhu <dengcheng.zhu@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH 6/7] sh: oprofile: Use perf-events oprofile backend
Date: Wed, 6 Oct 2010 20:45:07 +0100 [thread overview]
Message-ID: <20101006194507.GA30419@console-pimps.org> (raw)
In-Reply-To: <20101006183549.GW13563@erda.amd.com>
On Wed, Oct 06, 2010 at 08:35:49PM +0200, Robert Richter wrote:
> On 04.10.10 16:44:24, Matt Fleming wrote:
> > Now that we've got a generic perf-events based oprofile backend we might
> > as well make use of it seeing as SH doesn't do anything special with its
> > oprofile backend. Also introduce a new CONFIG_HW_PERF_EVENTS symbol so
> > that we can fallback to using the timer interrupt for oprofile if the
> > CPU doesn't support perf events.
> >
> > Signed-off-by: Matt Fleming <matt@console-pimps.org>
> > ---
> > arch/sh/Kconfig | 13 +++++
> > arch/sh/oprofile/Makefile | 4 ++
> > arch/sh/oprofile/common.c | 109 ++++---------------------------------------
> > arch/sh/oprofile/op_impl.h | 33 -------------
> > 4 files changed, 28 insertions(+), 131 deletions(-)
> > delete mode 100644 arch/sh/oprofile/op_impl.h
>
> This patch looks good.
>
> We might merge it with patch 7/7.
This patch was broken out for Paul's benefit to ease review. If he's
happy for me to merge this with 7/7 then that's fine with me.
next prev parent reply other threads:[~2010-10-06 19:45 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 20:44 [PATCH V4 0/7] Generalise ARM perf-events backend for oprofile Matt Fleming
2010-10-04 20:44 ` Matt Fleming
2010-10-04 20:44 ` [PATCH 1/7] perf: Add helper function to return number of counters Matt Fleming
2010-10-04 20:44 ` Matt Fleming
2010-10-05 8:15 ` Paul Mundt
2010-10-06 12:14 ` Robert Richter
2010-10-06 12:14 ` Robert Richter
2010-10-06 12:35 ` Robert Richter
2010-10-06 12:35 ` Robert Richter
2010-10-06 13:41 ` Peter Zijlstra
2010-10-04 20:44 ` [PATCH 2/7] perf: New helper function for pmu name Matt Fleming
2010-10-05 8:10 ` Paul Mundt
2010-10-05 8:10 ` Paul Mundt
2010-10-06 12:27 ` Robert Richter
2010-10-06 12:27 ` Robert Richter
2010-10-06 12:39 ` Paul Mundt
2010-10-06 12:39 ` Paul Mundt
2010-10-06 13:18 ` Robert Richter
2010-10-06 13:18 ` Robert Richter
2010-10-06 13:30 ` Paul Mundt
2010-10-06 14:13 ` Paul Mundt
2010-10-06 14:13 ` Paul Mundt
2010-10-06 15:37 ` Robert Richter
2010-10-06 15:37 ` Robert Richter
2010-10-06 15:46 ` Paul Mundt
2010-10-06 15:46 ` Paul Mundt
2010-10-06 15:50 ` Robert Richter
2010-10-06 15:50 ` Robert Richter
2010-10-06 15:57 ` Paul Mundt
2010-10-06 18:15 ` Robert Richter
2010-10-06 18:15 ` Robert Richter
2010-10-06 18:38 ` Paul Mundt
2010-10-06 18:38 ` Paul Mundt
2010-10-04 20:44 ` [PATCH 3/7] ARM: oprofile: Rename op_arm to oprofile_perf Matt Fleming
2010-10-04 20:44 ` Matt Fleming
2010-10-06 12:41 ` Robert Richter
2010-10-06 12:41 ` Robert Richter
2010-10-04 20:44 ` [PATCH 4/7] ARM: oprofile: Move non-ARM code into separate init/exit Matt Fleming
2010-10-06 13:33 ` Robert Richter
2010-10-06 13:33 ` Robert Richter
2010-10-06 13:41 ` Paul Mundt
2010-10-06 14:49 ` Robert Richter
2010-10-06 14:49 ` Robert Richter
2010-10-06 14:53 ` Paul Mundt
2010-10-06 14:53 ` Paul Mundt
2010-10-06 14:59 ` Robert Richter
2010-10-06 14:59 ` Robert Richter
2010-10-06 15:00 ` Paul Mundt
2010-10-06 18:23 ` Grant Likely
2010-10-06 18:23 ` Grant Likely
2010-10-06 18:44 ` Robert Richter
2010-10-06 18:50 ` Paul Mundt
2010-10-06 18:50 ` Paul Mundt
2010-10-06 18:58 ` Grant Likely
2010-10-06 18:58 ` Grant Likely
2010-10-06 19:22 ` Robert Richter
2010-10-04 20:44 ` [PATCH 5/7] oprofile: Abstract the perf-events backend Matt Fleming
2010-10-04 20:44 ` Matt Fleming
2010-10-06 18:34 ` Robert Richter
2010-10-04 20:44 ` [PATCH 6/7] sh: oprofile: Use perf-events oprofile backend Matt Fleming
2010-10-04 20:44 ` Matt Fleming
2010-10-05 8:08 ` Paul Mundt
2010-10-05 8:08 ` Paul Mundt
2010-10-06 18:35 ` Robert Richter
2010-10-06 19:45 ` Matt Fleming [this message]
2010-10-06 19:45 ` Matt Fleming
2010-10-06 21:03 ` Paul Mundt
2010-10-04 20:44 ` [PATCH 7/7] sh: Annotate oprofile_arch_exit() with __exit marker Matt Fleming
2010-10-05 8:16 ` Paul Mundt
2010-10-06 18:37 ` Robert Richter
2010-10-06 18:37 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006194507.GA30419@console-pimps.org \
--to=matt@console-pimps.org \
--cc=acme@redhat.com \
--cc=dengcheng.zhu@gmail.com \
--cc=fweisbec@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).