From: David Miller <davem@davemloft.net>
To: andy.grover@oracle.com
Cc: akinobu.mita@gmail.com, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, arnd@arndb.de,
akpm@linux-foundation.org, rds-devel@oss.oracle.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 4/5] rds: stop including asm-generic/bitops/le.h directly
Date: Fri, 08 Oct 2010 11:59:00 -0700 (PDT) [thread overview]
Message-ID: <20101008.115900.245387221.davem@davemloft.net> (raw)
In-Reply-To: <4CAF693B.9030706@oracle.com>
From: Andy Grover <andy.grover@oracle.com>
Date: Fri, 08 Oct 2010 11:55:55 -0700
> On 10/08/2010 03:03 AM, Akinobu Mita wrote:
>> asm-generic/bitops/le.h is only intended to be included directly from
>> asm-generic/bitops/ext2-non-atomic.h or asm-generic/bitops/minix-le.h
>> which implements generic ext2 or minix bit operations.
>>
>> This stops including asm-generic/bitops/le.h directly and use ext2
>> non-atomic bit operations instead.
>>
>> An alternative approach is introducing little endian bit operations
>> in linux/bitops.h. But it needs to touch more files than this change
>> does.
>
>> - generic___set_le_bit(off, (void *)map->m_page_addrs[i]);
>> + ext2_set_bit(off, (void *)map->m_page_addrs[i]);
>
> I'd like a solution that doesn't have rds calling a function starting
> with ext2_. Seems wrong.
Agreed.
next prev parent reply other threads:[~2010-10-08 18:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 10:03 [PATCH 1/5] bitops: add generic implementation of ext2 atomic bitops by test_and_{set,clear}_bit Akinobu Mita
2010-10-08 10:03 ` Akinobu Mita
2010-10-08 10:03 ` [PATCH 2/5] bitops: cleanup asm-generic/bitops/le.h Akinobu Mita
2010-10-08 10:03 ` Akinobu Mita
2010-10-08 10:03 ` [PATCH 3/5] kvm: stop including asm-generic/bitops/le.h directly Akinobu Mita
2010-10-08 10:03 ` Akinobu Mita
2010-10-08 12:45 ` Alexander Graf
2010-10-08 10:03 ` [PATCH 4/5] rds: " Akinobu Mita
2010-10-08 10:03 ` Akinobu Mita
2010-10-08 18:55 ` Andy Grover
2010-10-08 18:59 ` David Miller [this message]
2010-10-08 18:59 ` David Miller
2010-10-10 15:09 ` Akinobu Mita
2010-10-10 15:09 ` Akinobu Mita
2010-10-08 10:03 ` [PATCH 5/5] bitops: forbid asm-generic/bitops/le.h direct inclusion Akinobu Mita
2010-10-08 10:03 ` Akinobu Mita
2010-10-08 10:24 ` [PATCH 1/5] bitops: add generic implementation of ext2 atomic bitops by test_and_{set,clear}_bit Christoph Hellwig
2010-10-08 10:24 ` Christoph Hellwig
2010-10-10 15:07 ` Akinobu Mita
2010-10-10 16:36 ` Arnd Bergmann
2010-10-12 3:39 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101008.115900.245387221.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andy.grover@oracle.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).