From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 4/5] rds: stop including asm-generic/bitops/le.h directly Date: Fri, 08 Oct 2010 11:59:00 -0700 (PDT) Message-ID: <20101008.115900.245387221.davem@davemloft.net> References: <1286532193-29814-1-git-send-email-akinobu.mita@gmail.com> <1286532193-29814-4-git-send-email-akinobu.mita@gmail.com> <4CAF693B.9030706@oracle.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4CAF693B.9030706@oracle.com> Sender: linux-kernel-owner@vger.kernel.org To: andy.grover@oracle.com Cc: akinobu.mita@gmail.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, arnd@arndb.de, akpm@linux-foundation.org, rds-devel@oss.oracle.com, netdev@vger.kernel.org List-Id: linux-arch.vger.kernel.org From: Andy Grover Date: Fri, 08 Oct 2010 11:55:55 -0700 > On 10/08/2010 03:03 AM, Akinobu Mita wrote: >> asm-generic/bitops/le.h is only intended to be included directly from >> asm-generic/bitops/ext2-non-atomic.h or asm-generic/bitops/minix-le.h >> which implements generic ext2 or minix bit operations. >> >> This stops including asm-generic/bitops/le.h directly and use ext2 >> non-atomic bit operations instead. >> >> An alternative approach is introducing little endian bit operations >> in linux/bitops.h. But it needs to touch more files than this change >> does. > >> - generic___set_le_bit(off, (void *)map->m_page_addrs[i]); >> + ext2_set_bit(off, (void *)map->m_page_addrs[i]); > > I'd like a solution that doesn't have rds calling a function starting > with ext2_. Seems wrong. Agreed. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:58392 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757384Ab0JHS6j (ORCPT ); Fri, 8 Oct 2010 14:58:39 -0400 Date: Fri, 08 Oct 2010 11:59:00 -0700 (PDT) Message-ID: <20101008.115900.245387221.davem@davemloft.net> Subject: Re: [PATCH 4/5] rds: stop including asm-generic/bitops/le.h directly From: David Miller In-Reply-To: <4CAF693B.9030706@oracle.com> References: <1286532193-29814-1-git-send-email-akinobu.mita@gmail.com> <1286532193-29814-4-git-send-email-akinobu.mita@gmail.com> <4CAF693B.9030706@oracle.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: andy.grover@oracle.com Cc: akinobu.mita@gmail.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, arnd@arndb.de, akpm@linux-foundation.org, rds-devel@oss.oracle.com, netdev@vger.kernel.org Message-ID: <20101008185900.7P7bXvGQW9UbE8ZOeUWNPd_wEtDUUphEx4EeqvBFVVU@z> From: Andy Grover Date: Fri, 08 Oct 2010 11:55:55 -0700 > On 10/08/2010 03:03 AM, Akinobu Mita wrote: >> asm-generic/bitops/le.h is only intended to be included directly from >> asm-generic/bitops/ext2-non-atomic.h or asm-generic/bitops/minix-le.h >> which implements generic ext2 or minix bit operations. >> >> This stops including asm-generic/bitops/le.h directly and use ext2 >> non-atomic bit operations instead. >> >> An alternative approach is introducing little endian bit operations >> in linux/bitops.h. But it needs to touch more files than this change >> does. > >> - generic___set_le_bit(off, (void *)map->m_page_addrs[i]); >> + ext2_set_bit(off, (void *)map->m_page_addrs[i]); > > I'd like a solution that doesn't have rds calling a function starting > with ext2_. Seems wrong. Agreed.