From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [patch 33/47] pci: Cleanup the irq_desc mess in msi Date: Mon, 11 Oct 2010 10:08:49 -0700 Message-ID: <20101011100849.072b9ba6@jbarnes-desktop> References: <20100930221351.682772535@linutronix.de> <20100930221741.720879189@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100930221741.720879189@linutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner Cc: LKML , linux-arch@vger.kernel.org, Linus Torvalds , Andrew Morton , x86@kernel.org, Peter Zijlstra , Benjamin Herrenschmidt , Paul Mundt , Russell King , David Woodhouse , Yinghai Lu , Grant Likely , "Eric W. Biederman" List-Id: linux-arch.vger.kernel.org On Thu, 30 Sep 2010 23:17:18 -0000 Thomas Gleixner wrote: > Handing down irq_desc to msi just so that msi can access > irq_desc.irq_data.msi_desc is a pretty stupid idea. The calling code > can hand down a pointer to msi_desc so msi code does not need to know > about the irq descriptor at all. > > Signed-off-by: Thomas Gleixner > --- Looks like a good cleanup. Acked-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cpoproxy3-pub.bluehost.com ([67.222.54.6]:44053 "HELO cpoproxy3-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755634Ab0JKRFh (ORCPT ); Mon, 11 Oct 2010 13:05:37 -0400 Date: Mon, 11 Oct 2010 10:08:49 -0700 From: Jesse Barnes Subject: Re: [patch 33/47] pci: Cleanup the irq_desc mess in msi Message-ID: <20101011100849.072b9ba6@jbarnes-desktop> In-Reply-To: <20100930221741.720879189@linutronix.de> References: <20100930221351.682772535@linutronix.de> <20100930221741.720879189@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thomas Gleixner Cc: LKML , linux-arch@vger.kernel.org, Linus Torvalds , Andrew Morton , x86@kernel.org, Peter Zijlstra , Benjamin Herrenschmidt , Paul Mundt , Russell King , David Woodhouse , Yinghai Lu , Grant Likely , "Eric W. Biederman" Message-ID: <20101011170849.RCUQVqfH0JrSajwLfSlgVkYh_D0yqJB_c3SDdFUCNoA@z> On Thu, 30 Sep 2010 23:17:18 -0000 Thomas Gleixner wrote: > Handing down irq_desc to msi just so that msi can access > irq_desc.irq_data.msi_desc is a pretty stupid idea. The calling code > can hand down a pointer to msi_desc so msi code does not need to know > about the irq descriptor at all. > > Signed-off-by: Thomas Gleixner > --- Looks like a good cleanup. Acked-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center