From: Matthew Wilcox <matthew@wil.cx>
To: Borislav Petkov <bp@amd64.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
Doug Thompson <dougthompson@xmission.com>,
akpm <akpm@linux-foundation.org>,
linux-arch@vger.kernel.org
Subject: Re: [PATCH] bitops.h: Widen BIT macro to support 64-bit types
Date: Thu, 14 Oct 2010 05:12:13 -0600 [thread overview]
Message-ID: <20101014111213.GO10421@parisc-linux.org> (raw)
In-Reply-To: <20101014105855.GB31247@aftab>
On Thu, Oct 14, 2010 at 12:58:55PM +0200, Borislav Petkov wrote:
> #ifdef __KERNEL__
> -#define BIT(nr) (1UL << (nr))
> +#define BIT(nr) (U64_C(1) << (nr))
Why not just use 1ULL instead?
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2010-10-14 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101013131057.88238be6.randy.dunlap@oracle.com>
[not found] ` <20101014042409.GB29342@aftab>
2010-10-14 10:58 ` [PATCH] bitops.h: Widen BIT macro to support 64-bit types Borislav Petkov
2010-10-14 11:12 ` Matthew Wilcox [this message]
2010-10-14 12:12 ` Borislav Petkov
2010-10-14 14:27 ` Matthew Wilcox
2010-10-14 15:03 ` Linus Torvalds
2010-10-14 15:36 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101014111213.GO10421@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@linux-foundation.org \
--cc=bp@amd64.org \
--cc=dougthompson@xmission.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).