From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 04/22] arm: introduce little endian bitops Date: Mon, 18 Oct 2010 10:26:50 +0100 Message-ID: <20101018092650.GC26183@n2100.arm.linux.org.uk> References: <1287135981-17604-1-git-send-email-akinobu.mita@gmail.com> <1287135981-17604-5-git-send-email-akinobu.mita@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1287135981-17604-5-git-send-email-akinobu.mita@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Arnd Bergmann , Christoph Hellwig , Andrew Morton , linux-arm-kernel@lists.infradead.org List-Id: linux-arch.vger.kernel.org On Fri, Oct 15, 2010 at 06:46:03PM +0900, Akinobu Mita wrote: > Introduce little endian bit operations by renaming native ext2 bit > operations. The ext2 bit operations are kept by using little endian > bit operations until the conversions are finished. Can you explain why we need another level of indirection rather than using asm-generic/bitops/le.h, asm-generic/bitops/minix.h and asm-generic/bitops/ext2-non-atomic.h ? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:33288 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754701Ab0JRJ1F (ORCPT ); Mon, 18 Oct 2010 05:27:05 -0400 Date: Mon, 18 Oct 2010 10:26:50 +0100 From: Russell King - ARM Linux Subject: Re: [PATCH 04/22] arm: introduce little endian bitops Message-ID: <20101018092650.GC26183@n2100.arm.linux.org.uk> References: <1287135981-17604-1-git-send-email-akinobu.mita@gmail.com> <1287135981-17604-5-git-send-email-akinobu.mita@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1287135981-17604-5-git-send-email-akinobu.mita@gmail.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Arnd Bergmann , Christoph Hellwig , Andrew Morton , linux-arm-kernel@lists.infradead.org Message-ID: <20101018092650.SNqurHrPBaJ2MmmDAG6N8RxG2eu5AG0t5AvCtDOOjSI@z> On Fri, Oct 15, 2010 at 06:46:03PM +0900, Akinobu Mita wrote: > Introduce little endian bit operations by renaming native ext2 bit > operations. The ext2 bit operations are kept by using little endian > bit operations until the conversions are finished. Can you explain why we need another level of indirection rather than using asm-generic/bitops/le.h, asm-generic/bitops/minix.h and asm-generic/bitops/ext2-non-atomic.h ?