From: Andrew Morton <akpm@linux-foundation.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
sam@ravnborg.org, eric.dumazet@gmail.com,
linux-arch@vger.kernel.org
Subject: Re: [patch 3/3]use new macros for x86 percpu readmostly section
Date: Thu, 9 Dec 2010 14:32:01 -0800 [thread overview]
Message-ID: <20101209143201.6ab0a49d.akpm@linux-foundation.org> (raw)
In-Reply-To: <1291255350.12777.117.camel@sli10-conroe>
On Thu, 02 Dec 2010 10:02:30 +0800
Shaohua Li <shaohua.li@intel.com> wrote:
> Use the new macros to correctly align percpu readmostly data.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
> ---
> arch/x86/kernel/vmlinux.lds.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux/arch/x86/kernel/vmlinux.lds.S
> ===================================================================
> --- linux.orig/arch/x86/kernel/vmlinux.lds.S 2010-12-02 09:48:44.000000000 +0800
> +++ linux/arch/x86/kernel/vmlinux.lds.S 2010-12-02 09:54:24.000000000 +0800
> @@ -226,7 +226,7 @@ SECTIONS
> * output PHDR, so the next output section - .init.text - should
> * start another segment - init.
> */
> - PERCPU_VADDR(0, :percpu)
> + PERCPU_VADDR_CACHEALIGNED(0, :percpu, INTERNODE_CACHE_BYTES)
> #endif
>
> INIT_TEXT_SECTION(PAGE_SIZE)
> @@ -301,7 +301,7 @@ SECTIONS
> }
>
> #if !defined(CONFIG_X86_64) || !defined(CONFIG_SMP)
> - PERCPU(THREAD_SIZE)
> + PERCPU_CACHEALIGNED(THREAD_SIZE, INTERNODE_CACHE_BYTES)
> #endif
>
> . = ALIGN(PAGE_SIZE);
>
So what is the situation now with all other architectures? Should they
be changed to correctly align their read-mostly percpu areas?
If so, what should the arch maintainers do to achieve this?
next parent reply other threads:[~2010-12-09 22:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1291255350.12777.117.camel@sli10-conroe>
2010-12-09 22:32 ` Andrew Morton [this message]
2010-12-10 0:21 ` [patch 3/3]use new macros for x86 percpu readmostly section Shaohua Li
2010-12-10 0:21 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101209143201.6ab0a49d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox