From: Christoph Paasch <christoph.paasch@uclouvain.be>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: netdev@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH/RFC] Re: Compilation of pktgen fails for ARCH=um
Date: Fri, 31 Dec 2010 11:26:29 +0100 [thread overview]
Message-ID: <201012311126.30027.christoph.paasch@uclouvain.be> (raw)
In-Reply-To: <20101230093925.3d6b567e.randy.dunlap@oracle.com>
Hi,
On Thursday, December 30, 2010 wrote Randy Dunlap:
> or ndelay() in arch/um/include/asm/delay.y can be removed completely
> and then the default implementation of ndelay() will be used from
> include/linux/delay.h.
> This builds cleanly, but I don't know how well it would work.
This will do a rounded up micro-second sleep. I think that it's ok.
Christoph
> ---
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Allow uml to use the default implementation of ndelay() from
> <linux/delay.h>. Fixes build error:
>
> net/built-in.o: In function `spin':
> pktgen.c:(.text+0x27391): undefined reference to `__unimplemented_ndelay'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> arch/um/include/asm/delay.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> --- linux-next-20101214.orig/arch/um/include/asm/delay.h
> +++ linux-next-20101214/arch/um/include/asm/delay.h
> @@ -12,9 +12,4 @@ extern void __delay(unsigned long loops)
> #define udelay(n) ((__builtin_constant_p(n) && (n) > 20000) ? \
> __bad_udelay() : __udelay(n))
>
> -/* It appears that ndelay is not used at all for UML, and has never been
> - * implemented. */
> -extern void __unimplemented_ndelay(void);
> -#define ndelay(n) __unimplemented_ndelay()
> -
> #endif
--
Christoph Paasch
PhD Student
IP Networking Lab --- http://inl.info.ucl.ac.be
MultiPath TCP in the Linux Kernel --- http://inl.info.ucl.ac.be/mptcp
Université Catholique de Louvain
www.rollerbulls.be
--
prev parent reply other threads:[~2010-12-31 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 10:33 Compilation of pktgen fails for ARCH=um Christoph Paasch
2010-12-30 17:39 ` [PATCH/RFC] " Randy Dunlap
2010-12-31 10:26 ` Christoph Paasch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012311126.30027.christoph.paasch@uclouvain.be \
--to=christoph.paasch@uclouvain.be \
--cc=linux-arch@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox