From: Arnd Bergmann <arnd@arndb.de>
To: Guan Xuetao <guanxuetao@mprc.pku.edu.cn>,
Al Viro <viro@ftp.linux.org.uk>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv1 11/12] unicore32 core architecture: signals
Date: Fri, 7 Jan 2011 01:16:57 +0100 [thread overview]
Message-ID: <201101070116.57654.arnd@arndb.de> (raw)
In-Reply-To: <00da01cba465$6d6e52f0$484af8d0$@mprc.pku.edu.cn>
On Saturday 25 December 2010, Guan Xuetao wrote:
> From: Guan Xuetao <guanxuetao@mprc.pku.edu.cn>
>
> Patch 11 implements signals.
>
> Signed-off-by: Guan Xuetao <guanxuetao@mprc.pku.edu.cn>
> ---
> arch/unicore32/include/asm/sigcontext.h | 61 ++++
> arch/unicore32/kernel/signal.c | 571 +++++++++++++++++++++++++++++++
> arch/unicore32/kernel/signal.h | 16 +
> 3 files changed, 648 insertions(+), 0 deletions(-)
Al Viro recently did a major cleanup of the signal handling code in a
number of architectures. He can probably give much better feedback
on this one than I can.
The one thing that sticks out to me is that you implement both legacy
and rt signals, where new architectures should generally only need the
rt variant.
Arnd
next prev parent reply other threads:[~2011-01-07 0:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-25 18:56 [PATCHv1 11/12] unicore32 core architecture: signals Guan Xuetao
2011-01-07 0:16 ` Arnd Bergmann [this message]
2011-01-07 0:16 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101070116.57654.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=guanxuetao@mprc.pku.edu.cn \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).