From: Sam Ravnborg <sam@ravnborg.org>
To: Guan Xuetao <guanxuetao@mprc.pku.edu.cn>
Cc: 'Arnd Bergmann' <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv1 01/12] unicore32 core architecture: build infrastructure
Date: Sat, 8 Jan 2011 15:07:40 +0100 [thread overview]
Message-ID: <20110108140740.GB3928@merkur.ravnborg.org> (raw)
In-Reply-To: <023801cbaf15$8c569690$a503c3b0$@mprc.pku.edu.cn>
> >
> > Overall, I can see that there has been a lot of good progress in the code since
> > the original versions that I looked at, very nice!
> >
> > > diff --git a/arch/unicore32/.gitignore b/arch/unicore32/.gitignore
> > > new file mode 100644
> > > index 0000000..f0fc866
> > > --- /dev/null
> > > +++ b/arch/unicore32/.gitignore
> > > @@ -0,0 +1,70 @@
> > > +#
> > > +# Generated include files
> > > +#
> > > +include/asm/atomic.h
> > > +include/asm/auxvec.h
> > > +include/asm/bitsperlong.h
> > > +include/asm/bug.h
> > > +include/asm/bugs.h
> > > +include/asm/cputime.h
> > > +include/asm/current.h
> > > +include/asm/device.h
> > > +include/asm/emergency-restart.h
> > > +include/asm/errno.h
> > > +include/asm/fb.h
> > > +include/asm/fcntl.h
> > > +include/asm/hardirq.h
> > > ...
> >
> > Maybe it would be better to put these files into a separate directory, like
> > arch/unicore32/include/generated/asm, to make it easier to separate them
> > from the other files and avoid listing them all in .gitignore besides the
> > other places.
>
> That's great, and I make the following changes:
...
I have made a second attempt to provice generic support
for asm-generic headers as you likely have seen.
IMO you shall keep your own solution until we get
generic support.
In other words - you shall avoid being dependent on this.
Sam
prev parent reply other threads:[~2011-01-08 14:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-25 18:41 [PATCHv1 01/12] unicore32 core architecture: build infrastructure Guan Xuetao
2011-01-06 7:55 ` Paul Mundt
2011-01-08 5:47 ` Guan Xuetao
2011-01-08 7:20 ` Sam Ravnborg
2011-01-08 11:09 ` Guan Xuetao
2011-01-08 11:09 ` Guan Xuetao
2011-01-08 11:48 ` Sam Ravnborg
2011-01-08 11:48 ` Sam Ravnborg
2011-01-10 12:12 ` Guan Xuetao
2011-01-10 12:34 ` Sam Ravnborg
2011-01-07 0:18 ` Arnd Bergmann
2011-01-07 0:18 ` Arnd Bergmann
2011-01-08 9:22 ` Guan Xuetao
2011-01-08 14:07 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110108140740.GB3928@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=arnd@arndb.de \
--cc=guanxuetao@mprc.pku.edu.cn \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).