Re: [PATCH 1/2] kbuild: asm-generic support

[Sam Ravnborg <sam@ravnborg.org>]

On Sun, Jan 09, 2011 at 03:03:33PM +0100, Arnd Bergmann wrote:
> Hi Sam,
> 
> Looks much cleaner to me now, but I still don't see why we even need
> the new generic-export-y variable in addition to export-y. Can't we
> just simply install all $(filter-out, $(generated-y), $(header-y))
> from arch/$(SRCARCH)/include/asm and all $(filter, $(generated-y),
> $(header-y)) from rch/$(SRCARCH)/include/generated/asm?

Like this:

diff --git a/scripts/Makefile.headersinst b/scripts/Makefile.headersinst
index 3a630c2..7c06dcf 100644
--- a/scripts/Makefile.headersinst
+++ b/scripts/Makefile.headersinst
@@ -31,10 +31,10 @@ check-file    := $(install)/.check
 # generic-export-y list all generic headers to be exported
 # generic-y list all files an architecture uses from asm-generic
 # Use this to build a list of headers which require a wrapper
-wrapper-files := $(filter $(generic-export-y), $(generic-y))
+wrapper-files := $(filter $(header-y), $(generic-y))
 
 # all headers files for this dir
-header-y      := $(filter-out $(wrapper-files), $(header-y))
+header-y      := $(filter-out $(generic-y), $(header-y))
 all-files     := $(header-y) $(objhdr-y) $(generic-y)
 input-files   := $(addprefix $(_src)/,$(header-y)) \
                  $(addprefix $(objtree)/$(obj)/,$(objhdr-y))


And then reverting the changes to Kbuild.asm.
Yes this works - and is much simpler. Good!

I originally wanted to know wat set of files I worked
with but this is not needed.

I will test it a bit more tonight and post a v3 of the patchset.

Thanks for the review!

	Sam