From: Sam Ravnborg <sam@ravnborg.org> To: lkml <linux-kernel@vger.kernel.org>, linux-kbuild <linux-kbuild@vger.kernel.org>, linux arch <linux-arch@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>, Guan Xuetao <guanxuetao@mprc> Subject: [RFC v3] kbuild: generic support for asm-generic Date: Sun, 9 Jan 2011 20:27:07 +0100 [thread overview] Message-ID: <20110109192707.GA12387@merkur.ravnborg.org> (raw) In-Reply-To: <20110108130302.GA21698@merkur.ravnborg.org> Hi Michal, Arnd et all. This is my second attempt to provide generic support for architectures that use existing headers from asm-generic. @Michal - I consider this ready for you to review / apply. I would prefer if this patch could be included in the current merge window - allowing us to convert archs until next merge window. As this touches the top-level Makefile in an area that is always used I suggest to at least let i cook in -next for a few days first. It was inspired by unicore32 - but I have requested Guang _not_ to convert unicore32 to avoid a dependency on this patch. The patch description: There is an increasing amount of header files shared between individual architectures in asm-generic. To avoid a lot of dummy wrapper files that just include the corresponding file in asm-generic provide some basic support in kbuild for this. With the following patch an architecture can maintain a list of files in the file arch/$(ARCH)/include/asm/Kbuild To use a generic file just add: generic-y += <name-of-header-file.h> For each file listed kbuild will generate the necessary wrapper in arch/$(ARCH)/include/generated/asm. When installing userspace headers a wrapper is likewise created. The original inspiration for this came from the unicore32 patchset - although is used a different method. Changes since v2: - Fix spelling miss in LINUXINCLUDE (Stephen) - Properly delete file with mrproper (Guang) - Fixed support for headers that are not exported (Guang) - New way to list files used from the generic set (Arnd) Changes since v3: - Dropped generic-export.y (from Arnd) - added check if header is listed as generic but still is present - fixed "make headers_check" - updated documentation I did not include an Reviewed-by / Acked-by from Arnd as he had not seen the latest iteration in the full. Diffstat for the patch: .gitignore | 1 + Documentation/kbuild/makefiles.txt | 36 ++++++++++++++++++++++++++++++++++++ Makefile | 15 +++++++++++---- scripts/Makefile.headersinst | 18 +++++++++++++++--- scripts/asm-generic.sh | 33 +++++++++++++++++++++++++++++++++ 5 files changed, 96 insertions(+), 7 deletions(-) create mode 100644 scripts/asm-generic.sh Sample diffstat when using generic-y for three files in x86: arch/x86/include/asm/Kbuild | 6 ++++++ arch/x86/include/asm/rtc.h | 1 - arch/x86/include/asm/termbits.h | 1 - arch/x86/include/asm/termios.h | 1 - 4 files changed, 6 insertions(+), 3 deletions(-) delete mode 100644 arch/x86/include/asm/rtc.h delete mode 100644 arch/x86/include/asm/termbits.h delete mode 100644 arch/x86/include/asm/termios.h Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org> To: lkml <linux-kernel@vger.kernel.org>, linux-kbuild <linux-kbuild@vger.kernel.org>, linux arch <linux-arch@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>, Guan Xuetao <guanxuetao@mprc.pku.edu.cn>, Michal Marek <mmarek@suse.cz> Subject: [RFC v3] kbuild: generic support for asm-generic Date: Sun, 9 Jan 2011 20:27:07 +0100 [thread overview] Message-ID: <20110109192707.GA12387@merkur.ravnborg.org> (raw) Message-ID: <20110109192707.TOFt1Sq-dgui-AL0ONJG3wlmRphafKeURnyqOfyw9Z8@z> (raw) In-Reply-To: <20110108130302.GA21698@merkur.ravnborg.org> Hi Michal, Arnd et all. This is my second attempt to provide generic support for architectures that use existing headers from asm-generic. @Michal - I consider this ready for you to review / apply. I would prefer if this patch could be included in the current merge window - allowing us to convert archs until next merge window. As this touches the top-level Makefile in an area that is always used I suggest to at least let i cook in -next for a few days first. It was inspired by unicore32 - but I have requested Guang _not_ to convert unicore32 to avoid a dependency on this patch. The patch description: There is an increasing amount of header files shared between individual architectures in asm-generic. To avoid a lot of dummy wrapper files that just include the corresponding file in asm-generic provide some basic support in kbuild for this. With the following patch an architecture can maintain a list of files in the file arch/$(ARCH)/include/asm/Kbuild To use a generic file just add: generic-y += <name-of-header-file.h> For each file listed kbuild will generate the necessary wrapper in arch/$(ARCH)/include/generated/asm. When installing userspace headers a wrapper is likewise created. The original inspiration for this came from the unicore32 patchset - although is used a different method. Changes since v2: - Fix spelling miss in LINUXINCLUDE (Stephen) - Properly delete file with mrproper (Guang) - Fixed support for headers that are not exported (Guang) - New way to list files used from the generic set (Arnd) Changes since v3: - Dropped generic-export.y (from Arnd) - added check if header is listed as generic but still is present - fixed "make headers_check" - updated documentation I did not include an Reviewed-by / Acked-by from Arnd as he had not seen the latest iteration in the full. Diffstat for the patch: .gitignore | 1 + Documentation/kbuild/makefiles.txt | 36 ++++++++++++++++++++++++++++++++++++ Makefile | 15 +++++++++++---- scripts/Makefile.headersinst | 18 +++++++++++++++--- scripts/asm-generic.sh | 33 +++++++++++++++++++++++++++++++++ 5 files changed, 96 insertions(+), 7 deletions(-) create mode 100644 scripts/asm-generic.sh Sample diffstat when using generic-y for three files in x86: arch/x86/include/asm/Kbuild | 6 ++++++ arch/x86/include/asm/rtc.h | 1 - arch/x86/include/asm/termbits.h | 1 - arch/x86/include/asm/termios.h | 1 - 4 files changed, 6 insertions(+), 3 deletions(-) delete mode 100644 arch/x86/include/asm/rtc.h delete mode 100644 arch/x86/include/asm/termbits.h delete mode 100644 arch/x86/include/asm/termios.h Sam
next prev parent reply other threads:[~2011-01-09 19:27 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-01-08 13:03 [RFC] kbuild: generic support for asm-generic Sam Ravnborg 2011-01-08 13:03 ` Sam Ravnborg 2011-01-08 13:04 ` [PATCH 1/2] kbuild: asm-generic support Sam Ravnborg 2011-01-08 13:04 ` Sam Ravnborg 2011-01-08 13:45 ` Stephen Rothwell 2011-01-08 14:03 ` Sam Ravnborg 2011-01-08 14:03 ` Sam Ravnborg 2011-01-08 14:10 ` Guan Xuetao 2011-01-08 14:10 ` Guan Xuetao 2011-01-08 13:05 ` [EXAMPLE PATCH 2/2] x86: start to utilize kbuild " Sam Ravnborg 2011-01-08 13:05 ` Sam Ravnborg 2011-01-08 20:53 ` [RFC] kbuild: generic support for asm-generic Arnd Bergmann 2011-01-08 21:33 ` Sam Ravnborg 2011-01-08 21:33 ` Sam Ravnborg 2011-01-09 0:15 ` Arnd Bergmann 2011-01-09 8:28 ` [RFC v2] " Sam Ravnborg 2011-01-09 8:28 ` Sam Ravnborg 2011-01-09 8:31 ` [PATCH 1/2] kbuild: asm-generic support Sam Ravnborg 2011-01-09 8:31 ` Sam Ravnborg 2011-01-09 14:03 ` Arnd Bergmann 2011-01-09 15:10 ` Sam Ravnborg 2011-01-09 16:13 ` Arnd Bergmann 2011-01-09 16:13 ` Arnd Bergmann 2011-01-09 8:32 ` [EXAMPLE PATCH 2/2] x86: start to utilize kbuild " Sam Ravnborg 2011-01-09 8:32 ` Sam Ravnborg 2011-01-09 19:27 ` Sam Ravnborg [this message] 2011-01-09 19:27 ` [RFC v3] kbuild: generic support for asm-generic Sam Ravnborg 2011-01-09 19:29 ` [PATCH 1/2] kbuild: asm-generic support Sam Ravnborg 2011-01-09 19:29 ` Sam Ravnborg 2011-01-09 20:31 ` Arnd Bergmann 2011-01-09 20:31 ` Arnd Bergmann 2011-01-09 21:24 ` Sam Ravnborg 2011-01-09 21:24 ` Sam Ravnborg 2011-01-10 13:14 ` Guan Xuetao 2011-01-10 13:14 ` Guan Xuetao 2011-01-10 16:26 ` Sam Ravnborg 2011-01-10 16:26 ` Sam Ravnborg 2011-01-11 1:39 ` Guan Xuetao 2011-01-10 13:31 ` Guan Xuetao 2011-01-10 13:31 ` Guan Xuetao 2011-01-13 16:14 ` Michal Marek 2011-01-13 17:01 ` Sam Ravnborg 2011-01-13 17:01 ` Sam Ravnborg 2011-01-14 14:43 ` Michal Marek 2011-04-22 15:53 ` [PATCH v3] " Sam Ravnborg 2011-04-22 15:53 ` Sam Ravnborg 2011-04-25 1:29 ` Guan Xuetao 2011-04-27 19:42 ` Sam Ravnborg 2011-04-27 19:42 ` Sam Ravnborg 2011-04-27 19:46 ` [PATCH v4] " Sam Ravnborg 2011-04-27 19:46 ` Sam Ravnborg 2011-04-27 19:52 ` Arnd Bergmann 2011-04-27 19:52 ` Arnd Bergmann 2011-04-27 20:29 ` [PATCH v5] " Sam Ravnborg 2011-04-27 20:29 ` Sam Ravnborg 2011-04-28 16:16 ` Michal Marek 2011-01-09 19:29 ` [EXAMPLE PATCH 2/2] x86: start to utilize kbuild " Sam Ravnborg 2011-01-09 19:29 ` Sam Ravnborg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110109192707.GA12387@merkur.ravnborg.org \ --to=sam@ravnborg.org \ --cc=arnd@arndb.de \ --cc=guanxuetao@mprc \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).