From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-arch@vger.kernel.org,
linux1394-devel@lists.sourceforge.net,
Clemens Ladisch <clemens@ladisch.de>
Subject: Re: PAGE_KERNEL_RO
Date: Thu, 13 Jan 2011 07:34:58 +0100 [thread overview]
Message-ID: <20110113073458.2179590a@stein> (raw)
In-Reply-To: <1294877484.9586.66.camel@pasglop>
On Jan 13 Benjamin Herrenschmidt wrote at linux-arch:
> On Wed, 2011-01-12 at 16:07 -0800, Andrew Morton wrote:
> > drivers/firewire/ohci.c now needs PAGE_KERNEL_RO, but many
> > architectures don't implement it. Broke my sparc64 build.
>
> Some architectures actually cannot implement it even... at least some
> variants of powerpc MMUs don't have a combination of protection bits
> that allow a kernel-only RO mapping (yeah odd).
The simplest perceivable fix, to disable firewire-ohci on architectures
which don't have PAGE_KERNEL_RO, would be bad since there are actually
sparc64 machines with these controllers.
As far as I can tell, the new RO mapping in firewire-ohci can as well be
an r/w mapping. We just never need to write at these virtual addresses.
So, should we just change the driver to map it r/w when we can't have
PAGE_KERNEL_RO, or for simplicity on all architectures?
--
Stefan Richter
-=====-==-== ---= -==-=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2011-01-13 6:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 0:07 PAGE_KERNEL_RO Andrew Morton
2011-01-13 0:11 ` PAGE_KERNEL_RO Benjamin Herrenschmidt
2011-01-13 6:34 ` Stefan Richter [this message]
[not found] ` <522C1DF17AF50042AD8AE87F7887BD3D01E1655529@exch.hq.tensilica.com>
2011-01-13 7:27 ` PAGE_KERNEL_RO Clemens Ladisch
2011-01-13 9:04 ` PAGE_KERNEL_RO James Bottomley
2011-01-13 9:12 ` PAGE_KERNEL_RO Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113073458.2179590a@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=clemens@ladisch.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).