From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH 1/2] kbuild: asm-generic support Date: Thu, 13 Jan 2011 18:01:31 +0100 Message-ID: <20110113170131.GA28377@merkur.ravnborg.org> References: <20110108130302.GA21698@merkur.ravnborg.org> <20110109192707.GA12387@merkur.ravnborg.org> <20110109192907.GA12403@merkur.ravnborg.org> <4D2F24CD.5040101@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4D2F24CD.5040101@suse.cz> Sender: linux-kbuild-owner@vger.kernel.org To: Michal Marek Cc: lkml , linux-kbuild , linux arch , Arnd Bergmann , Guan Xuetao List-Id: linux-arch.vger.kernel.org On Thu, Jan 13, 2011 at 05:14:05PM +0100, Michal Marek wrote: > On 9.1.2011 20:29, Sam Ravnborg wrote: > > diff --git a/scripts/asm-generic.sh b/scripts/asm-generic.sh > > new file mode 100644 > > index 0000000..d28127f > > --- /dev/null > > +++ b/scripts/asm-generic.sh > > @@ -0,0 +1,33 @@ > > +#!/bin/sh > > +# > > +# include/asm-generic contains a lot of files that are used > > +# verbatim by several architectures. > > +# > > +# This scripts read the file arch/$(ARCH)/include/asm/Kbuild > > +# and for each file listed in this file with generic-y create > > +# a small wrapper file in arch/$(ARCH)/include/generated/ > > + > > +# read list of header files form Kbuild > > +# The file has make syntax which looks like this: > > +# > > +# generic-y += > > + > > +srcdir=${srctree}/arch/$1/include/asm > > +gendir=arch/$1/include/generated/asm > > + > > +# Read the list of files (note that the list uses make syntax) > > +files=$( cat ${srcdir}/Kbuild | \ > > + grep -v ^# | grep generic-y | cut -d '=' -f 2) > > Now that the list of required generic headers is in a Kbuild file, it > would be better to let make parse it, instead of enforcing one way to > construct the list (it is the preferred way, but C files that do not > conform to Documentation/CodingStyle are not rejected by the compiler > either). I will post a patch when I'm back online in the evening. Would be great! Guan also pointed out a less than minor issue... I overwrite the files each time so that I force a rebuild. If you do not find time then I will update the patch during the weekend. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pfepa.post.tele.dk ([195.41.46.235]:55688 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756717Ab1AMRBd (ORCPT ); Thu, 13 Jan 2011 12:01:33 -0500 Date: Thu, 13 Jan 2011 18:01:31 +0100 From: Sam Ravnborg Subject: Re: [PATCH 1/2] kbuild: asm-generic support Message-ID: <20110113170131.GA28377@merkur.ravnborg.org> References: <20110108130302.GA21698@merkur.ravnborg.org> <20110109192707.GA12387@merkur.ravnborg.org> <20110109192907.GA12403@merkur.ravnborg.org> <4D2F24CD.5040101@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D2F24CD.5040101@suse.cz> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Michal Marek Cc: lkml , linux-kbuild , linux arch , Arnd Bergmann , Guan Xuetao Message-ID: <20110113170131.9_nr-FbGdCLr18dS1RkxzOWjqduge4jtbi42sVoftAg@z> On Thu, Jan 13, 2011 at 05:14:05PM +0100, Michal Marek wrote: > On 9.1.2011 20:29, Sam Ravnborg wrote: > > diff --git a/scripts/asm-generic.sh b/scripts/asm-generic.sh > > new file mode 100644 > > index 0000000..d28127f > > --- /dev/null > > +++ b/scripts/asm-generic.sh > > @@ -0,0 +1,33 @@ > > +#!/bin/sh > > +# > > +# include/asm-generic contains a lot of files that are used > > +# verbatim by several architectures. > > +# > > +# This scripts read the file arch/$(ARCH)/include/asm/Kbuild > > +# and for each file listed in this file with generic-y create > > +# a small wrapper file in arch/$(ARCH)/include/generated/ > > + > > +# read list of header files form Kbuild > > +# The file has make syntax which looks like this: > > +# > > +# generic-y += > > + > > +srcdir=${srctree}/arch/$1/include/asm > > +gendir=arch/$1/include/generated/asm > > + > > +# Read the list of files (note that the list uses make syntax) > > +files=$( cat ${srcdir}/Kbuild | \ > > + grep -v ^# | grep generic-y | cut -d '=' -f 2) > > Now that the list of required generic headers is in a Kbuild file, it > would be better to let make parse it, instead of enforcing one way to > construct the list (it is the preferred way, but C files that do not > conform to Documentation/CodingStyle are not rejected by the compiler > either). I will post a patch when I'm back online in the evening. Would be great! Guan also pointed out a less than minor issue... I overwrite the files each time so that I force a rebuild. If you do not find time then I will update the patch during the weekend. Sam