From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [patch 36/37] tile: Use generic irq Kconfig Date: Thu, 20 Jan 2011 20:08:18 +0100 Message-ID: <20110120190818.GA22638@merkur.ravnborg.org> References: <20110119205258.462759212@linutronix.de> <20110119210840.631350392@linutronix.de> <4D3884E3.8050009@tilera.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from pqueuea.post.tele.dk ([193.162.153.9]:58663 "EHLO pqueuea.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704Ab1ATTIm (ORCPT ); Thu, 20 Jan 2011 14:08:42 -0500 Content-Disposition: inline In-Reply-To: <4D3884E3.8050009@tilera.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Chris Metcalf Cc: Thomas Gleixner , LKML , Linux-Arch , Andrew Morton , Ingo Molnar On Thu, Jan 20, 2011 at 01:54:27PM -0500, Chris Metcalf wrote: > On 1/19/2011 4:50 PM, Thomas Gleixner wrote: > > No functional change. > > > > Signed-off-by: Thomas Gleixner > > Cc: Chris Metcalf > > --- > > arch/tile/Kconfig | 16 ++++++---------- > > 1 file changed, 6 insertions(+), 10 deletions(-) > > > > Index: linux-2.6/arch/tile/Kconfig > > =================================================================== > > --- linux-2.6.orig/arch/tile/Kconfig > > +++ linux-2.6/arch/tile/Kconfig > > @@ -1,22 +1,18 @@ > > # For a description of the syntax of this configuration file, > > # see Documentation/kbuild/config-language.txt. > > > > +config TILE > > + def_bool y > > + select HAVE_GENERIC_HARDIRQS > > + select GENERIC_IRQ_PROBE > > + select GENERIC_PENDING_IRQ if SMP > > + > > [...] > > I'm not sure it's legal to have two "config TILE" blocks in this Kconfig > file; there's already one further down. It is OK to have two "config TILE" blocks. You should take care of moving the other one up after this goes in. Sam