From: Rusty Russell <rusty@rustcorp.com.au>
To: Dmitry Torokhov <dtor@vmware.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linux/m68k <linux-m68k@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH v2] module: deal with alignment issues in built-in module parameters
Date: Mon, 14 Feb 2011 09:34:17 +1030 [thread overview]
Message-ID: <201102140934.17671.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20110211220356.GA13504@dtor-ws.eng.vmware.com>
On Sat, 12 Feb 2011 08:33:56 am Dmitry Torokhov wrote:
> >From 03f1332fc02af7af0d06ab409e3ec72107637845 Mon Sep 17 00:00:00 2001
> From: Dmitry Torokhov <dtor@vmware.com>
> Date: Mon, 7 Feb 2011 13:47:20 -0800
> Subject: [PATCH] module: deal with alignment issues in built-in module parameters
>
> As DaveM said, we can't reliably put structures into independent
> objects, put them into a special section, and then expect array
> access over them (via the section boundaries) after linking the
> objects together to just "work" due to variable alignment choices
> in different situations. The only solution that seems to work
> reliably is to make an array of plain pointers to the objects in
> question and put those pointers in the special section.
I've applied this, but won't put it to linux-next. I'll let it stew for
a bit longer unless someone actually reports a problem with the current
code.
Thanks,
Rusty.
next prev parent reply other threads:[~2011-02-13 23:04 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 0:02 [PATCH 1/3] module: deal with alignment issues in built-in module versions Dmitry Torokhov
2011-02-08 0:02 ` [PATCH 2/3] module: deal with alignment issues in built-in module parameters Dmitry Torokhov
2011-02-08 0:02 ` [PATCH 3/3] module: do not hide __modver_version_show declaration behind ifdef Dmitry Torokhov
2011-02-08 21:12 ` [PATCH 1/3] module: deal with alignment issues in built-in module versions Geert Uytterhoeven
2011-02-08 21:12 ` Geert Uytterhoeven
2011-02-17 12:43 ` Geert Uytterhoeven
2011-02-17 12:43 ` Geert Uytterhoeven
2011-02-11 22:03 ` [PATCH v2] module: deal with alignment issues in built-in module parameters Dmitry Torokhov
2011-02-13 23:04 ` Rusty Russell [this message]
2011-02-13 23:04 ` Rusty Russell
2011-02-17 17:24 ` [PATCH 1/3] module: deal with alignment issues in built-in module versions Linus Torvalds
2011-02-17 17:24 ` Linus Torvalds
2011-02-17 17:31 ` Dmitry Torokhov
2011-02-17 17:31 ` Dmitry Torokhov
2011-02-17 17:45 ` Linus Torvalds
2011-02-17 17:45 ` Linus Torvalds
2011-02-17 18:00 ` Dmitry Torokhov
2011-02-17 18:06 ` Linus Torvalds
2011-02-17 18:06 ` Linus Torvalds
2011-02-17 21:01 ` David Miller
2011-02-17 21:01 ` David Miller
2011-02-17 21:11 ` Linus Torvalds
2011-02-17 21:17 ` David Miller
2011-02-17 21:54 ` Linus Torvalds
2011-02-17 22:01 ` David Miller
2011-02-17 22:19 ` Dmitry Torokhov
2011-02-17 22:23 ` David Miller
2011-02-17 22:23 ` David Miller
2011-02-17 22:48 ` Linus Torvalds
2011-02-17 22:48 ` Linus Torvalds
2011-02-17 23:08 ` Linus Torvalds
2011-02-17 23:19 ` David Miller
2011-02-19 0:14 ` Benjamin Herrenschmidt
2011-02-21 4:00 ` Rusty Russell
2011-02-21 4:00 ` Rusty Russell
2011-02-21 7:38 ` Geert Uytterhoeven
2011-02-21 7:49 ` Dmitry Torokhov
2011-02-21 7:49 ` Dmitry Torokhov
2011-02-21 13:25 ` Geert Uytterhoeven
2011-02-21 13:25 ` Geert Uytterhoeven
2011-02-22 1:58 ` Benjamin Herrenschmidt
2011-02-22 1:58 ` Benjamin Herrenschmidt
2011-02-22 2:03 ` Linus Torvalds
2011-02-22 2:03 ` Linus Torvalds
2011-02-22 7:02 ` Dmitry Torokhov
2011-02-22 17:08 ` Jesper Nilsson
2011-02-22 20:47 ` Linus Torvalds
2011-02-22 20:47 ` Linus Torvalds
2011-02-23 15:00 ` Jesper Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102140934.17671.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=davem@davemloft.net \
--cc=dtor@vmware.com \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).