public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Guan Xuetao <gxt@mprc.pku.edu.cn>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	'Greg KH' <greg@kroah.com>
Subject: Re: [PATCHv2 06/11] unicore32 core architecture: mm related: generic codes
Date: Thu, 17 Feb 2011 18:28:15 +0100	[thread overview]
Message-ID: <201102171828.15482.arnd@arndb.de> (raw)
In-Reply-To: <02ed01cbcb48$3e3781a0$baa684e0$@mprc.pku.edu.cn>

On Sunday 13 February 2011, Guan Xuetao wrote:
> This patch includes generic codes for memory management.
> 
> Signed-off-by: Guan Xuetao <gxt@mprc.pku.edu.cn>

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

> +#ifdef __io
> +void __iomem *ioport_map(unsigned long port, unsigned int nr)
> +{
> +       /* we map PC lagcy 64K IO port to PCI IO space 0x80030000 */
> +       return (void __iomem *) (unsigned long)
> +                       io_p2v((port & 0xffff) + PKUNITY_PCILIO_BASE);
> +}

Interestingly, this function looks completely correct, but I don't see
the definition for __io, so I suspect that the function is not actually
getting used.

Best make this unconditional. The code is obviously derived from the
ARM version, which uses a macro called __io, but you don't need this
macro because you only support one SoC platform.

	Arnd

  reply	other threads:[~2011-02-17 17:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-13  6:35 [PATCHv2 06/11] unicore32 core architecture: mm related: generic codes Guan Xuetao
2011-02-17 17:28 ` Arnd Bergmann [this message]
2011-02-22 14:16   ` Guan Xuetao
2011-02-22 15:18     ` Arnd Bergmann
2011-02-22 15:18       ` Arnd Bergmann
2011-02-27  4:46       ` Guan Xuetao
2011-02-27 17:12         ` Arnd Bergmann
2011-02-27 17:12           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201102171828.15482.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=greg@kroah.com \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox