From: Arnd Bergmann <arnd@arndb.de>
To: Guan Xuetao <gxt@mprc.pku.edu.cn>
Cc: dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, 'Greg KH' <greg@kroah.com>
Subject: Re: [PATCH 11/12] unicore32 machine related files: ps2 driver
Date: Fri, 18 Feb 2011 11:33:26 +0100 [thread overview]
Message-ID: <201102181133.26675.arnd@arndb.de> (raw)
In-Reply-To: <00eb01cbcf56$9f372700$dda57500$@mprc.pku.edu.cn>
On Friday 18 February 2011 11:28:45 Guan Xuetao wrote:
> * Register numbers.
> */
> -#define I8042_COMMAND_REG ((unsigned long)&PS2_COMMAND)
> -#define I8042_STATUS_REG ((unsigned long)&PS2_STATUS)
> -#define I8042_DATA_REG ((unsigned long)&PS2_DATA)
> +#define I8042_COMMAND_REG ((volatile void __iomem *)&PS2_COMMAND)
> +#define I8042_STATUS_REG ((volatile void __iomem *)&PS2_STATUS)
> +#define I8042_DATA_REG ((volatile void __iomem *)&PS2_DATA)
> +
> +#define I8042_REGION_START (resource_size_t)(&PS2_DATA)
> +#define I8042_REGION_SIZE (resource_size_t)(16)
It would be better to remove the cast and make the PS2_COMMAND
etc macros have the correct type. Aside from this, the change
looks good.
Arnd
next prev parent reply other threads:[~2011-02-18 10:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 7:52 [PATCH 11/12] unicore32 machine related files: ps2 driver Guan Xuetao
2011-02-17 17:03 ` Arnd Bergmann
2011-02-18 10:28 ` Guan Xuetao
2011-02-18 10:33 ` Arnd Bergmann [this message]
2011-02-22 14:26 ` Guan Xuetao
2011-02-22 17:11 ` Arnd Bergmann
2011-02-26 12:36 ` Guan Xuetao
2011-02-26 12:36 ` Guan Xuetao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102181133.26675.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=greg@kroah.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox