MACH_TYPE undeclared error

MACH_TYPE undeclared error

[Madhavi Manchala]

Dear All,

I have defined a MACHINE_START macro in my board C file as follows.

MACHINE_START(S3C2510, "S3C2510")
	.init_irq	= s3c2510_init_irq,
	.timer		= &s3c2510_time_init,
MACHINE_END

When I try to compile this C file, I am seeing the following error message.

arch/arm/mach-s3c2510/s3c2510.c:35:1: error: 'MACH_TYPE_S3C2510'
undeclared here (not in a function)

I googled, but there is no luck for me. Please suggest me whether I am
missing any configuration item.

Any hints / suggestions would be appreciated.

Thanks and Regards,
Madhavi M.

Re: MACH_TYPE undeclared error

[Baruch Siach]

Hi Medhavi,

On Tue, Mar 29, 2011 at 12:01:40PM +0530, Madhavi Manchala wrote:
> arch/arm/mach-s3c2510/s3c2510.c:35:1: error: 'MACH_TYPE_S3C2510'
> undeclared here (not in a function)

See 6f82f4db80189281a8ac42f2e72396accb719b57 (ARM: Update (and cut down) 
mach-types), and the recent discussion in this list 
(http://thread.gmane.org/gmane.linux.ports.arm.kernel/110967).

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Re: MACH_TYPE undeclared error

[Baruch Siach]

Hi Medhavi,

On Tue, Mar 29, 2011 at 12:01:40PM +0530, Madhavi Manchala wrote:
> arch/arm/mach-s3c2510/s3c2510.c:35:1: error: 'MACH_TYPE_S3C2510'
> undeclared here (not in a function)

See 6f82f4db80189281a8ac42f2e72396accb719b57 (ARM: Update (and cut down) 
mach-types), and the recent discussion in this list 
(http://thread.gmane.org/gmane.linux.ports.arm.kernel/110967).

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Re: MACH_TYPE undeclared error

[Uwe Kleine-König]

On Tue, Mar 29, 2011 at 12:01:40PM +0530, Madhavi Manchala wrote:
> Dear All,
> 
> I have defined a MACHINE_START macro in my board C file as follows.
> 
> MACHINE_START(S3C2510, "S3C2510")
> 	.init_irq	= s3c2510_init_irq,
> 	.timer		= &s3c2510_time_init,
> MACHINE_END
> 
> When I try to compile this C file, I am seeing the following error message.
> 
> arch/arm/mach-s3c2510/s3c2510.c:35:1: error: 'MACH_TYPE_S3C2510'
> undeclared here (not in a function)
you need a line defining S3C2510 in arch/arm/tools/mach-types.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: MACH_TYPE undeclared error

[Madhavi Manchala]

Dear Uwe,

2011/3/29 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> On Tue, Mar 29, 2011 at 12:01:40PM +0530, Madhavi Manchala wrote:
>> Dear All,
>>
>> I have defined a MACHINE_START macro in my board C file as follows.
>>
>> MACHINE_START(S3C2510, "S3C2510")
>>       .init_irq       = s3c2510_init_irq,
>>       .timer          = &s3c2510_time_init,
>> MACHINE_END
>>
>> When I try to compile this C file, I am seeing the following error message.
>>
>> arch/arm/mach-s3c2510/s3c2510.c:35:1: error: 'MACH_TYPE_S3C2510'
>> undeclared here (not in a function)
> you need a line defining S3C2510 in arch/arm/tools/mach-types.

Yeah. It is there in the arch/arm/tools/mach-types file. I did not add
to it, but it is automatically generated. The few lines from the
arch/arm/tools/mach-types file are as follows.

izarus		MACH_IZARUS		IZARUS		573
pxa_rts		MACH_RTS		RTS			574
se5100		MACH_SE5100		SE5100		575
s3c2510		MACH_S3C2510	S3C2510		576
csb437tl		MACH_CSB437TL	CSB437TL		577
slauson		MACH_SLAUSON	SLAUSON		578
pearlriver		MACH_PEARLRIVER	PEARLRIVER	579
tdc_p210		MACH_TDC_P210	TDC_P210	580

The machine S3C2510 is there in that file.

Thanks and Regards,
Madhavi M.

> Best regards
> Uwe
>
> --
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
>

Re: MACH_TYPE undeclared error

[Uwe Kleine-König]

Hello,

On Tue, Mar 29, 2011 at 02:01:10PM +0530, Madhavi Manchala wrote:
> 2011/3/29 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> > On Tue, Mar 29, 2011 at 12:01:40PM +0530, Madhavi Manchala wrote:
> >> I have defined a MACHINE_START macro in my board C file as follows.
> >>
> >> MACHINE_START(S3C2510, "S3C2510")
> >>       .init_irq       = s3c2510_init_irq,
> >>       .timer          = &s3c2510_time_init,
> >> MACHINE_END
> >>
> >> When I try to compile this C file, I am seeing the following error message.
> >>
> >> arch/arm/mach-s3c2510/s3c2510.c:35:1: error: 'MACH_TYPE_S3C2510'
> >> undeclared here (not in a function)
> > you need a line defining S3C2510 in arch/arm/tools/mach-types.
> 
> Yeah. It is there in the arch/arm/tools/mach-types file. I did not add
> to it, but it is automatically generated. The few lines from the
> arch/arm/tools/mach-types file are as follows.
> 
> izarus		MACH_IZARUS		IZARUS		573
> pxa_rts		MACH_RTS		RTS			574
> se5100		MACH_SE5100		SE5100		575
> s3c2510		MACH_S3C2510	S3C2510		576
> csb437tl		MACH_CSB437TL	CSB437TL		577
> slauson		MACH_SLAUSON	SLAUSON		578
> pearlriver		MACH_PEARLRIVER	PEARLRIVER	579
> tdc_p210		MACH_TDC_P210	TDC_P210	580
> 
> The machine S3C2510 is there in that file.
Do you have

	#include <asm/mach-types.h>

in your machine file?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: MACH_TYPE undeclared error

[Madhavi Manchala]

Dear Uwe,

2011/3/29 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> Hello,
>
> On Tue, Mar 29, 2011 at 02:01:10PM +0530, Madhavi Manchala wrote:
>> 2011/3/29 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
>> > On Tue, Mar 29, 2011 at 12:01:40PM +0530, Madhavi Manchala wrote:
>> >> I have defined a MACHINE_START macro in my board C file as follows.
>> >>
>> >> MACHINE_START(S3C2510, "S3C2510")
>> >>       .init_irq       = s3c2510_init_irq,
>> >>       .timer          = &s3c2510_time_init,
>> >> MACHINE_END
>> >>
>> >> When I try to compile this C file, I am seeing the following error message.
>> >>
>> >> arch/arm/mach-s3c2510/s3c2510.c:35:1: error: 'MACH_TYPE_S3C2510'
>> >> undeclared here (not in a function)
>> > you need a line defining S3C2510 in arch/arm/tools/mach-types.
>>
>> Yeah. It is there in the arch/arm/tools/mach-types file. I did not add
>> to it, but it is automatically generated. The few lines from the
>> arch/arm/tools/mach-types file are as follows.
>>
>> izarus                MACH_IZARUS             IZARUS          573
>> pxa_rts               MACH_RTS                RTS                     574
>> se5100                MACH_SE5100             SE5100          575
>> s3c2510               MACH_S3C2510    S3C2510         576
>> csb437tl              MACH_CSB437TL   CSB437TL                577
>> slauson               MACH_SLAUSON    SLAUSON         578
>> pearlriver            MACH_PEARLRIVER PEARLRIVER      579
>> tdc_p210              MACH_TDC_P210   TDC_P210        580
>>
>> The machine S3C2510 is there in that file.
> Do you have
>
>        #include <asm/mach-types.h>
>
> in your machine file?

It is not included in my machine file, previously. Now I included it
in my machine file and I am able to compile the file without any
issues.

Thanks for your valuable information.

Thanks and Regards,
Madhavi M.

> Best regards
> Uwe
>
> --
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
>

Re: MACH_TYPE undeclared error

[Russell King - ARM Linux]

On Tue, Mar 29, 2011 at 02:01:10PM +0530, Madhavi Manchala wrote:
> Dear Uwe,
> 
> 2011/3/29 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> > On Tue, Mar 29, 2011 at 12:01:40PM +0530, Madhavi Manchala wrote:
> >> Dear All,
> >>
> >> I have defined a MACHINE_START macro in my board C file as follows.
> >>
> >> MACHINE_START(S3C2510, "S3C2510")
> >>       .init_irq       = s3c2510_init_irq,
> >>       .timer          = &s3c2510_time_init,
> >> MACHINE_END
> >>
> >> When I try to compile this C file, I am seeing the following error message.
> >>
> >> arch/arm/mach-s3c2510/s3c2510.c:35:1: error: 'MACH_TYPE_S3C2510'
> >> undeclared here (not in a function)
> > you need a line defining S3C2510 in arch/arm/tools/mach-types.
> 
> Yeah. It is there in the arch/arm/tools/mach-types file. I did not add
> to it, but it is automatically generated. The few lines from the
> arch/arm/tools/mach-types file are as follows.
> 
> izarus		MACH_IZARUS		IZARUS		573
> pxa_rts		MACH_RTS		RTS			574
> se5100		MACH_SE5100		SE5100		575
> s3c2510		MACH_S3C2510	S3C2510		576
> csb437tl		MACH_CSB437TL	CSB437TL		577
> slauson		MACH_SLAUSON	SLAUSON		578
> pearlriver		MACH_PEARLRIVER	PEARLRIVER	579
> tdc_p210		MACH_TDC_P210	TDC_P210	580
> 
> The machine S3C2510 is there in that file.

S3C2510 sounds to me like a SoC name not a board name.  I delete anything
which sounds like a SoC name as that's not the purpose of the database.
It's for platforms and boards, not SoCs.

Re: MACH_TYPE undeclared error

[Madhavi Manchala]

Dear Russell,

On Tue, Mar 29, 2011 at 2:57 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Tue, Mar 29, 2011 at 02:01:10PM +0530, Madhavi Manchala wrote:
>> Dear Uwe,
>>
>> 2011/3/29 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
>> > On Tue, Mar 29, 2011 at 12:01:40PM +0530, Madhavi Manchala wrote:
>> >> Dear All,
>> >>
>> >> I have defined a MACHINE_START macro in my board C file as follows.
>> >>
>> >> MACHINE_START(S3C2510, "S3C2510")
>> >>       .init_irq       = s3c2510_init_irq,
>> >>       .timer          = &s3c2510_time_init,
>> >> MACHINE_END
>> >>
>> >> When I try to compile this C file, I am seeing the following error message.
>> >>
>> >> arch/arm/mach-s3c2510/s3c2510.c:35:1: error: 'MACH_TYPE_S3C2510'
>> >> undeclared here (not in a function)
>> > you need a line defining S3C2510 in arch/arm/tools/mach-types.
>>
>> Yeah. It is there in the arch/arm/tools/mach-types file. I did not add
>> to it, but it is automatically generated. The few lines from the
>> arch/arm/tools/mach-types file are as follows.
>>
>> izarus                MACH_IZARUS             IZARUS          573
>> pxa_rts               MACH_RTS                RTS                     574
>> se5100                MACH_SE5100             SE5100          575
>> s3c2510               MACH_S3C2510    S3C2510         576
>> csb437tl              MACH_CSB437TL   CSB437TL                577
>> slauson               MACH_SLAUSON    SLAUSON         578
>> pearlriver            MACH_PEARLRIVER PEARLRIVER      579
>> tdc_p210              MACH_TDC_P210   TDC_P210        580
>>
>> The machine S3C2510 is there in that file.
>
> S3C2510 sounds to me like a SoC name not a board name.  I delete anything
> which sounds like a SoC name as that's not the purpose of the database.
> It's for platforms and boards, not SoCs.

Yeah. The S3C2510 is a SoC. We have a board which is based on this
SoC. Just, I have given that name as I am new to this architecture
development environment. I will change the name and assigns an
appropriate one which suits for my board.

Thanks for your information.

Thanks and Regards,
Madhavi M.