From: David Miller <davem@davemloft.net>
To: benh@kernel.crashing.org
Cc: linux-pci@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, bheglaas@google.com,
monstr@monstr.eu, tglx@linuxtronix.de, bigeasy@linuxtronix.de
Subject: Re: [PATCH 1/5] pci/of: Match PCI devices to OF nodes dynamically
Date: Thu, 07 Apr 2011 15:29:37 -0700 (PDT) [thread overview]
Message-ID: <20110407.152937.59699180.davem@davemloft.net> (raw)
In-Reply-To: <20110407.152707.39195948.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Thu, 07 Apr 2011 15:27:07 -0700 (PDT)
> However, of_pci_find_child_device() lives in drivers/of/of_pci.c which is not
> built into the tree because you haven't provided the necessary changes to
> drivers/of/Makefile in this patch.
Oh I see, it exists already but it's only built into the tree for
microblaze, x86, and ppc.
There's a lot of stuff in there which is superfluous and will never
be used on sparc.
Everything in there except the new of_pci_find_child_device() function
will be never ever used on sparc and therefore dead code.
next prev parent reply other threads:[~2011-04-07 22:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 3:26 [PATCHES] Generalize PCI <-> OF node matching Benjamin Herrenschmidt
2011-04-07 3:26 ` Benjamin Herrenschmidt
2011-04-07 3:26 ` [PATCH 1/5] pci/of: Match PCI devices to OF nodes dynamically Benjamin Herrenschmidt
2011-04-07 4:20 ` Benjamin Herrenschmidt
2011-04-07 7:56 ` Sebastian Andrzej Siewior
2011-04-07 7:56 ` Sebastian Andrzej Siewior
2011-04-07 12:13 ` [PATCH] x86/ce4100: add reg property to bridges Sebastian Andrzej Siewior
2011-04-07 21:52 ` Benjamin Herrenschmidt
2011-04-11 7:23 ` Sebastian Andrzej Siewior
2011-04-11 9:38 ` Benjamin Herrenschmidt
2011-04-11 9:38 ` Benjamin Herrenschmidt
2011-04-07 22:27 ` [PATCH 1/5] pci/of: Match PCI devices to OF nodes dynamically David Miller
2011-04-07 22:27 ` David Miller
2011-04-07 22:29 ` David Miller [this message]
2011-04-07 22:31 ` David Miller
2011-04-07 22:31 ` David Miller
2011-04-07 22:52 ` David Miller
2011-04-07 22:52 ` David Miller
2011-04-07 23:22 ` Benjamin Herrenschmidt
2011-04-07 23:21 ` Benjamin Herrenschmidt
2011-04-07 3:26 ` [PATCH 2/5] microblaze/pci: Remove powermac originated cruft Benjamin Herrenschmidt
2011-04-07 3:26 ` Benjamin Herrenschmidt
2011-04-07 3:26 ` [PATCH 3/5] microblaze/pci: Move the remains of pci_32.c to pci-common.c Benjamin Herrenschmidt
2011-04-07 3:26 ` [PATCH 4/5] x86/devicetree: Use generic PCI <-> OF matching Benjamin Herrenschmidt
2011-04-07 10:30 ` Sebastian Andrzej Siewior
2011-04-07 3:26 ` [PATCH 5/5] pci/of: Consolidate pci_device_to_OF_node() Benjamin Herrenschmidt
2011-04-07 11:54 ` [PATCHES] Generalize PCI <-> OF node matching Michal Simek
2011-04-07 21:50 ` Benjamin Herrenschmidt
2011-04-07 22:16 ` David Miller
2011-04-07 22:30 ` Benjamin Herrenschmidt
2011-04-07 22:31 ` David Miller
2011-04-07 22:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110407.152937.59699180.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@kernel.crashing.org \
--cc=bheglaas@google.com \
--cc=bigeasy@linuxtronix.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=tglx@linuxtronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).