From: Sam Ravnborg <sam@ravnborg.org>
To: Guan Xuetao <gxt@mprc.pku.edu.cn>
Cc: 'Michal Marek' <mmarek@suse.cz>,
'lkml' <linux-kernel@vger.kernel.org>,
'linux-kbuild' <linux-kbuild@vger.kernel.org>,
'linux arch' <linux-arch@vger.kernel.org>,
'Arnd Bergmann' <arnd@arndb.de>,
'Guan Xuetao' <guanxuetao@mprc.pku.edu.cn>
Subject: Re: [PATCH v3] kbuild: asm-generic support
Date: Wed, 27 Apr 2011 21:42:25 +0200 [thread overview]
Message-ID: <20110427194225.GA6551@merkur.ravnborg.org> (raw)
In-Reply-To: <008401cc02e8$415af510$c410df30$@mprc.pku.edu.cn>
> > @@ -349,7 +349,8 @@ CFLAGS_GCOV = -fprofile-arcs -ftest-coverage
> >
> > # Use LINUXINCLUDE when you must reference the include/ directory.
> > # Needed to be compatible with the O= option
> > -LINUXINCLUDE := -I$(srctree)/arch/$(hdr-arch)/include -Iinclude \
> > +LINUXINCLUDE := -I$(srctree)/arch/$(hdr-arch)/include \
> > + -Iarch/$(hdr-arch)/include/generated -Iinclude \
> I think $(srctree) is necessary before new include-dir.
>
The generated files are located in objtree - because they
are generated. So $(srctree) would be wrong here.
> > +PHONY += asm-generic
> > +asm-generic:
> > + $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.asm-generic obj=arch/$(SRCARCH)/include/generated/asm
> Too long
fixed
> > _dst := $(if $(destination-y),$(destination-y),$(_dst))
> > +_src := $(srctree)/$(obj)
> _src is only used one time
fixed
> > +
> Additional empty line
fixed
> > + done; \
> > touch $@
> >
> > +
> Additional empty line
fixed
> > targets += $(install-file)
> > -$(install-file): scripts/headers_install.pl $(input-files) FORCE
> > +$(install-file): scripts/headers_install.pl \
> > + $(input-files) FORCE
> The same content
fixed
> I have tested on UniCore32, and it works well.
I take this as "Acked-by" and "Tested-by".
Thanks for feedback - new version to be posted shortly.
Sam
next prev parent reply other threads:[~2011-04-27 19:42 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-08 13:03 [RFC] kbuild: generic support for asm-generic Sam Ravnborg
2011-01-08 13:03 ` Sam Ravnborg
2011-01-08 13:04 ` [PATCH 1/2] kbuild: asm-generic support Sam Ravnborg
2011-01-08 13:04 ` Sam Ravnborg
2011-01-08 13:45 ` Stephen Rothwell
2011-01-08 14:03 ` Sam Ravnborg
2011-01-08 14:03 ` Sam Ravnborg
2011-01-08 14:10 ` Guan Xuetao
2011-01-08 14:10 ` Guan Xuetao
2011-01-08 13:05 ` [EXAMPLE PATCH 2/2] x86: start to utilize kbuild " Sam Ravnborg
2011-01-08 13:05 ` Sam Ravnborg
2011-01-08 20:53 ` [RFC] kbuild: generic support for asm-generic Arnd Bergmann
2011-01-08 21:33 ` Sam Ravnborg
2011-01-08 21:33 ` Sam Ravnborg
2011-01-09 0:15 ` Arnd Bergmann
2011-01-09 8:28 ` [RFC v2] " Sam Ravnborg
2011-01-09 8:28 ` Sam Ravnborg
2011-01-09 8:31 ` [PATCH 1/2] kbuild: asm-generic support Sam Ravnborg
2011-01-09 8:31 ` Sam Ravnborg
2011-01-09 14:03 ` Arnd Bergmann
2011-01-09 15:10 ` Sam Ravnborg
2011-01-09 16:13 ` Arnd Bergmann
2011-01-09 16:13 ` Arnd Bergmann
2011-01-09 8:32 ` [EXAMPLE PATCH 2/2] x86: start to utilize kbuild " Sam Ravnborg
2011-01-09 8:32 ` Sam Ravnborg
2011-01-09 19:27 ` [RFC v3] kbuild: generic support for asm-generic Sam Ravnborg
2011-01-09 19:27 ` Sam Ravnborg
2011-01-09 19:29 ` [PATCH 1/2] kbuild: asm-generic support Sam Ravnborg
2011-01-09 19:29 ` Sam Ravnborg
2011-01-09 20:31 ` Arnd Bergmann
2011-01-09 20:31 ` Arnd Bergmann
2011-01-09 21:24 ` Sam Ravnborg
2011-01-09 21:24 ` Sam Ravnborg
2011-01-10 13:14 ` Guan Xuetao
2011-01-10 13:14 ` Guan Xuetao
2011-01-10 16:26 ` Sam Ravnborg
2011-01-10 16:26 ` Sam Ravnborg
2011-01-11 1:39 ` Guan Xuetao
2011-01-10 13:31 ` Guan Xuetao
2011-01-10 13:31 ` Guan Xuetao
2011-01-13 16:14 ` Michal Marek
2011-01-13 17:01 ` Sam Ravnborg
2011-01-13 17:01 ` Sam Ravnborg
2011-01-14 14:43 ` Michal Marek
2011-04-22 15:53 ` [PATCH v3] " Sam Ravnborg
2011-04-22 15:53 ` Sam Ravnborg
2011-04-25 1:29 ` Guan Xuetao
2011-04-27 19:42 ` Sam Ravnborg [this message]
2011-04-27 19:42 ` Sam Ravnborg
2011-04-27 19:46 ` [PATCH v4] " Sam Ravnborg
2011-04-27 19:46 ` Sam Ravnborg
2011-04-27 19:52 ` Arnd Bergmann
2011-04-27 19:52 ` Arnd Bergmann
2011-04-27 20:29 ` [PATCH v5] " Sam Ravnborg
2011-04-27 20:29 ` Sam Ravnborg
2011-04-28 16:16 ` Michal Marek
2011-01-09 19:29 ` [EXAMPLE PATCH 2/2] x86: start to utilize kbuild " Sam Ravnborg
2011-01-09 19:29 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110427194225.GA6551@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=arnd@arndb.de \
--cc=guanxuetao@mprc.pku.edu.cn \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).