* [PATCH] thp: unbalanced parenthesis
@ 2011-05-07 18:55 Nicolas Kaiser
2011-05-30 11:02 ` Nicolas Kaiser
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Kaiser @ 2011-05-07 18:55 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linux-arch, linux-kernel
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
Untested.
include/asm-generic/pgtable.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h
index b4bfe33..b80daee 100644
--- a/include/asm-generic/pgtable.h
+++ b/include/asm-generic/pgtable.h
@@ -88,7 +88,7 @@ static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm,
pmd_t pmd = *pmdp;
pmd_clear(mm, address, pmdp);
return pmd;
-})
+}
#endif /* CONFIG_TRANSPARENT_HUGEPAGE */
#endif
--
1.7.5.rc3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] thp: unbalanced parenthesis
2011-05-07 18:55 [PATCH] thp: unbalanced parenthesis Nicolas Kaiser
@ 2011-05-30 11:02 ` Nicolas Kaiser
2011-05-30 14:10 ` Andrea Arcangeli
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Kaiser @ 2011-05-30 11:02 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Andrea Arcangeli, linux-arch, linux-kernel
Cc'ed Andrea Arcangeli.
* Nicolas Kaiser <nikai@nikai.net>:
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
> ---
> Untested.
>
> include/asm-generic/pgtable.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h
> index b4bfe33..b80daee 100644
> --- a/include/asm-generic/pgtable.h
> +++ b/include/asm-generic/pgtable.h
> @@ -88,7 +88,7 @@ static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm,
> pmd_t pmd = *pmdp;
> pmd_clear(mm, address, pmdp);
> return pmd;
> -})
> +}
> #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
> #endif
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] thp: unbalanced parenthesis
2011-05-30 11:02 ` Nicolas Kaiser
@ 2011-05-30 14:10 ` Andrea Arcangeli
0 siblings, 0 replies; 3+ messages in thread
From: Andrea Arcangeli @ 2011-05-30 14:10 UTC (permalink / raw)
To: Nicolas Kaiser; +Cc: Arnd Bergmann, linux-arch, linux-kernel
On Mon, May 30, 2011 at 01:02:09PM +0200, Nicolas Kaiser wrote:
> Cc'ed Andrea Arcangeli.
>
> * Nicolas Kaiser <nikai@nikai.net>:
> > Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
> > ---
> > Untested.
> >
> > include/asm-generic/pgtable.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h
> > index b4bfe33..b80daee 100644
> > --- a/include/asm-generic/pgtable.h
> > +++ b/include/asm-generic/pgtable.h
> > @@ -88,7 +88,7 @@ static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm,
> > pmd_t pmd = *pmdp;
> > pmd_clear(mm, address, pmdp);
> > return pmd;
> > -})
> > +}
> > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
> > #endif
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
All archs supporting THP aren't using that function so it isn't
possible to notice it in any config but it's better to fix it in case
some arch will use it in the future.
Thanks,
Andrea
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-30 14:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-07 18:55 [PATCH] thp: unbalanced parenthesis Nicolas Kaiser
2011-05-30 11:02 ` Nicolas Kaiser
2011-05-30 14:10 ` Andrea Arcangeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).