From: David Miller <davem@davemloft.net>
To: randy.dunlap@oracle.com
Cc: joe@perches.com, mingo@elte.hu, greearb@candelatech.com,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
arnd@arndb.de, netdev@vger.kernel.org
Subject: Re: [patch] net/core/filter.c: Fix build error
Date: Thu, 26 May 2011 15:00:57 -0400 (EDT) [thread overview]
Message-ID: <20110526.150057.165386141746439600.davem@davemloft.net> (raw)
In-Reply-To: <20110526115721.ee83aefc.randy.dunlap@oracle.com>
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Thu, 26 May 2011 11:57:21 -0700
> On Thu, 26 May 2011 14:38:43 -0400 (EDT) David Miller wrote:
>
>> From: Joe Perches <joe@perches.com>
>> Date: Thu, 26 May 2011 08:31:06 -0700
>>
>> > My suggestion would be to see about again adding
>> > #include <linux/ratelimit.h> somehow
>> > back to kernel.h which commit 3fff4c42bd0a removed
>> > in 2009 because of the spinlock issues.
>> >
>> > Any suggestion on how best to fix it generically?
>>
>> I don't think we want spinlock_t's definition being sucked
>> into kernel.h's dependency food chain.
>>
>> Even if desirable, I think it'd be quite a bit of surgery,
>> too much to do at this stage.
>>
>> So for now how about we make the ratelimit warn interfaces be a true,
>> instead of a pseudo, dependency on ratelimit.h by moving those
>> definitions into ratelimit.h?
>
> Works for me. Thanks.
>
> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Thanks for reviewing Randy, I've put this into net-2.6 and will
push it out to Linus soon.
next prev parent reply other threads:[~2011-05-26 19:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1305657014-32736-1-git-send-email-greearb@candelatech.com>
[not found] ` <1305658349.1722.30.camel@Joe-Laptop>
[not found] ` <20110517.152357.85105240786269960.davem@davemloft.net>
[not found] ` <4DD2CDA9.7000009@candelatech.com>
[not found] ` <1305662020.1722.42.camel@Joe-Laptop>
[not found] ` <4DD2DB9D.6050306@candelatech.com>
2011-05-17 21:13 ` RFC: Add WARN_RATELIMIT to bug.h (was: Re: [PATCH] sk-filter: Rate-limit WARNing, print dbg info.) Joe Perches
2011-05-17 21:13 ` Joe Perches
2011-05-21 17:48 ` [PATCH 0/2] Add and use WARN_RATELIMIT Joe Perches
2011-05-21 17:48 ` Joe Perches
2011-05-21 17:48 ` [PATCH 1/2] bug.h: Add WARN_RATELIMIT Joe Perches
2011-05-21 17:48 ` Joe Perches
2011-05-21 17:48 ` [PATCH 2/2] net: filter: Use WARN_RATELIMIT Joe Perches
2011-05-26 12:31 ` [patch] net/core/filter.c: Fix build error Ingo Molnar
2011-05-26 15:31 ` Joe Perches
2011-05-26 15:31 ` Joe Perches
2011-05-26 18:38 ` David Miller
2011-05-26 18:57 ` Randy Dunlap
2011-05-26 19:00 ` David Miller [this message]
2011-05-26 19:07 ` Joe Perches
2011-05-26 19:07 ` Joe Perches
2011-05-26 19:09 ` Ingo Molnar
2011-05-26 19:09 ` Ingo Molnar
2011-05-26 19:12 ` Ingo Molnar
2011-05-26 19:12 ` Ingo Molnar
2011-05-23 21:38 ` [PATCH 0/2] Add and use WARN_RATELIMIT David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110526.150057.165386141746439600.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=greearb@candelatech.com \
--cc=joe@perches.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).