From: Andrea Arcangeli <aarcange@redhat.com>
To: Nicolas Kaiser <nikai@nikai.net>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thp: unbalanced parenthesis
Date: Mon, 30 May 2011 16:10:28 +0200 [thread overview]
Message-ID: <20110530141028.GG19505@random.random> (raw)
In-Reply-To: <20110530130209.7ea4d55d@absol.kitzblitz>
On Mon, May 30, 2011 at 01:02:09PM +0200, Nicolas Kaiser wrote:
> Cc'ed Andrea Arcangeli.
>
> * Nicolas Kaiser <nikai@nikai.net>:
> > Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
> > ---
> > Untested.
> >
> > include/asm-generic/pgtable.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h
> > index b4bfe33..b80daee 100644
> > --- a/include/asm-generic/pgtable.h
> > +++ b/include/asm-generic/pgtable.h
> > @@ -88,7 +88,7 @@ static inline pmd_t pmdp_get_and_clear(struct mm_struct *mm,
> > pmd_t pmd = *pmdp;
> > pmd_clear(mm, address, pmdp);
> > return pmd;
> > -})
> > +}
> > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
> > #endif
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
All archs supporting THP aren't using that function so it isn't
possible to notice it in any config but it's better to fix it in case
some arch will use it in the future.
Thanks,
Andrea
prev parent reply other threads:[~2011-05-30 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 18:55 [PATCH] thp: unbalanced parenthesis Nicolas Kaiser
2011-05-30 11:02 ` Nicolas Kaiser
2011-05-30 14:10 ` Andrea Arcangeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110530141028.GG19505@random.random \
--to=aarcange@redhat.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikai@nikai.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).