From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [RFC,PATCH] Cleanup PC parallel port Kconfig Date: Wed, 15 Jun 2011 08:47:50 +0100 Message-ID: <20110615074749.GB28989@n2100.arm.linux.org.uk> References: <20110614190850.GA13526@linux-mips.org> <4DF7C3CA.9050902@zytor.com> <201106142333.16203.arnd@arndb.de> <4DF83577.6040903@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4DF83577.6040903@zytor.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "H. Peter Anvin" Cc: linux-mips@linux-mips.org, linux-m68k@vger.kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Benjamin Herrenschmidt , Chen Liqin , Paul Mackerras , sparclinux@vger.kernel.org, Guan Xuetao , Lennox Wu , linux-arch@vger.kernel.org, Jesper Nilsson , Yoshinori Sato , Helge Deller , x86@kernel.org, "James E.J. Bottomley" , Ingo Molnar , Geert Uytterhoeven , Matt Turner , Fenghua Yu , Arnd Bergmann , microblaze-uclinux@itee.uq.edu.au, Chris Metcalf , Mikael Starvik , Ivan Kokshaysky , Thomas List-Id: linux-arch.vger.kernel.org On Tue, Jun 14, 2011 at 09:30:47PM -0700, H. Peter Anvin wrote: > On 06/14/2011 02:33 PM, Arnd Bergmann wrote: > >> > >> Why on earth restrict it like that? It's just a device driver, like > >> more or less any other device driver... > > > > I'd say any other classic ISA/PC driver, including floppy, gameport or > > serial-8250. One problem with these is that we never fully worked out > > the dependencies for these, which we probably should. CONFIG_ISA > > generally means ISA add-on cards, but that might not be enabled for > > platforms that have a pc-parport but no ISA slots. > > > > OK, serial-8250 is clearly just plain wrong, since the 8250 series UARTs > are ubiquitous across just about every platform. > > Floppy is special (in the short bus sense), since it is closely tied to > ISA DMA. Conditionalizing this on ISA DMA makes total sense. No it doesn't. It depends on the ISA DMA API, not that the machine has ISA DMA. I have a platform which has no ISA DMA but uses the floppy driver. Please don't break it.