From: David Miller <davem@davemloft.net>
To: adobriyan@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
fujita.tomonori@lab.ntt.co.jp, linux-arch@vger.kernel.org
Subject: Re: [PATCH net-next] net: remove mm.h inclusion from netdevice.h
Date: Tue, 21 Jun 2011 16:25:07 -0700 (PDT) [thread overview]
Message-ID: <20110621.162507.453473443486815179.davem@davemloft.net> (raw)
In-Reply-To: <20110616210134.GA18026@p183.telecom.by>
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Fri, 17 Jun 2011 00:01:34 +0300
> Remove linux/mm.h inclusion from netdevice.h -- it's unused (I've checked manually).
>
> To prevent mm.h inclusion via other channels also extract "enum dma_data_direction"
> definition into separate header. This tiny piece is what gluing netdevice.h with mm.h
> via "netdevice.h => dmaengine.h => dma-mapping.h => scatterlist.h => mm.h".
> Removal of mm.h from scatterlist.h was tried and was found not feasible
> on most archs, so the link was cutoff earlier.
>
> Hope people are OK with tiny include file.
>
> Note, that mm_types.h is still dragged in, but it is a separate story.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
I've applied this, thanks.
prev parent reply other threads:[~2011-06-21 23:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 21:01 [PATCH net-next] net: remove mm.h inclusion from netdevice.h Alexey Dobriyan
2011-06-17 3:19 ` Stephen Rothwell
2011-06-17 6:57 ` Alexey Dobriyan
2011-06-21 23:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110621.162507.453473443486815179.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).