From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Subject: [PATCH] STAGING: Comedi: Build only on arches providing PAGE_KERNEL_NOCACHE Date: Thu, 23 Jun 2011 12:45:37 +0100 Message-ID: <20110623114536.GA14011@linux-mips.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devel-bounces@linuxdriverproject.org Errors-To: devel-bounces@linuxdriverproject.org To: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, David Howells , linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux Cc: linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org T24gYXJjaGl0ZWN0dXJlcyB0aGF0IGRvbid0IGRlZmluZSBQQUdFX0tFUk5FTF9OT0NBQ0hFLCB0 aGUgQ29tZWRpIGRyaXZlciB0dXJucwppbnRvIHRyYWdlZHk6CgogIENDIFtNXSAgZHJpdmVycy9z dGFnaW5nL2NvbWVkaS9kcml2ZXJzLm8KZHJpdmVycy9zdGFnaW5nL2NvbWVkaS9kcml2ZXJzLmM6 IEluIGZ1bmN0aW9uIOKAmGNvbWVkaV9idWZfYWxsb2PigJk6CmRyaXZlcnMvc3RhZ2luZy9jb21l ZGkvZHJpdmVycy5jOjUwNTo0MTogZXJyb3I6IOKAmFBBR0VfS0VSTkVMX05PQ0FDSEXigJkgdW5k ZWNsYXJlZCAoZmlyc3QgdXNlIGluIHRoaXMgZnVuY3Rpb24pCmRyaXZlcnMvc3RhZ2luZy9jb21l ZGkvZHJpdmVycy5jOjUwNTo0MTogbm90ZTogZWFjaCB1bmRlY2xhcmVkIGlkZW50aWZpZXIgaXMg cmVwIG9ydGVkIG9ubHkgb25jZSBmb3IgZWFjaCBmdW5jdGlvbiBpdCBhcHBlYXJzIGluCm1ha2Vb M106ICoqKiBbZHJpdmVycy9zdGFnaW5nL2NvbWVkaS9kcml2ZXJzLm9dIEVycm9yIDEKClJlc3Ry aWN0IHRoZSBkcml2ZXIgdG8gb25seSB0aG9zZSBhcmNoaXRlY3R1cmVzIHRoYXQgZGVmaW5lIFBB R0VfS0VSTkVMX05PQ0FDSEUuCgpQQUdFX0tFUk5FTF9OT0NBQ0hFIGlzIGEga2x1ZGdlIC0gc29t ZSBzeXN0ZW0gYXJjaGl0ZWN0dXJlcyBzdWNoIGFzIFNHSSBJUDI3CmFyZSBldmVuIHVhYmxlIHRv IG9mZmVyIHVuY2FjaGVkIG9wZXJhdGlvbiAtIGF0IGxlYXN0IGluIHRoZSB3YXkgYW4gdW53aXR0 aW5nCmRyaXZlciBtaWdodCBhc3N1bWUuICBJIGhhdmVuJ3QgbG9va2VkIGluIGRldGFpbHMgaG93 IHRoZSBkcml2ZXIgaXMgdXNpbmcKdGhlIGFyZWEgdm1hcGVkIHdpdGggUEFHRV9LRVJORUxfTk9D QUNIRSBidXQgbWF5YmUgZG9pbmcgaXQgWEZTLXN0eWxlIHVzaW5nCmNhY2hlZCBtZW1vcnkgYW5k IHRoZSBmbHVzaF9rZXJuZWxfdm1hcF9yYW5nZSAvIGludmFsaWRhdGVfa2VybmVsX3ZtYXBfcmFu Z2UKQVBJcyBpbiBjb25qdW5jdGlvbiB3aXRoIHRoZSBETUEgQVBJIGlzIGEgcHJhY3RpY2FsIGFs dGVybmF0aXZlLgoKU2lnbmVkLW9mZi1ieTogUmFsZiBCYWVjaGxlIDxyYWxmQGxpbnV4LW1pcHMu b3JnPgoKIGRyaXZlcnMvc3RhZ2luZy9jb21lZGkvS2NvbmZpZyB8ICAgIDEgKwogMSBmaWxlcyBj aGFuZ2VkLCAxIGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJp dmVycy9zdGFnaW5nL2NvbWVkaS9LY29uZmlnIGIvZHJpdmVycy9zdGFnaW5nL2NvbWVkaS9LY29u ZmlnCmluZGV4IDE1MDJkODAuLmJjY2RjMTIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvc3RhZ2luZy9j b21lZGkvS2NvbmZpZworKysgYi9kcml2ZXJzL3N0YWdpbmcvY29tZWRpL0tjb25maWcKQEAgLTIs NiArMiw3IEBAIGNvbmZpZyBDT01FREkKIAl0cmlzdGF0ZSAiRGF0YSBhY3F1aXNpdGlvbiBzdXBw b3J0IChjb21lZGkpIgogCWRlZmF1bHQgTgogCWRlcGVuZHMgb24gbQorCWRlcGVuZHMgb24gQlJP S0VOIHx8IEZSViB8fCBNMzJSIHx8IE1OMTAzMDAgfHwgU1VQRVJIIHx8IFRJTEUgfHwgWDg2CiAJ LS0taGVscC0tLQogCSAgRW5hYmxlIHN1cHBvcnQgYSB3aWRlIHJhbmdlIG9mIGRhdGEgYWNxdWlz aXRpb24gZGV2aWNlcwogCSAgZm9yIExpbnV4LgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkZXZlbCBtYWlsaW5nIGxpc3QKZGV2ZWxAbGludXhkcml2ZXJw cm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2LmxpbnV4ZHJpdmVycHJvamVjdC5vcmcvbWFpbG1h bi9saXN0aW5mby9kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from h5.dl5rb.org.uk ([81.2.74.5]:43597 "EHLO duck.linux-mips.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759217Ab1FWLqW (ORCPT ); Thu, 23 Jun 2011 07:46:22 -0400 Date: Thu, 23 Jun 2011 12:45:37 +0100 From: Ralf Baechle Subject: [PATCH] STAGING: Comedi: Build only on arches providing PAGE_KERNEL_NOCACHE Message-ID: <20110623114536.GA14011@linux-mips.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, David Howells , linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux-m32r.org, linux-am33-list@redhat.com, Paul Mundt , linux-sh@vger.kernel.org, Chris Metcalf , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org Cc: linux-arch@vger.kernel.org Message-ID: <20110623114537.aALGKQOJXepTNoCfgtc9w2ShcMw4gdoMW5vofSVnteQ@z> On architectures that don't define PAGE_KERNEL_NOCACHE, the Comedi driver turns into tragedy: CC [M] drivers/staging/comedi/drivers.o drivers/staging/comedi/drivers.c: In function ‘comedi_buf_alloc’: drivers/staging/comedi/drivers.c:505:41: error: ‘PAGE_KERNEL_NOCACHE’ undeclared (first use in this function) drivers/staging/comedi/drivers.c:505:41: note: each undeclared identifier is rep orted only once for each function it appears in make[3]: *** [drivers/staging/comedi/drivers.o] Error 1 Restrict the driver to only those architectures that define PAGE_KERNEL_NOCACHE. PAGE_KERNEL_NOCACHE is a kludge - some system architectures such as SGI IP27 are even uable to offer uncached operation - at least in the way an unwitting driver might assume. I haven't looked in details how the driver is using the area vmaped with PAGE_KERNEL_NOCACHE but maybe doing it XFS-style using cached memory and the flush_kernel_vmap_range / invalidate_kernel_vmap_range APIs in conjunction with the DMA API is a practical alternative. Signed-off-by: Ralf Baechle drivers/staging/comedi/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig index 1502d80..bccdc12 100644 --- a/drivers/staging/comedi/Kconfig +++ b/drivers/staging/comedi/Kconfig @@ -2,6 +2,7 @@ config COMEDI tristate "Data acquisition support (comedi)" default N depends on m + depends on BROKEN || FRV || M32R || MN10300 || SUPERH || TILE || X86 ---help--- Enable support a wide range of data acquisition devices for Linux.