From: Ingo Molnar <mingo@elte.hu>
To: Jonas Bonn <jonas@southpole.se>
Cc: rusty@rustcorp.com.au, arnd@arndb.de,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
monstr@monstr.eu, cmetcalf@tilera.com,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] modules: add default loader hook implementations
Date: Sat, 25 Jun 2011 12:04:49 +0200 [thread overview]
Message-ID: <20110625100449.GA19097@elte.hu> (raw)
In-Reply-To: <1308987512-6583-1-git-send-email-jonas@southpole.se>
* Jonas Bonn <jonas@southpole.se> wrote:
> +/* This configures the module loader code to use the default implementations
> + * for the architecture specific hooks. Architectures should set a #define
> + * for each of the hooks that it needs to override.
> + */
please use the standard (multi-line) comment style:
/*
* Comment .....
* ...... goes here.
*/
specified in Documentation/CodingStyle.
(there are similar problems elsewhere in the patch as well.)
Also, and more importantly, don't we generally do such things via
__weak aliases, because the result looks cleaner and needs no changes
for architectures beyond the removal of the generic functions? We
have excluded broken toolchains that miscompile/mislink __weak IIRC
so __weak ought to work.
Thanks,
Ingo
next prev parent reply other threads:[~2011-06-25 10:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-25 7:38 [PATCH] modules: add default loader hook implementations Jonas Bonn
2011-06-25 10:04 ` Ingo Molnar [this message]
2011-06-25 10:04 ` Ingo Molnar
2011-06-25 10:39 ` Jonas Bonn
2011-06-25 13:08 ` Arnd Bergmann
2011-06-27 9:07 ` Rusty Russell
2011-06-27 9:25 ` Geert Uytterhoeven
2011-06-27 11:05 ` Arnd Bergmann
2011-06-28 1:23 ` Rusty Russell
2011-06-28 10:45 ` Arnd Bergmann
2011-06-28 10:45 ` Arnd Bergmann
2011-06-28 16:50 ` Jonas Bonn
2011-06-28 16:50 ` Jonas Bonn
2011-06-30 19:22 ` [PATCH 1/2] " Jonas Bonn
2011-06-30 19:22 ` [PATCH 2/2] modules: make arch's use default loader hooks Jonas Bonn
2011-06-30 19:22 ` Jonas Bonn
2011-06-30 19:46 ` Mike Frysinger
2011-07-01 7:00 ` Geert Uytterhoeven
2011-07-05 11:25 ` Michal Simek
2011-07-05 11:25 ` Michal Simek
2011-06-30 19:43 ` [PATCH 1/2] modules: add default loader hook implementations Mike Frysinger
2011-06-30 20:02 ` Linus Torvalds
2011-07-01 5:00 ` Jonas Bonn
2011-07-04 4:34 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110625100449.GA19097@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=cmetcalf@tilera.com \
--cc=jonas@southpole.se \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).