From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Jonas Bonn <jonas@southpole.se>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
monstr@monstr.eu, cmetcalf@tilera.com,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] modules: add default loader hook implementations
Date: Mon, 27 Jun 2011 13:05:44 +0200 [thread overview]
Message-ID: <201106271305.44746.arnd@arndb.de> (raw)
In-Reply-To: <BANLkTinmhQT=__WP+10cr2HZPy1TvdxZ=w@mail.gmail.com>
On Monday 27 June 2011, Geert Uytterhoeven wrote:
> >> I don't care much either way, you would get my Ack for both solutions.
> >> The __weak approach would definitely make a simpler patch, and the
> >> patch you sent adds extra complexity because of the
> >> asm_generic_moduleloader_hooks macro you used to avoid having to
> >> change all other architectures.
> >
> > I think you misread me. If all else is equal, I dislike weak functions.
> > But AFAICT the two standard mechanisms are #ifdef HAVE_ARCH and __weak.
> > Inventing a third one is not going to be a win.
>
> It's not inventing a new one, the third one is already in use.
True. In fact, we are (slowly) migrating away from HAVE_ARCH_* elsewhere.
In include/asm-generic/*.h, the common method is now to #define the exact
symbol if an architecture wants to override the generic version.
Weak symbols are fairly obscure in comparison, but they are actively
used by a few architectures (mips, sh) and some core code in kernel/
and mm/.
Arnd
next prev parent reply other threads:[~2011-06-27 11:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-25 7:38 [PATCH] modules: add default loader hook implementations Jonas Bonn
2011-06-25 10:04 ` Ingo Molnar
2011-06-25 10:04 ` Ingo Molnar
2011-06-25 10:39 ` Jonas Bonn
2011-06-25 13:08 ` Arnd Bergmann
2011-06-27 9:07 ` Rusty Russell
2011-06-27 9:25 ` Geert Uytterhoeven
2011-06-27 11:05 ` Arnd Bergmann [this message]
2011-06-28 1:23 ` Rusty Russell
2011-06-28 10:45 ` Arnd Bergmann
2011-06-28 10:45 ` Arnd Bergmann
2011-06-28 16:50 ` Jonas Bonn
2011-06-28 16:50 ` Jonas Bonn
2011-06-30 19:22 ` [PATCH 1/2] " Jonas Bonn
2011-06-30 19:22 ` [PATCH 2/2] modules: make arch's use default loader hooks Jonas Bonn
2011-06-30 19:22 ` Jonas Bonn
2011-06-30 19:46 ` Mike Frysinger
2011-07-01 7:00 ` Geert Uytterhoeven
2011-07-05 11:25 ` Michal Simek
2011-07-05 11:25 ` Michal Simek
2011-06-30 19:43 ` [PATCH 1/2] modules: add default loader hook implementations Mike Frysinger
2011-06-30 20:02 ` Linus Torvalds
2011-07-01 5:00 ` Jonas Bonn
2011-07-04 4:34 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106271305.44746.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=cmetcalf@tilera.com \
--cc=geert@linux-m68k.org \
--cc=jonas@southpole.se \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=monstr@monstr.eu \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).