From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Subject: Re: SB16 build error. Date: Thu, 30 Jun 2011 11:52:54 +0100 Message-ID: <20110630105254.GA25732@linux-mips.org> References: <20110630091754.GA12119@linux-mips.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: linux-arch@vger.kernel.org, linux-mips@linux-mips.org, alsa-devel@alsa-project.org, florian@linux-mips.org, "David S. Miller" , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, Ivan Kokshaysky , sparclinux@vger.kernel.org, Paul Mackerras , Matt Turner , Florian Fainelli , Richard Henderson List-Id: linux-arch.vger.kernel.org T24gVGh1LCBKdW4gMzAsIDIwMTEgYXQgMTI6MTU6NTZQTSArMDIwMCwgVGFrYXNoaSBJd2FpIHdy b3RlOgoKPiBBdCBUaHUsIDMwIEp1biAyMDExIDEwOjE3OjU0ICswMTAwLAo+IFJhbGYgQmFlY2hs ZSB3cm90ZToKPiA+IAo+ID4gRm91bmQgb24gYSBNSVBTIGJ1aWxkIGJ1dCBjZXJ0YWluIG90aGVy IGFyY2hpdGVjdHVyZXMgd2lsbCBoYXZlIHRoZSBzYW1lCj4gPiBpc3N1ZToKPiA+IAo+ID4gICBD QyAgICAgIHNvdW5kL2lzYS9zYi9zYjE2X2NzcC5vCj4gPiBzb3VuZC9pc2Evc2Ivc2IxNl9jc3Au YzogSW4gZnVuY3Rpb24g4oCYc25kX3NiX2NzcF9pb2N0bOKAmToKPiA+IHNvdW5kL2lzYS9zYi9z YjE2X2NzcC5jOjIyODogZXJyb3I6IGNhc2UgbGFiZWwgZG9lcyBub3QgcmVkdWNlIHRvIGFuIGlu dGVnZXIgY29uc3RhbnQKPiA+IG1ha2VbMV06ICoqKiBbc291bmQvaXNhL3NiL3NiMTZfY3NwLm9d IEVycm9yIDEKPiA+IG1ha2U6ICoqKiBbc291bmQvaXNhL3NiL3NiMTZfY3NwLm9dIEVycm9yIDIK PiA+IAo+ID4gVGhpcyBlcnJvciBtZXNzYWdlIGlzIGNhdXNlZCBieSB0aGUgX0lPQ19UWVBFQ0hF Q0soKSBlcnJvciBjaGVjayB0cmlnZ2VyaW5nCj4gPiBkdWUgdG8gZXhjZXNzaXZlIGlvY3RsIHNp emUgb24gQWxwaGEsIFBvd2VyUEMsIE1JUFMgYW5kIFNQQVJDIHdoaWNoIGRlZmluZQo+ID4gX0lP Q19TSVpFQklUUyBhcyAxMy4gIE9uIGFsbCBvdGhlciBhcmNoaXRlY3R1cmVzIGRlZmluZSBpdCBh cyAxNCBzbyBzdHJ1Y3QKPiA+IHNuZF9zYl9jc3BfbWljcm9jb2RlIHdpdGggaXQncyBsaXR0bGUg b3ZlciAxMmtCIHdpbGwganVzdCBhYm91dCBmaXQgaW50bwo+ID4gdGhlIDE2a0IgbGltaXQuCj4g Cj4gV2hhdCBhYm91dCB0aGUgcGF0Y2ggYmVsb3c/CgpJIGhhdmUgbm8gaWRlYSBob3cgYmlnIHRo ZSBzb3VuZGJsYXN0ZXIgbWljcm9jb2RlIGJlaW5nIGxvYWRlZCBhY3R1YWxseSBpcywKdGhhdCBp cyBpZiB0aGUgcmVkdWNlZCBzaXplIG9mIDB4MWYwMCB3aWxsIGJlIHN1ZmZpY2llbnQuICBBc2lk ZSBvZiB0aGF0IEkKZG9uJ3Qgc2VlIGEgcHJvYmxlbSAtIEkgZG9uJ3Qgc2VlIGhvdyB0aGUgb2xk IGlvY3RsIGNhbiBwb3NzaWJseSBoYXZlIGJlZW4KdXNlZCBiZWZvcmUgc28gdGhlcmUgaXNuJ3Qg YSBjb21wYXRpYmlsaXR5IHByb2JsZW0uCgpPciB5b3UgY291bGQgZW50aXJlbHkgc2lkZXN0ZXAg dGhlIHByb2JsZW0gYW5kIHVzZSByZXF1ZXN0X2Zpcm13YXJlKCkgYnV0CkkgZ3Vlc3MgdGhhdCdz IG1vcmUgZWZmb3J0IHRoYW4geW91IHdhbnQgdG8gaW52ZXN0LgoKPiBUaGlzIGlzIGFuIG9sZCBJ U0EgZHJpdmVyLCBzbyB0aGUgaW1wYWN0IG11c3QgYmUgdmVyeSBsb3cuCgpUcnVlLiAgSSBub3Rp Y2UgdGhhdCBzb3J0IG9mIHN0dWZmIGluIGF1dG9tYXRlZCBtYXNzIGJ1aWxkcyAtIG5vdApuZWNl c3NhcmlseSB0aGUgc29ydCBvZiBrZXJuZWxzIG9uZSB3b3VsZCBhY3R1YWxseSB1c2UuICBTdGls bCBidWlsZCBlcnJvcnMKYXJlIGFubm95aW5nIDopCgogIFJhbGYKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQWxzYS1kZXZlbCBtYWlsaW5nIGxpc3QKQWxz YS1kZXZlbEBhbHNhLXByb2plY3Qub3JnCmh0dHA6Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5vcmcv bWFpbG1hbi9saXN0aW5mby9hbHNhLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from h5.dl5rb.org.uk ([81.2.74.5]:52075 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750991Ab1F3Kxm (ORCPT ); Thu, 30 Jun 2011 06:53:42 -0400 Date: Thu, 30 Jun 2011 11:52:54 +0100 From: Ralf Baechle Subject: Re: SB16 build error. Message-ID: <20110630105254.GA25732@linux-mips.org> References: <20110630091754.GA12119@linux-mips.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Takashi Iwai Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, florian@linux-mips.org, Florian Fainelli , linux-arch@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Matt Turner , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , sparclinux@vger.kernel.org Message-ID: <20110630105254.iiCKrfwfVtqazV9d6U_o-UElqDTnIbC_z87dk8uB3tI@z> On Thu, Jun 30, 2011 at 12:15:56PM +0200, Takashi Iwai wrote: > At Thu, 30 Jun 2011 10:17:54 +0100, > Ralf Baechle wrote: > > > > Found on a MIPS build but certain other architectures will have the same > > issue: > > > > CC sound/isa/sb/sb16_csp.o > > sound/isa/sb/sb16_csp.c: In function ‘snd_sb_csp_ioctl’: > > sound/isa/sb/sb16_csp.c:228: error: case label does not reduce to an integer constant > > make[1]: *** [sound/isa/sb/sb16_csp.o] Error 1 > > make: *** [sound/isa/sb/sb16_csp.o] Error 2 > > > > This error message is caused by the _IOC_TYPECHECK() error check triggering > > due to excessive ioctl size on Alpha, PowerPC, MIPS and SPARC which define > > _IOC_SIZEBITS as 13. On all other architectures define it as 14 so struct > > snd_sb_csp_microcode with it's little over 12kB will just about fit into > > the 16kB limit. > > What about the patch below? I have no idea how big the soundblaster microcode being loaded actually is, that is if the reduced size of 0x1f00 will be sufficient. Aside of that I don't see a problem - I don't see how the old ioctl can possibly have been used before so there isn't a compatibility problem. Or you could entirely sidestep the problem and use request_firmware() but I guess that's more effort than you want to invest. > This is an old ISA driver, so the impact must be very low. True. I notice that sort of stuff in automated mass builds - not necessarily the sort of kernels one would actually use. Still build errors are annoying :) Ralf