From: Arnd Bergmann <arnd@arndb.de>
To: Jonas Bonn <jonas@southpole.se>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 2/2] iomap: make IOPORT/PCI mapping functions conditional
Date: Sat, 2 Jul 2011 22:15:47 +0200 [thread overview]
Message-ID: <201107022215.47324.arnd@arndb.de> (raw)
In-Reply-To: <1309636466.24186.1439.camel@localhost>
On Saturday 02 July 2011 21:54:26 Jonas Bonn wrote:
> On Sat, 2011-07-02 at 21:46 +0200, Arnd Bergmann wrote:
> > On Saturday 02 July 2011 17:53:26 Jonas Bonn wrote:
> > > Use the CONFIG_HAS_IOPORT and CONFIG_PCI options to decide whether or
> > > not functions for mapping these areas are provided.
> > >
> > > Signed-off-by: Jonas Bonn <jonas@southpole.se>
> >
> > Good catch!
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Did you get a build error without the two options, or did you just have an
> > idea to save a bit of code size?
> >
>
> There was no build error; I just figured it would aid in debugging if
> you got a compile-time error when trying to build drivers that use these
> functions for a platform that lacked them. Smaller code is always nice,
> too.
Right. Did you also see the related discussion at
http://lkml.org/lkml/2011/7/1/422 ?
Arnd
next prev parent reply other threads:[~2011-07-02 20:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-02 15:53 [PATCH 1/2] asm-generic: add MMU variants of io.h functions Jonas Bonn
2011-07-02 15:53 ` Jonas Bonn
2011-07-02 15:53 ` [PATCH 2/2] iomap: make IOPORT/PCI mapping functions conditional Jonas Bonn
2011-07-02 19:46 ` Arnd Bergmann
2011-07-02 19:54 ` Jonas Bonn
2011-07-02 20:15 ` Arnd Bergmann [this message]
2011-07-02 16:38 ` [PATCH 1/2] asm-generic: add MMU variants of io.h functions Mike Frysinger
2011-07-02 16:47 ` Jonas Bonn
2011-07-02 17:04 ` Mike Frysinger
2011-07-02 17:04 ` Mike Frysinger
2011-07-02 17:36 ` [PATCH v2 1/1] " Jonas Bonn
2011-07-02 18:43 ` Mike Frysinger
2011-07-02 19:44 ` Arnd Bergmann
2011-07-04 2:28 ` Guan Xuetao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107022215.47324.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=jonas@southpole.se \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox