Re: [PATCH 1/8] bootmem: Replace work_with_active_regions() with for_each_mem_pfn_range()

[Tejun Heo <tj@kernel.org>]

On Wed, Jul 13, 2011 at 07:11:36PM -0700, H. Peter Anvin wrote:
> On 07/12/2011 01:46 AM, Tejun Heo wrote:
> > Callback based iteration is cumbersome and much less useful than
> > for_each_*() iterator.  This patch implements for_each_mem_pfn_range()
> > which replaces work_with_active_regions().  All the current users of
> > work_with_active_regions() are converted.
> > 
> > This simplifies walking over early_node_map and will allow converting
> > internal logics in page_alloc to use iterator instead of walking
> > early_node_map directly, which in turn will enable moving node
> > information to memblock.
> > 
> > powerpc change is only compile tested.
> > 
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> > Cc: Yinghai Lu <yinghai@kernel.org>
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> 
> This patch causes a build failure on x86-64 with the attached .config:
> 
> /home/hpa/kernel/linux-2.6-tip.memblock/drivers/pci/intel-iommu.c: In
> function ‘si_domain_init’:
> /home/hpa/kernel/linux-2.6-tip.memblock/drivers/pci/intel-iommu.c:2216:4: error:
> implicit declaration of function ‘iommuc_domain_identity_map’
> [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors

It was a typo that I fixed before sending the patches but obviously I
sent the old one.  The git tree had the updated one.  I'll re-post the
updated one.

Thank you.

-- 
tejun