From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, linux-arch@vger.kernel.org
Subject: Re: [RFC/PULL 00/11] introduce export.h; reduce module.h usage
Date: Thu, 28 Jul 2011 11:27:53 -0400 [thread overview]
Message-ID: <20110728152753.GA19409@windriver.com> (raw)
In-Reply-To: <CA+55aFwtyfzaFABHKD+OMWsojGov0JLmnrZimhVaOcrer=tJjQ@mail.gmail.com>
[Re: [RFC/PULL 00/11] introduce export.h; reduce module.h usage] On 28/07/2011 (Thu 06:19) Linus Torvalds wrote:
> On Wed, Jul 27, 2011 at 10:16 PM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
> >
> > For all 160 commits, the branch "module.h-split", available here:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux.git
> >
> > has the complete content. I've put the header changes after all the
> > patches from the top 5 categories, so that people bisecting non related
> > issues at a later date don't get hit with a commit zone with build failures.
>
> Ok, sounds good. Two questions:
>
> - how much testing (randconfig? different architectures?) has this gotten?
I built allyeconfigs for arm, mips, powerpc, sparc, x86, x86-64.
Originally I was working on a v3.0-rc7 baseline, but after looking
at the new implicit module.h usages added since then, it was apparent
that I should update the baseline.
So I've re-run the multi-arch allyesconfigs to catch those new ones,
but with fallout from completely non related stuff, the allyesconfigs
on the non x86 variants don't build as far on the new v3.0-5684-ge371d46
baseline as they did on the 3.0-rc7 (to be expected in a tree leading up
to an rc1 release).
>
> - how much does this actually improve compile times (for a "normal"
> build or a "allmodconfig" one)?
Let me run some "real world" use cases and get back to you in a couple
of hours with that. But Ingo's testing on a much earlier snapshot was
showing roughly a couple percent. ( https://lkml.org/lkml/2011/5/28/60 )
> It certainly sounds like the RightThing(tm) to do, but I'd like to
> know that there is real actual improvements to build times and that
> the pain won't be too bad...
Yes, I've spent a lot of time fixing as many implicit users (thousands)
to try and minimize the pain here. But I'd be a fool to think I have
them all fixed in the less mainstream architectures (alpha, sh, etc.)
And I know mips and arm have quite a few files that are platform specific
in mach-* and plat-* and they might not all get coverage via allyesconfig.
That is one place where I can think of that I am going to expand even
more testing into today. Adding it to linux-next can't hurt either.
Thanks,
Paul.
>
> Linus
next prev parent reply other threads:[~2011-07-28 15:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 5:16 [RFC/PULL 00/11] introduce export.h; reduce module.h usage Paul Gortmaker
2011-07-28 5:16 ` [PATCH 01/11] module.h: split out the EXPORT_SYMBOL for faster compiles Paul Gortmaker
2011-07-28 5:16 ` [PATCH 02/11] sysdev.h: dont include <linux/module.h> for no reason Paul Gortmaker
2011-07-28 5:16 ` [PATCH 03/11] net: inet_timewait_sock doesnt need <linux/module.h> Paul Gortmaker
2011-07-28 5:16 ` [PATCH 04/11] device_cgroup.h: delete needless include <linux/module.h> Paul Gortmaker
2011-07-28 5:16 ` [PATCH 05/11] crypto.h: remove unused crypto_tfm_alg_modname() inline Paul Gortmaker
2011-07-28 5:16 ` [PATCH 06/11] linux/stop_machine.h: fix implicit use of smp.h for smp_processor_id Paul Gortmaker
2011-07-28 5:16 ` Paul Gortmaker
2011-07-28 5:16 ` [PATCH 07/11] pm_runtime.h: explicitly requires notifier.h Paul Gortmaker
2011-07-28 5:16 ` Paul Gortmaker
2011-07-28 5:16 ` [PATCH 08/11] uwb.h: fix implicit use of asm/page.h for PAGE_SIZE Paul Gortmaker
2011-07-28 5:16 ` [PATCH 09/11] net: sch_generic remove redundant use of <linux/module.h> Paul Gortmaker
2011-07-28 5:16 ` [PATCH 10/11] include: convert various register fcns to macros to avoid include chaining Paul Gortmaker
2011-07-28 5:16 ` Paul Gortmaker
2011-07-28 5:16 ` [PATCH 11/11] include: replace linux/module.h with "struct module" wherever possible Paul Gortmaker
2011-07-28 5:16 ` Paul Gortmaker
2011-07-28 7:15 ` [RFC/PULL 00/11] introduce export.h; reduce module.h usage Ingo Molnar
2011-07-28 15:42 ` Paul Gortmaker
2011-07-29 1:20 ` Stephen Rothwell
2011-08-01 11:49 ` Geert Uytterhoeven
2011-08-02 5:02 ` Paul Gortmaker
2011-08-02 6:54 ` Geert Uytterhoeven
2011-07-28 9:40 ` Anca Emanuel
2011-07-28 13:19 ` Linus Torvalds
2011-07-28 15:27 ` Paul Gortmaker [this message]
2011-07-28 19:18 ` Ingo Molnar
2011-08-02 18:30 ` Paul Gortmaker
2011-08-08 2:42 ` Mike Frysinger
2011-08-10 19:09 ` Paul Gortmaker
2011-08-11 4:34 ` Mike Frysinger
2011-08-11 13:10 ` Paul Gortmaker
2011-08-11 13:10 ` Paul Gortmaker
2011-08-11 17:15 ` Mike Frysinger
2011-08-11 17:20 ` Paul Gortmaker
2011-10-13 2:07 ` Rusty Russell
2011-10-13 21:51 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728152753.GA19409@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).