From: Andrew Morton <akpm@linux-foundation.org>
To: Akinobu Mita <akinobu.mita@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
Joern Engel <joern@logfs.org>,
logfs@logfs.org, Marcin Slusarz <marcin.slusarz@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 3/4] string: introduce memchr_inv
Date: Mon, 22 Aug 2011 14:50:50 -0700 [thread overview]
Message-ID: <20110822145050.e3471fa0.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110822135218.f2d9f462.akpm@linux-foundation.org>
On Mon, 22 Aug 2011 13:52:18 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> > + value64 = value | value << 8 | value << 16 | value << 24;
> > + value64 = (value64 & 0xffffffff) | value64 << 32;
> > + prefix = 8 - ((unsigned long)start) % 8;
> > +
> > + if (prefix) {
> > + u8 *r = check_bytes8(start, value, prefix);
> > + if (r)
> > + return r;
> > + start += prefix;
> > + bytes -= prefix;
> > + }
> > +
> > + words = bytes / 8;
> > +
> > + while (words) {
> > + if (*(u64 *)start != value64)
>
> OK, problem. This will explode if passed a misaligned address on
> certain (non-x86) architectures.
pls ignore. As Marcin points out, I can't read.
next prev parent reply other threads:[~2011-08-22 21:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1314030548-21082-1-git-send-email-akinobu.mita@gmail.com>
[not found] ` <1314030548-21082-4-git-send-email-akinobu.mita@gmail.com>
2011-08-22 20:52 ` [PATCH 3/4] string: introduce memchr_inv Andrew Morton
2011-08-22 20:52 ` Andrew Morton
2011-08-22 21:50 ` Andrew Morton
2011-08-22 21:50 ` Andrew Morton [this message]
2011-08-22 21:56 ` Eric Dumazet
2011-08-22 21:56 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110822145050.e3471fa0.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=akinobu.mita@gmail.com \
--cc=cl@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=joern@logfs.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logfs@logfs.org \
--cc=marcin.slusarz@gmail.com \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox