* Re: [PATCH 01/43] signal: Add block_sigmask() for adding sigmask to current->blocked
[not found] ` <1313772419-21951-2-git-send-email-matt@console-pimps.org>
@ 2011-08-22 10:19 ` Matt Fleming
2011-08-22 14:01 ` Oleg Nesterov
0 siblings, 1 reply; 10+ messages in thread
From: Matt Fleming @ 2011-08-22 10:19 UTC (permalink / raw)
To: Oleg Nesterov
Cc: linux-kernel, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
Tejun Heo, Andrew Morton, Guan Xuetao, linux-arch
(Adding linux-arch to Cc so arch maintainers will hopefully see this)
On Fri, 2011-08-19 at 17:46 +0100, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@intel.com>
>
> This patch abstracts the code sequence for adding a signal handler's
> sa_mask to current->blocked because the sequence is identical for all
> architectures. Furthermore, in the past some architectures actually
> got this code wrong, so introduce a wrapper that all architectures can
> use.
>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
> ---
> arch/x86/kernel/signal.c | 6 +-----
> include/linux/signal.h | 1 +
> kernel/signal.c | 21 +++++++++++++++++++++
> 3 files changed, 23 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c
> index 54ddaeb2..46a01bd 100644
> --- a/arch/x86/kernel/signal.c
> +++ b/arch/x86/kernel/signal.c
> @@ -682,7 +682,6 @@ static int
> handle_signal(unsigned long sig, siginfo_t *info, struct k_sigaction *ka,
> struct pt_regs *regs)
> {
> - sigset_t blocked;
> int ret;
>
> /* Are we from a system call? */
> @@ -733,10 +732,7 @@ handle_signal(unsigned long sig, siginfo_t *info, struct k_sigaction *ka,
> */
> regs->flags &= ~X86_EFLAGS_TF;
>
> - sigorsets(&blocked, ¤t->blocked, &ka->sa.sa_mask);
> - if (!(ka->sa.sa_flags & SA_NODEFER))
> - sigaddset(&blocked, sig);
> - set_current_blocked(&blocked);
> + block_sigmask(ka, sig);
>
> tracehook_signal_handler(sig, info, ka, regs,
> test_thread_flag(TIF_SINGLESTEP));
> diff --git a/include/linux/signal.h b/include/linux/signal.h
> index a822300..7987ce74 100644
> --- a/include/linux/signal.h
> +++ b/include/linux/signal.h
> @@ -254,6 +254,7 @@ extern void set_current_blocked(const sigset_t *);
> extern int show_unhandled_signals;
>
> extern int get_signal_to_deliver(siginfo_t *info, struct k_sigaction *return_ka, struct pt_regs *regs, void *cookie);
> +extern void block_sigmask(struct k_sigaction *ka, int signr);
> extern void exit_signals(struct task_struct *tsk);
>
> extern struct kmem_cache *sighand_cachep;
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 291c970..7a08164 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -2314,6 +2314,27 @@ relock:
> return signr;
> }
>
> +/**
> + * block_sigmask - add @ka's signal mask to current->blocked
> + * @ka: action for @signr
> + * @signr: signal that has been successfully delivered
> + *
> + * This function should be called when a signal has succesfully been
> + * delivered. It adds the mask of signals for @ka to current->blocked
> + * so that they are blocked during the execution of the signal
> + * handler. In addition, @signr will be blocked unless %SA_NODEFER is
> + * set in @ka->sa.sa_flags.
> + */
> +void block_sigmask(struct k_sigaction *ka, int signr)
> +{
> + sigset_t blocked;
> +
> + sigorsets(&blocked, ¤t->blocked, &ka->sa.sa_mask);
> + if (!(ka->sa.sa_flags & SA_NODEFER))
> + sigaddset(&blocked, signr);
> + set_current_blocked(&blocked);
> +}
> +
> /*
> * It could be that complete_signal() picked us to notify about the
> * group-wide signal. Other threads should be notified now to take
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 01/43] signal: Add block_sigmask() for adding sigmask to current->blocked
2011-08-22 10:19 ` [PATCH 01/43] signal: Add block_sigmask() for adding sigmask to current->blocked Matt Fleming
@ 2011-08-22 14:01 ` Oleg Nesterov
2011-08-22 14:04 ` Oleg Nesterov
2011-08-22 15:56 ` Matt Fleming
0 siblings, 2 replies; 10+ messages in thread
From: Oleg Nesterov @ 2011-08-22 14:01 UTC (permalink / raw)
To: Matt Fleming
Cc: linux-kernel, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
Tejun Heo, Andrew Morton, Guan Xuetao, linux-arch
On 08/22, Matt Fleming wrote:
>
> (Adding linux-arch to Cc so arch maintainers will hopefully see this)
Yes, thanks.
So far I applied only this patch to
git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc.git ptrace
But I am going to take the whole series unless I have the nack from
maintainers. Everything looks correct.
IOW, I am going to wait a bit to collect the ACKs from the maintainers
in case (I hope ;) they want to review these changes.
OK?
Oleg.
> On Fri, 2011-08-19 at 17:46 +0100, Matt Fleming wrote:
> > From: Matt Fleming <matt.fleming@intel.com>
> >
> > This patch abstracts the code sequence for adding a signal handler's
> > sa_mask to current->blocked because the sequence is identical for all
> > architectures. Furthermore, in the past some architectures actually
> > got this code wrong, so introduce a wrapper that all architectures can
> > use.
> >
> > Cc: Oleg Nesterov <oleg@redhat.com>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@elte.hu>
> > Cc: H. Peter Anvin <hpa@zytor.com>
> > Cc: Tejun Heo <tj@kernel.org>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Matt Fleming <matt.fleming@intel.com>
> > ---
> > arch/x86/kernel/signal.c | 6 +-----
> > include/linux/signal.h | 1 +
> > kernel/signal.c | 21 +++++++++++++++++++++
> > 3 files changed, 23 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c
> > index 54ddaeb2..46a01bd 100644
> > --- a/arch/x86/kernel/signal.c
> > +++ b/arch/x86/kernel/signal.c
> > @@ -682,7 +682,6 @@ static int
> > handle_signal(unsigned long sig, siginfo_t *info, struct k_sigaction *ka,
> > struct pt_regs *regs)
> > {
> > - sigset_t blocked;
> > int ret;
> >
> > /* Are we from a system call? */
> > @@ -733,10 +732,7 @@ handle_signal(unsigned long sig, siginfo_t *info, struct k_sigaction *ka,
> > */
> > regs->flags &= ~X86_EFLAGS_TF;
> >
> > - sigorsets(&blocked, ¤t->blocked, &ka->sa.sa_mask);
> > - if (!(ka->sa.sa_flags & SA_NODEFER))
> > - sigaddset(&blocked, sig);
> > - set_current_blocked(&blocked);
> > + block_sigmask(ka, sig);
> >
> > tracehook_signal_handler(sig, info, ka, regs,
> > test_thread_flag(TIF_SINGLESTEP));
> > diff --git a/include/linux/signal.h b/include/linux/signal.h
> > index a822300..7987ce74 100644
> > --- a/include/linux/signal.h
> > +++ b/include/linux/signal.h
> > @@ -254,6 +254,7 @@ extern void set_current_blocked(const sigset_t *);
> > extern int show_unhandled_signals;
> >
> > extern int get_signal_to_deliver(siginfo_t *info, struct k_sigaction *return_ka, struct pt_regs *regs, void *cookie);
> > +extern void block_sigmask(struct k_sigaction *ka, int signr);
> > extern void exit_signals(struct task_struct *tsk);
> >
> > extern struct kmem_cache *sighand_cachep;
> > diff --git a/kernel/signal.c b/kernel/signal.c
> > index 291c970..7a08164 100644
> > --- a/kernel/signal.c
> > +++ b/kernel/signal.c
> > @@ -2314,6 +2314,27 @@ relock:
> > return signr;
> > }
> >
> > +/**
> > + * block_sigmask - add @ka's signal mask to current->blocked
> > + * @ka: action for @signr
> > + * @signr: signal that has been successfully delivered
> > + *
> > + * This function should be called when a signal has succesfully been
> > + * delivered. It adds the mask of signals for @ka to current->blocked
> > + * so that they are blocked during the execution of the signal
> > + * handler. In addition, @signr will be blocked unless %SA_NODEFER is
> > + * set in @ka->sa.sa_flags.
> > + */
> > +void block_sigmask(struct k_sigaction *ka, int signr)
> > +{
> > + sigset_t blocked;
> > +
> > + sigorsets(&blocked, ¤t->blocked, &ka->sa.sa_mask);
> > + if (!(ka->sa.sa_flags & SA_NODEFER))
> > + sigaddset(&blocked, signr);
> > + set_current_blocked(&blocked);
> > +}
> > +
> > /*
> > * It could be that complete_signal() picked us to notify about the
> > * group-wide signal. Other threads should be notified now to take
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 01/43] signal: Add block_sigmask() for adding sigmask to current->blocked
2011-08-22 14:01 ` Oleg Nesterov
@ 2011-08-22 14:04 ` Oleg Nesterov
2011-08-22 14:04 ` Oleg Nesterov
2011-08-22 15:56 ` Matt Fleming
1 sibling, 1 reply; 10+ messages in thread
From: Oleg Nesterov @ 2011-08-22 14:04 UTC (permalink / raw)
To: Matt Fleming
Cc: linux-kernel, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
Tejun Heo, Andrew Morton, Guan Xuetao, linux-arch
On 08/22, Oleg Nesterov wrote:
>
> On 08/22, Matt Fleming wrote:
> >
> > (Adding linux-arch to Cc so arch maintainers will hopefully see this)
>
> Yes, thanks.
>
> So far I applied only this patch to
>
> git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc.git ptrace
>
> But I am going to take the whole series unless I have the nack from
> maintainers. Everything looks correct.
>
> IOW, I am going to wait a bit to collect the ACKs from the maintainers
> in case (I hope ;) they want to review these changes.
>
> OK?
Forgot to mention... And of course, if someone wants to take a patch
please let me know.
Oleg.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 01/43] signal: Add block_sigmask() for adding sigmask to current->blocked
2011-08-22 14:04 ` Oleg Nesterov
@ 2011-08-22 14:04 ` Oleg Nesterov
0 siblings, 0 replies; 10+ messages in thread
From: Oleg Nesterov @ 2011-08-22 14:04 UTC (permalink / raw)
To: Matt Fleming
Cc: linux-kernel, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
Tejun Heo, Andrew Morton, Guan Xuetao, linux-arch
On 08/22, Oleg Nesterov wrote:
>
> On 08/22, Matt Fleming wrote:
> >
> > (Adding linux-arch to Cc so arch maintainers will hopefully see this)
>
> Yes, thanks.
>
> So far I applied only this patch to
>
> git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc.git ptrace
>
> But I am going to take the whole series unless I have the nack from
> maintainers. Everything looks correct.
>
> IOW, I am going to wait a bit to collect the ACKs from the maintainers
> in case (I hope ;) they want to review these changes.
>
> OK?
Forgot to mention... And of course, if someone wants to take a patch
please let me know.
Oleg.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 01/43] signal: Add block_sigmask() for adding sigmask to current->blocked
2011-08-22 14:01 ` Oleg Nesterov
2011-08-22 14:04 ` Oleg Nesterov
@ 2011-08-22 15:56 ` Matt Fleming
1 sibling, 0 replies; 10+ messages in thread
From: Matt Fleming @ 2011-08-22 15:56 UTC (permalink / raw)
To: Oleg Nesterov
Cc: linux-kernel, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
Tejun Heo, Andrew Morton, Guan Xuetao, linux-arch
On Mon, 2011-08-22 at 16:01 +0200, Oleg Nesterov wrote:
> On 08/22, Matt Fleming wrote:
> >
> > (Adding linux-arch to Cc so arch maintainers will hopefully see this)
>
> Yes, thanks.
>
> So far I applied only this patch to
>
> git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc.git ptrace
>
> But I am going to take the whole series unless I have the nack from
> maintainers. Everything looks correct.
>
> IOW, I am going to wait a bit to collect the ACKs from the maintainers
> in case (I hope ;) they want to review these changes.
>
> OK?
That's fine with me!
--
Matt Fleming, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 00/43] signal: set_current_blocked() and block_sigmask()
[not found] <1313772419-21951-1-git-send-email-matt@console-pimps.org>
[not found] ` <1313772419-21951-2-git-send-email-matt@console-pimps.org>
@ 2011-08-24 18:24 ` Oleg Nesterov
2011-08-25 4:30 ` Ian Kent
1 sibling, 1 reply; 10+ messages in thread
From: Oleg Nesterov @ 2011-08-24 18:24 UTC (permalink / raw)
To: Matt Fleming
Cc: linux-kernel, linux-arch, Ian Kent, Jan Harkes, Petr Vandrovec
(add linux-arch)
On 08/19, Matt Fleming wrote:
>
> arch/alpha/kernel/signal.c | 31 ++++++++----------------
> arch/arm/kernel/signal.c | 24 ++++++------------
> arch/avr32/kernel/signal.c | 26 ++++++--------------
> arch/blackfin/kernel/signal.c | 17 +++----------
> arch/cris/arch-v10/kernel/signal.c | 34 +++++++++-----------------
> arch/cris/arch-v32/kernel/signal.c | 37 ++++++++--------------------
> arch/frv/kernel/signal.c | 32 ++++++++-----------------
> arch/h8300/kernel/signal.c | 33 +++++++-------------------
> arch/ia64/kernel/signal.c | 15 +----------
> arch/m32r/kernel/signal.c | 12 +--------
> arch/m68k/kernel/signal_mm.c | 22 +++++++----------
> arch/m68k/kernel/signal_no.c | 28 +++++++---------------
> arch/microblaze/kernel/signal.c | 42 +++++++++++++--------------------
> arch/mips/kernel/signal.c | 27 ++++-----------------
> arch/mips/kernel/signal32.c | 20 +++------------
> arch/mips/kernel/signal_n32.c | 10 +------
> arch/mn10300/kernel/signal.c | 32 ++++++++-----------------
> arch/openrisc/kernel/signal.c | 45 +++++++++++++++--------------------
> arch/parisc/kernel/signal.c | 12 +--------
> arch/powerpc/kernel/signal.c | 13 +--------
> arch/powerpc/kernel/signal_32.c | 11 ++++----
> arch/s390/kernel/compat_signal.c | 6 +----
> arch/s390/kernel/signal.c | 6 +----
> arch/score/kernel/signal.c | 13 ++--------
> arch/sh/kernel/signal_32.c | 35 ++++++++--------------------
> arch/sh/kernel/signal_64.c | 40 ++++++++------------------------
> arch/sparc/kernel/signal32.c | 17 ++-----------
> arch/sparc/kernel/signal_32.c | 28 +++++++---------------
> arch/sparc/kernel/signal_64.c | 29 ++++++++---------------
> arch/tile/kernel/compat_signal.c | 5 +---
> arch/tile/kernel/signal.c | 13 +--------
> arch/um/kernel/signal.c | 28 +++++++---------------
> arch/um/sys-i386/signal.c | 12 +--------
> arch/um/sys-x86_64/signal.c | 6 +----
> arch/unicore32/kernel/signal.c | 13 +--------
> arch/x86/kernel/signal.c | 6 +----
> arch/xtensa/kernel/signal.c | 35 ++++++++-------------------
> fs/autofs4/waitq.c | 13 +++-------
> fs/coda/upcall.c | 19 ++++++--------
> fs/dlm/user.c | 1 -
> fs/ncpfs/sock.c | 15 ++++--------
> include/linux/signal.h | 1 +
> kernel/signal.c | 21 ++++++++++++++++
Thanks to those who replied.
I applied the whole series with a few acks we got. Other maintainers
do not care, I guess.
Oleg.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 00/43] signal: set_current_blocked() and block_sigmask()
2011-08-24 18:24 ` [PATCH v2 00/43] signal: set_current_blocked() and block_sigmask() Oleg Nesterov
@ 2011-08-25 4:30 ` Ian Kent
2011-08-25 4:30 ` Ian Kent
2011-08-25 15:31 ` Oleg Nesterov
0 siblings, 2 replies; 10+ messages in thread
From: Ian Kent @ 2011-08-25 4:30 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Matt Fleming, linux-kernel, linux-arch, Jan Harkes,
Petr Vandrovec
On Wed, 2011-08-24 at 20:24 +0200, Oleg Nesterov wrote:
> (add linux-arch)
>
> On 08/19, Matt Fleming wrote:
> >
> > arch/alpha/kernel/signal.c | 31 ++++++++----------------
> > arch/arm/kernel/signal.c | 24 ++++++------------
> > arch/avr32/kernel/signal.c | 26 ++++++--------------
> > arch/blackfin/kernel/signal.c | 17 +++----------
> > arch/cris/arch-v10/kernel/signal.c | 34 +++++++++-----------------
> > arch/cris/arch-v32/kernel/signal.c | 37 ++++++++--------------------
> > arch/frv/kernel/signal.c | 32 ++++++++-----------------
> > arch/h8300/kernel/signal.c | 33 +++++++-------------------
> > arch/ia64/kernel/signal.c | 15 +----------
> > arch/m32r/kernel/signal.c | 12 +--------
> > arch/m68k/kernel/signal_mm.c | 22 +++++++----------
> > arch/m68k/kernel/signal_no.c | 28 +++++++---------------
> > arch/microblaze/kernel/signal.c | 42 +++++++++++++--------------------
> > arch/mips/kernel/signal.c | 27 ++++-----------------
> > arch/mips/kernel/signal32.c | 20 +++------------
> > arch/mips/kernel/signal_n32.c | 10 +------
> > arch/mn10300/kernel/signal.c | 32 ++++++++-----------------
> > arch/openrisc/kernel/signal.c | 45 +++++++++++++++--------------------
> > arch/parisc/kernel/signal.c | 12 +--------
> > arch/powerpc/kernel/signal.c | 13 +--------
> > arch/powerpc/kernel/signal_32.c | 11 ++++----
> > arch/s390/kernel/compat_signal.c | 6 +----
> > arch/s390/kernel/signal.c | 6 +----
> > arch/score/kernel/signal.c | 13 ++--------
> > arch/sh/kernel/signal_32.c | 35 ++++++++--------------------
> > arch/sh/kernel/signal_64.c | 40 ++++++++------------------------
> > arch/sparc/kernel/signal32.c | 17 ++-----------
> > arch/sparc/kernel/signal_32.c | 28 +++++++---------------
> > arch/sparc/kernel/signal_64.c | 29 ++++++++---------------
> > arch/tile/kernel/compat_signal.c | 5 +---
> > arch/tile/kernel/signal.c | 13 +--------
> > arch/um/kernel/signal.c | 28 +++++++---------------
> > arch/um/sys-i386/signal.c | 12 +--------
> > arch/um/sys-x86_64/signal.c | 6 +----
> > arch/unicore32/kernel/signal.c | 13 +--------
> > arch/x86/kernel/signal.c | 6 +----
> > arch/xtensa/kernel/signal.c | 35 ++++++++-------------------
> > fs/autofs4/waitq.c | 13 +++-------
> > fs/coda/upcall.c | 19 ++++++--------
> > fs/dlm/user.c | 1 -
> > fs/ncpfs/sock.c | 15 ++++--------
> > include/linux/signal.h | 1 +
> > kernel/signal.c | 21 ++++++++++++++++
>
> Thanks to those who replied.
>
> I applied the whole series with a few acks we got. Other maintainers
> do not care, I guess.
I wouldn't say that, I didn't NAK it for autofs4.
I do appreciate the cc on the post, thanks.
Ian
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 00/43] signal: set_current_blocked() and block_sigmask()
2011-08-25 4:30 ` Ian Kent
@ 2011-08-25 4:30 ` Ian Kent
2011-08-25 15:31 ` Oleg Nesterov
1 sibling, 0 replies; 10+ messages in thread
From: Ian Kent @ 2011-08-25 4:30 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Matt Fleming, linux-kernel, linux-arch, Jan Harkes,
Petr Vandrovec
On Wed, 2011-08-24 at 20:24 +0200, Oleg Nesterov wrote:
> (add linux-arch)
>
> On 08/19, Matt Fleming wrote:
> >
> > arch/alpha/kernel/signal.c | 31 ++++++++----------------
> > arch/arm/kernel/signal.c | 24 ++++++------------
> > arch/avr32/kernel/signal.c | 26 ++++++--------------
> > arch/blackfin/kernel/signal.c | 17 +++----------
> > arch/cris/arch-v10/kernel/signal.c | 34 +++++++++-----------------
> > arch/cris/arch-v32/kernel/signal.c | 37 ++++++++--------------------
> > arch/frv/kernel/signal.c | 32 ++++++++-----------------
> > arch/h8300/kernel/signal.c | 33 +++++++-------------------
> > arch/ia64/kernel/signal.c | 15 +----------
> > arch/m32r/kernel/signal.c | 12 +--------
> > arch/m68k/kernel/signal_mm.c | 22 +++++++----------
> > arch/m68k/kernel/signal_no.c | 28 +++++++---------------
> > arch/microblaze/kernel/signal.c | 42 +++++++++++++--------------------
> > arch/mips/kernel/signal.c | 27 ++++-----------------
> > arch/mips/kernel/signal32.c | 20 +++------------
> > arch/mips/kernel/signal_n32.c | 10 +------
> > arch/mn10300/kernel/signal.c | 32 ++++++++-----------------
> > arch/openrisc/kernel/signal.c | 45 +++++++++++++++--------------------
> > arch/parisc/kernel/signal.c | 12 +--------
> > arch/powerpc/kernel/signal.c | 13 +--------
> > arch/powerpc/kernel/signal_32.c | 11 ++++----
> > arch/s390/kernel/compat_signal.c | 6 +----
> > arch/s390/kernel/signal.c | 6 +----
> > arch/score/kernel/signal.c | 13 ++--------
> > arch/sh/kernel/signal_32.c | 35 ++++++++--------------------
> > arch/sh/kernel/signal_64.c | 40 ++++++++------------------------
> > arch/sparc/kernel/signal32.c | 17 ++-----------
> > arch/sparc/kernel/signal_32.c | 28 +++++++---------------
> > arch/sparc/kernel/signal_64.c | 29 ++++++++---------------
> > arch/tile/kernel/compat_signal.c | 5 +---
> > arch/tile/kernel/signal.c | 13 +--------
> > arch/um/kernel/signal.c | 28 +++++++---------------
> > arch/um/sys-i386/signal.c | 12 +--------
> > arch/um/sys-x86_64/signal.c | 6 +----
> > arch/unicore32/kernel/signal.c | 13 +--------
> > arch/x86/kernel/signal.c | 6 +----
> > arch/xtensa/kernel/signal.c | 35 ++++++++-------------------
> > fs/autofs4/waitq.c | 13 +++-------
> > fs/coda/upcall.c | 19 ++++++--------
> > fs/dlm/user.c | 1 -
> > fs/ncpfs/sock.c | 15 ++++--------
> > include/linux/signal.h | 1 +
> > kernel/signal.c | 21 ++++++++++++++++
>
> Thanks to those who replied.
>
> I applied the whole series with a few acks we got. Other maintainers
> do not care, I guess.
I wouldn't say that, I didn't NAK it for autofs4.
I do appreciate the cc on the post, thanks.
Ian
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 00/43] signal: set_current_blocked() and block_sigmask()
2011-08-25 4:30 ` Ian Kent
2011-08-25 4:30 ` Ian Kent
@ 2011-08-25 15:31 ` Oleg Nesterov
2011-08-25 15:31 ` Oleg Nesterov
1 sibling, 1 reply; 10+ messages in thread
From: Oleg Nesterov @ 2011-08-25 15:31 UTC (permalink / raw)
To: Ian Kent; +Cc: Matt Fleming, linux-kernel, linux-arch, Jan Harkes,
Petr Vandrovec
On 08/25, Ian Kent wrote:
>
> On Wed, 2011-08-24 at 20:24 +0200, Oleg Nesterov wrote:
> >
> > > fs/autofs4/waitq.c | 13 +++-------
> >
> > I applied the whole series with a few acks we got. Other maintainers
> > do not care, I guess.
>
> I wouldn't say that, I didn't NAK it for autofs4.
I meant, "Hopefully other maintainers do not object".
We need to resubmit this patch, set_current_blocked() is not
exported. Your ack is welcomed ;)
Oleg.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 00/43] signal: set_current_blocked() and block_sigmask()
2011-08-25 15:31 ` Oleg Nesterov
@ 2011-08-25 15:31 ` Oleg Nesterov
0 siblings, 0 replies; 10+ messages in thread
From: Oleg Nesterov @ 2011-08-25 15:31 UTC (permalink / raw)
To: Ian Kent; +Cc: Matt Fleming, linux-kernel, linux-arch, Jan Harkes,
Petr Vandrovec
On 08/25, Ian Kent wrote:
>
> On Wed, 2011-08-24 at 20:24 +0200, Oleg Nesterov wrote:
> >
> > > fs/autofs4/waitq.c | 13 +++-------
> >
> > I applied the whole series with a few acks we got. Other maintainers
> > do not care, I guess.
>
> I wouldn't say that, I didn't NAK it for autofs4.
I meant, "Hopefully other maintainers do not object".
We need to resubmit this patch, set_current_blocked() is not
exported. Your ack is welcomed ;)
Oleg.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-08-25 15:34 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1313772419-21951-1-git-send-email-matt@console-pimps.org>
[not found] ` <1313772419-21951-2-git-send-email-matt@console-pimps.org>
2011-08-22 10:19 ` [PATCH 01/43] signal: Add block_sigmask() for adding sigmask to current->blocked Matt Fleming
2011-08-22 14:01 ` Oleg Nesterov
2011-08-22 14:04 ` Oleg Nesterov
2011-08-22 14:04 ` Oleg Nesterov
2011-08-22 15:56 ` Matt Fleming
2011-08-24 18:24 ` [PATCH v2 00/43] signal: set_current_blocked() and block_sigmask() Oleg Nesterov
2011-08-25 4:30 ` Ian Kent
2011-08-25 4:30 ` Ian Kent
2011-08-25 15:31 ` Oleg Nesterov
2011-08-25 15:31 ` Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox