From: "J. Bruce Fields" <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
To: NeilBrown <neilb-l3A5Bk7waGM@public.gmane.org>
Cc: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>,
Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] All Arch: remove linkage for sys_nfsservctl system call
Date: Wed, 31 Aug 2011 09:46:52 -0400 [thread overview]
Message-ID: <20110831134652.GA16897@fieldses.org> (raw)
In-Reply-To: <20110830091150.176cd08c-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
On Tue, Aug 30, 2011 at 09:11:50AM +1000, NeilBrown wrote:
> On Tue, 30 Aug 2011 08:57:52 +1000 Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
> wrote:
>
> > Hi Bruce,
> >
> > On Fri, 26 Aug 2011 18:03:11 -0400 "J. Bruce Fields" <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org> wrote:
> > >
> > > From: NeilBrown <neilb-l3A5Bk7waGM@public.gmane.org>
> > >
> > > The nfsservctl system call is now gone, so we should remove all
> > > linkage for it.
> > >
> > > Signed-off-by: NeilBrown <neilb-l3A5Bk7waGM@public.gmane.org>
> > > Signed-off-by: J. Bruce Fields <bfields-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > > ---
> > >
> > > I don't normally have to deal with this kind of cross-architecture
> > > patch; is this the right etiquette for it?
> >
> > It turns out (with hindsight) that my reaction to this patch should have
> > been:
> >
> > If you haven't built this on all architectures (an noone expects you to
> > actually do that), then it should spend a day or two in linux-next before
> > being sent to Linus.
> >
>
> Hi Stephen,
> Thanks for your help in sorting this out. I have no idea how I missed those
> few nfsservctl references but I clearly did and you and -next have proved
> valuable yet again.
>
> And really *everything* should spend a few days in linux-next before going
> to Linus. We all know that but it sometimes seem hard to *do* that ....
> until we have learnt the hard way a couple of times :-(
Yes, sorry, I'll know not to skip -next, next time....
(My excuse: I've been advertising to -next only stuff that I've done
with and committed, and this was something I wasn't even sure I should
take.
But I could have either mailed it out labelled as [RFC], or stuck it in
a throwaway branch to merge into my -next branch.)
Apologies again, and thanks for dealing with it so promptly.
--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "J. Bruce Fields" <bfields@fieldses.org>
To: NeilBrown <neilb@suse.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ben Hutchings <ben@decadent.org.uk>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH] All Arch: remove linkage for sys_nfsservctl system call
Date: Wed, 31 Aug 2011 09:46:52 -0400 [thread overview]
Message-ID: <20110831134652.GA16897@fieldses.org> (raw)
Message-ID: <20110831134652.X5Nh-dqjfk7PZueS3drgbPufu2x-qYXiz6F68xdcfa8@z> (raw)
In-Reply-To: <20110830091150.176cd08c@notabene.brown>
On Tue, Aug 30, 2011 at 09:11:50AM +1000, NeilBrown wrote:
> On Tue, 30 Aug 2011 08:57:52 +1000 Stephen Rothwell <sfr@canb.auug.org.au>
> wrote:
>
> > Hi Bruce,
> >
> > On Fri, 26 Aug 2011 18:03:11 -0400 "J. Bruce Fields" <bfields@fieldses.org> wrote:
> > >
> > > From: NeilBrown <neilb@suse.de>
> > >
> > > The nfsservctl system call is now gone, so we should remove all
> > > linkage for it.
> > >
> > > Signed-off-by: NeilBrown <neilb@suse.de>
> > > Signed-off-by: J. Bruce Fields <bfields@redhat.com>
> > > ---
> > >
> > > I don't normally have to deal with this kind of cross-architecture
> > > patch; is this the right etiquette for it?
> >
> > It turns out (with hindsight) that my reaction to this patch should have
> > been:
> >
> > If you haven't built this on all architectures (an noone expects you to
> > actually do that), then it should spend a day or two in linux-next before
> > being sent to Linus.
> >
>
> Hi Stephen,
> Thanks for your help in sorting this out. I have no idea how I missed those
> few nfsservctl references but I clearly did and you and -next have proved
> valuable yet again.
>
> And really *everything* should spend a few days in linux-next before going
> to Linus. We all know that but it sometimes seem hard to *do* that ....
> until we have learnt the hard way a couple of times :-(
Yes, sorry, I'll know not to skip -next, next time....
(My excuse: I've been advertising to -next only stuff that I've done
with and committed, and this was something I wasn't even sure I should
take.
But I could have either mailed it out labelled as [RFC], or stuck it in
a throwaway branch to merge into my -next branch.)
Apologies again, and thanks for dealing with it so promptly.
--b.
next prev parent reply other threads:[~2011-08-31 13:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1312810169.2591.1153.camel@deadeye>
[not found] ` <20110808155538.GB904@fieldses.org>
[not found] ` <20110808180658.GC29924@decadent.org.uk>
[not found] ` <20110808180658.GC29924-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
2011-08-26 22:03 ` [PATCH] All Arch: remove linkage for sys_nfsservctl system call J. Bruce Fields
2011-08-26 22:03 ` J. Bruce Fields
2011-08-26 23:32 ` Ben Hutchings
[not found] ` <20110826233258.GE24107-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
2011-08-26 23:52 ` J. Bruce Fields
2011-08-26 23:52 ` J. Bruce Fields
2011-08-27 0:01 ` David Miller
2011-08-27 14:39 ` Mike Frysinger
2011-08-28 21:12 ` David Miller
2011-08-28 23:50 ` Tony Breeds
2011-08-28 23:50 ` Tony Breeds
[not found] ` <20110826220311.GA18140-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2011-08-29 22:57 ` Stephen Rothwell
2011-08-29 22:57 ` Stephen Rothwell
2011-08-29 23:11 ` NeilBrown
[not found] ` <20110830091150.176cd08c-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2011-08-31 13:46 ` J. Bruce Fields [this message]
2011-08-31 13:46 ` J. Bruce Fields
2011-08-31 10:15 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110831134652.GA16897@fieldses.org \
--to=bfields-uc3wqj2krung9huczpvpmw@public.gmane.org \
--cc=ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=neilb-l3A5Bk7waGM@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).