linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Kuo <rkuo@codeaurora.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-arch@vger.kernel.org, linux-hexagon@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Linas Vepstas <linas@codeaurora.org>
Subject: Re: [patch v3 21/36] Hexagon: Add SMP support
Date: Mon, 12 Sep 2011 18:38:27 -0500	[thread overview]
Message-ID: <20110912233827.GB6925@codeaurora.org> (raw)
In-Reply-To: <1315752712.455.50.camel@pasglop>

On Sun, Sep 11, 2011 at 11:51:52AM -0300, Benjamin Herrenschmidt wrote:
> And on the producer side, a spinlock for one or... that looks like wheel
> re-inventing to me :-)
> 
> In fact your bit iteration loop also re-invents find_*_bit interfaces.
> 
> Any reason why you don't simply use bitops or atomics here ?

No particular reason; just the way it turned out when I was getting things
working.  I'll get them cleaned up.


> Also what is your memory model ? ordered or weakly ordered ? Do you need
> some kind of memory barrier between setting ipi->bits and
> __vmintop_post() ?

Our model is ordered, so there's no need for a barrier there yet.


Thanks,
Richard Kuo


-- 

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2011-09-12 23:38 UTC|newest]

Thread overview: 124+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-09  1:08 [patch v3 00/36] Hexagon: Add support for Qualcomm Hexagon architecture Richard Kuo
2011-09-09  1:08 ` Richard Kuo
2011-09-09  1:08 ` [patch v3 01/36] Hexagon: Add generic headers Richard Kuo
2011-09-09  1:08   ` Richard Kuo
2011-09-09  1:08 ` [patch v3 02/36] Hexagon: Core arch-specific header files Richard Kuo
2011-09-09  1:08   ` Richard Kuo
2011-09-09  1:08 ` [patch v3 03/36] Hexagon: Add bitops support Richard Kuo
2011-09-09  1:08 ` [patch v3 04/36] Hexagon: Add atomic ops support Richard Kuo
2011-09-09  1:08   ` Richard Kuo
2011-09-09  1:08 ` [patch v3 05/36] Hexagon: Add syscalls Richard Kuo
2011-09-09  1:08   ` Richard Kuo
2011-09-09  8:05   ` Arnd Bergmann
2011-09-09  1:08 ` [patch v3 06/36] Hexagon: Add processor and system headers Richard Kuo
2011-09-09  1:08   ` Richard Kuo
2011-09-09  1:08 ` [patch v3 07/36] Hexagon: Add threadinfo Richard Kuo
2011-09-09  1:08   ` Richard Kuo
2011-09-09  1:08 ` [patch v3 08/36] Hexagon: Add delay functions Richard Kuo
2011-09-09  1:08   ` Richard Kuo
2011-09-09  8:07   ` Arnd Bergmann
2011-09-09  8:07     ` Arnd Bergmann
2011-09-09  1:08 ` [patch v3 09/36] Hexagon: Add checksum functions Richard Kuo
2011-09-09  1:08 ` [patch v3 10/36] Hexagon: Add memcpy and memset accelerated functions Richard Kuo
2011-09-09  1:08   ` Richard Kuo
2011-09-09  1:08 ` [patch v3 11/36] Hexagon: Add hypervisor interface Richard Kuo
2011-09-09  1:08   ` Richard Kuo
2011-09-09  1:08 ` [patch v3 12/36] Hexagon: Export ksyms defined in assembly files Richard Kuo
2011-09-09  1:08   ` Richard Kuo
2011-09-09  1:09 ` [patch v3 13/36] Hexagon: Support dynamic module loading Richard Kuo
2011-09-09  1:09   ` Richard Kuo
2011-09-09  1:09 ` [patch v3 14/36] Hexagon: Add signal functions Richard Kuo
2011-09-09  8:12   ` Arnd Bergmann
2011-09-09  8:12     ` Arnd Bergmann
2011-09-11 14:59   ` Benjamin Herrenschmidt
2011-09-09  1:09 ` [patch v3 15/36] Hexagon: Add init_task and process functions Richard Kuo
2011-09-09  1:09 ` [patch v3 16/36] Hexagon: Add startup code Richard Kuo
2011-09-09  1:09 ` [patch v3 17/36] Hexagon: Add interrupts Richard Kuo
2011-09-09  1:09   ` Richard Kuo
2011-09-09 13:04   ` Thomas Gleixner
2011-09-09 18:57   ` Linas Vepstas (Code Aurora)
2011-09-09 18:57     ` Linas Vepstas (Code Aurora)
2011-09-09  1:09 ` [patch v3 18/36] Hexagon: Add time and timer functions Richard Kuo
2011-09-09  8:23   ` Arnd Bergmann
2011-09-09  8:23     ` Arnd Bergmann
2011-09-09 13:13   ` Thomas Gleixner
2011-09-09 13:13     ` Thomas Gleixner
2011-09-09  1:09 ` [patch v3 19/36] Hexagon: Add ptrace support Richard Kuo
2011-09-09  1:09   ` Richard Kuo
2011-09-09  8:15   ` Arnd Bergmann
2011-09-09  8:15     ` Arnd Bergmann
2011-09-09 20:15   ` Jonas Bonn
2011-09-09 20:15     ` Jonas Bonn
2011-09-09 21:18     ` Linas Vepstas (Code Aurora)
2011-09-10  6:42       ` Jonas Bonn
2011-09-10  6:42         ` Jonas Bonn
2011-09-10 11:21         ` Arnd Bergmann
2011-09-10 11:21           ` Arnd Bergmann
2011-09-10 11:29         ` Pedro Alves
2011-09-10 11:29           ` Pedro Alves
2011-09-19 15:25           ` Linas Vepstas (Code Aurora)
2011-09-21 16:15             ` Pedro Alves
2011-09-21 16:15               ` Pedro Alves
2011-09-21 17:50               ` Linas Vepstas (Code Aurora)
2011-09-21 17:50                 ` Linas Vepstas (Code Aurora)
2011-09-21 18:04                 ` Pedro Alves
2011-09-21 18:04                   ` Pedro Alves
2011-09-09  1:09 ` [patch v3 20/36] Hexagon: Provide basic debugging and system trap support Richard Kuo
2011-09-09  1:09   ` Richard Kuo
2011-09-09  1:09 ` [patch v3 21/36] Hexagon: Add SMP support Richard Kuo
2011-09-09  1:09   ` Richard Kuo
2011-09-09  8:16   ` Arnd Bergmann
2011-09-09  8:16     ` Arnd Bergmann
2011-09-09 13:24   ` Thomas Gleixner
2011-09-09 13:24     ` Thomas Gleixner
2011-09-11 14:51   ` Benjamin Herrenschmidt
2011-09-12 23:38     ` Richard Kuo [this message]
2011-09-09  1:09 ` [patch v3 22/36] Hexagon: Add locking types and functions Richard Kuo
2011-09-09  1:09   ` Richard Kuo
2011-09-09  8:17   ` Arnd Bergmann
2011-09-09  8:17     ` Arnd Bergmann
2011-09-09  1:09 ` [patch v3 23/36] Hexagon: Add user access functions Richard Kuo
2011-09-09  1:09 ` [patch v3 24/36] Hexagon: Provide basic implementation and/or stubs for I/O routines Richard Kuo
2011-09-09  1:09   ` Richard Kuo
2011-09-09  8:18   ` Arnd Bergmann
2011-09-09  8:18     ` Arnd Bergmann
2011-09-09 19:14   ` Linas Vepstas (Code Aurora)
2011-09-09 19:14     ` Linas Vepstas (Code Aurora)
2011-09-09 21:13     ` Arnd Bergmann
2011-09-09 21:13       ` Arnd Bergmann
2011-09-10 20:02       ` Taylor Simpson
2011-09-10 20:02         ` Taylor Simpson
2011-09-11 14:46         ` Benjamin Herrenschmidt
2011-09-11 14:46           ` Benjamin Herrenschmidt
2011-09-09  1:09 ` [patch v3 25/36] Hexagon: Implement basic cache-flush support Richard Kuo
2011-09-09  1:09 ` [patch v3 26/36] Hexagon: Implement basic TLB management routines for Hexagon Richard Kuo
2011-09-09  1:09   ` Richard Kuo
2011-09-09  1:09 ` [patch v3 27/36] Hexagon: Provide DMA implementation Richard Kuo
2011-09-09  1:09 ` [patch v3 28/36] Hexagon: Add ioremap support Richard Kuo
2011-09-09  1:09   ` Richard Kuo
2011-09-09  8:19   ` Arnd Bergmann
2011-09-09  8:19     ` Arnd Bergmann
2011-09-09  1:09 ` [patch v3 29/36] Hexagon: Add page table header files & etc Richard Kuo
2011-09-09  8:20   ` Arnd Bergmann
2011-09-09  1:09 ` [patch v3 30/36] Hexagon: Add page-fault support Richard Kuo
2011-09-09  1:09   ` Richard Kuo
2011-09-11 15:08   ` Benjamin Herrenschmidt
2011-09-11 15:08     ` Benjamin Herrenschmidt
2011-09-13  1:34     ` Richard Kuo
2011-09-13  1:34       ` Richard Kuo
2011-09-09  1:09 ` [patch v3 31/36] Hexagon: kgdb support files Richard Kuo
2011-09-09  1:09   ` Richard Kuo
2011-09-09  1:09 ` [patch v3 32/36] Hexagon: Comet platform support Richard Kuo
2011-09-09  1:09   ` Richard Kuo
2011-09-09  1:09 ` [patch v3 33/36] Hexagon: Add configuration and makefiles for the Hexagon architecture Richard Kuo
2011-09-09  1:09   ` Richard Kuo
2011-09-09  1:09 ` [patch v3 34/36] Hexagon: Add basic stacktrace functionality for " Richard Kuo
2011-09-09  1:09   ` Richard Kuo
2011-09-09  1:09 ` [patch v3 35/36] Hexagon: Add self to MAINTAINERS Richard Kuo
2011-09-09  1:09   ` Richard Kuo
2011-09-09  8:21   ` Arnd Bergmann
2011-09-09  8:21     ` Arnd Bergmann
2011-09-09  1:09 ` [patch v3 36/36] Add extra arch overrides to asm-generic/checksum.h Richard Kuo
2011-09-09  1:09   ` Richard Kuo
2011-09-09  8:39 ` [patch v3 00/36] Hexagon: Add support for Qualcomm Hexagon architecture Arnd Bergmann
2011-09-09  8:39   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110912233827.GB6925@codeaurora.org \
    --to=rkuo@codeaurora.org \
    --cc=benh@kernel.crashing.org \
    --cc=linas@codeaurora.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-hexagon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).