From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 3/3] truncate()/ftruncate() fix length argument on ia32 emulation.
Date: Mon, 19 Sep 2011 15:16:31 +0200 [thread overview]
Message-ID: <20110919131631.GA2355@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <1316282477.5814.19.camel@localhost.localdomain>
On Sat, Sep 17, 2011 at 08:01:17PM +0200, Thomas Meyer wrote:
> move signed-extended int to long, because of signed test.
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
[...]
> +asmlinkage long compat_sys_ftruncate(unsigned int fd, int length)
> +{
> + return sys_ftruncate(fd, length);
> +}
That seems to be wrong... just look at this patch I sent two years
ago (which btw. introduced the compat truncate sign extension bug
on some architecutures).
http://www.spinics.net/lists/linux-arch/msg08633.html
prev parent reply other threads:[~2011-09-19 13:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-17 18:01 [PATCH 3/3] truncate()/ftruncate() fix length argument on ia32 emulation Thomas Meyer
2011-09-18 15:26 ` Arnd Bergmann
2011-09-19 13:16 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110919131631.GA2355@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).