From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yong Zhang Subject: Re: [PATCH 53/57] sound: irq: Remove IRQF_DISABLED Date: Wed, 21 Sep 2011 20:12:41 +0800 Message-ID: <20110921121241.GC2550@zhy> References: <1316597339-29861-1-git-send-email-yong.zhang0@gmail.com> <1316597339-29861-54-git-send-email-yong.zhang0@gmail.com> Reply-To: Yong Zhang Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org To: Thomas Gleixner Cc: alsa-devel@alsa-project.org, Kuninori Morimoto , Takashi Iwai , Clemens Ladisch , Jaroslav Kysela , Peter Ujfalusi , Paul Gortmaker , linux-arch@vger.kernel.org, Russell King , Jassi Brar , Manuel Lauss , Uwe =?utf-8?Q?Kleine-K=EF=BF=BDnig?= , Axel Lin , Liam Girdwood , cbe-oss-dev@lists.ozlabs.org, Wan ZongShun , Lucas De Marchi , linux-arm-kernel@lists.infradead.org, Eric Miao , Sangbeom Kim , Jiri Kosina , Mark Brown , linux-kernel@vger.kernel List-Id: linux-arch.vger.kernel.org On Wed, Sep 21, 2011 at 11:55:36AM +0200, Thomas Gleixner wrote: > On Wed, 21 Sep 2011, Takashi Iwai wrote: > > > At Wed, 21 Sep 2011 17:28:54 +0800, > > Yong Zhang wrote: > > > > > > Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled], > > > > Hm, this id hits a different commit: > > commit c58543c869606532c2382f027d6466f4672ea756 > > Author: David S. Miller > > Date: Tue Oct 13 00:49:09 2009 -0700 > > > > sparc64: Set IRQF_DISABLED on LDC channel IRQs. > > > > You mean commit e58aa3d2d0cc01ad8d6f7f640a0670433f794922? > > Yeah. > > > > We run all interrupt handlers with interrupts disabled > > > and we even check and yell when an interrupt handler > > > returns with interrupts enabled (see commit [b738a50a: > > > genirq: Warn when handler enables interrupts]). > > > > > > So now this flag is a NOOP and can be removed. > > > > > > Signed-off-by: Yong Zhang > > > Acked-by: Mark Brown > > > > Do you want to merge by yourself or shall I take it to sound git tree? > > Since IRQF_DISABLED isn't used, it can be applied safely in 3.1-based > > tree, right? > > Yes, please go ahead. I'll pick up the leftovers. Takashi, if you take it, could you please modify that commit id to the right one? Otherwise I could change it when I refresh this patchset. Thanks, Yong