From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Rusty Russell <rusty@ozlabs.org>
Cc: mingo@elte.hu, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-arch@vger.kernel.org
Subject: Re: [RFC/PULL 00/11] introduce export.h; reduce module.h usage
Date: Thu, 13 Oct 2011 17:51:43 -0400 [thread overview]
Message-ID: <20111013215142.GB28189@windriver.com> (raw)
In-Reply-To: <87botlej9o.fsf@rustcorp.com.au>
[Re: [RFC/PULL 00/11] introduce export.h; reduce module.h usage] On 13/10/2011 (Thu 12:37) Rusty Russell wrote:
> On Thu, 28 Jul 2011 01:16:07 -0400, Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> > I don't think there really is any rocket science or contentious stuff here.
> > It is a sensible cleanup that adds organization and speeds up compiles.
> > The RFC I'm hoping for is more about how/when we want to get this in tree.
>
> In future, when you're ripping into module.h, please CC the module
> maintainer. It's not just a courtesy, it helps everyone avoid redundant
> work.
Sorry about that. I think I'd created the original module.h patch in
the context of the thread that Ingo started, and it never crossed my
mind at the time to run get_maintainer.pl on module.h itself. And
that patch hasn't changed since. An oversight on my part. :(
>
> You may insert your own sarcastic comment about "rocket science" here.
Yeah, fair enough -- remembering to CC maintainers isn't rocket science.
I hope you'll accept that it was an honest oversight caused by
circumstance and that it wasn't an intentional exclusion.
>
> As to the patch: it's marginal improvement, but it's neater and I'm
> happy you're doing it.
Thanks -- I'm glad at least the end result is OK with you.
Paul.
>
> Thanks,
> Rusty.
prev parent reply other threads:[~2011-10-13 21:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 5:16 [RFC/PULL 00/11] introduce export.h; reduce module.h usage Paul Gortmaker
2011-07-28 5:16 ` [PATCH 01/11] module.h: split out the EXPORT_SYMBOL for faster compiles Paul Gortmaker
2011-07-28 5:16 ` [PATCH 02/11] sysdev.h: dont include <linux/module.h> for no reason Paul Gortmaker
2011-07-28 5:16 ` [PATCH 03/11] net: inet_timewait_sock doesnt need <linux/module.h> Paul Gortmaker
2011-07-28 5:16 ` [PATCH 04/11] device_cgroup.h: delete needless include <linux/module.h> Paul Gortmaker
2011-07-28 5:16 ` [PATCH 05/11] crypto.h: remove unused crypto_tfm_alg_modname() inline Paul Gortmaker
2011-07-28 5:16 ` [PATCH 06/11] linux/stop_machine.h: fix implicit use of smp.h for smp_processor_id Paul Gortmaker
2011-07-28 5:16 ` Paul Gortmaker
2011-07-28 5:16 ` [PATCH 07/11] pm_runtime.h: explicitly requires notifier.h Paul Gortmaker
2011-07-28 5:16 ` Paul Gortmaker
2011-07-28 5:16 ` [PATCH 08/11] uwb.h: fix implicit use of asm/page.h for PAGE_SIZE Paul Gortmaker
2011-07-28 5:16 ` [PATCH 09/11] net: sch_generic remove redundant use of <linux/module.h> Paul Gortmaker
2011-07-28 5:16 ` [PATCH 10/11] include: convert various register fcns to macros to avoid include chaining Paul Gortmaker
2011-07-28 5:16 ` Paul Gortmaker
2011-07-28 5:16 ` [PATCH 11/11] include: replace linux/module.h with "struct module" wherever possible Paul Gortmaker
2011-07-28 5:16 ` Paul Gortmaker
2011-07-28 7:15 ` [RFC/PULL 00/11] introduce export.h; reduce module.h usage Ingo Molnar
2011-07-28 15:42 ` Paul Gortmaker
2011-07-29 1:20 ` Stephen Rothwell
2011-08-01 11:49 ` Geert Uytterhoeven
2011-08-02 5:02 ` Paul Gortmaker
2011-08-02 6:54 ` Geert Uytterhoeven
2011-07-28 9:40 ` Anca Emanuel
2011-07-28 13:19 ` Linus Torvalds
2011-07-28 15:27 ` Paul Gortmaker
2011-07-28 19:18 ` Ingo Molnar
2011-08-02 18:30 ` Paul Gortmaker
2011-08-08 2:42 ` Mike Frysinger
2011-08-10 19:09 ` Paul Gortmaker
2011-08-11 4:34 ` Mike Frysinger
2011-08-11 13:10 ` Paul Gortmaker
2011-08-11 13:10 ` Paul Gortmaker
2011-08-11 17:15 ` Mike Frysinger
2011-08-11 17:20 ` Paul Gortmaker
2011-10-13 2:07 ` Rusty Russell
2011-10-13 21:51 ` Paul Gortmaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013215142.GB28189@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@ozlabs.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).