From: Grant Likely <grant.likely@secretlab.ca>
To: Hamo <hamo.by@gmail.com>
Cc: arnd@arndb.de, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] gpio: fix build error in include/asm-generic/gpio.h
Date: Tue, 25 Oct 2011 00:06:25 +0200 [thread overview]
Message-ID: <20111024220625.GD4394@ponder.secretlab.ca> (raw)
In-Reply-To: <CAO_0yfOa7B4tB1nJg8c_5a612KjNmPh_aMvS=wHhfU_maAvZAg@mail.gmail.com>
On Fri, Oct 21, 2011 at 09:38:32AM +0800, Hamo wrote:
> Should call the platform-specific __gpio_{get,set}_value
> instead of generic gpio_{get,set}_value
>
> Signed-off-by: Yang Bai <hamo.by@gmail.com>
Applied, thanks.
> ---
> include/asm-generic/gpio.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h
> index d494001..6acff5d 100644
> --- a/include/asm-generic/gpio.h
> +++ b/include/asm-generic/gpio.h
> @@ -220,13 +220,13 @@ static inline int gpio_cansleep(unsigned gpio)
> static inline int gpio_get_value_cansleep(unsigned gpio)
> {
> might_sleep();
> - return gpio_get_value(gpio);
> + return __gpio_get_value(gpio);
> }
>
> static inline void gpio_set_value_cansleep(unsigned gpio, int value)
> {
> might_sleep();
> - gpio_set_value(gpio, value);
> + __gpio_set_value(gpio, value);
> }
>
> #endif /* !CONFIG_GPIOLIB */
> --
> 1.7.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2011-10-24 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-21 1:38 [PATCH] gpio: fix build error in include/asm-generic/gpio.h Hamo
2011-10-21 11:39 ` Arnd Bergmann
2011-10-24 22:04 ` Grant Likely
2011-10-25 11:23 ` Arnd Bergmann
[not found] ` <CACxGe6v9ZsK9KqUyZR76b0n3pTs6ykkQUJ6UtWooH9QvoFi16A@mail.gmail.com>
2011-10-26 1:36 ` Hamo
2011-10-24 22:06 ` Grant Likely [this message]
2011-11-02 20:16 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111024220625.GD4394@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=arnd@arndb.de \
--cc=hamo.by@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).